From: Minchan Kim <minchan@kernel.org>
To: John Stultz <john.stultz@linaro.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Hyesoo Yu <hyesoo.yu@samsung.com>,
david@redhat.com, Michal Hocko <mhocko@suse.com>,
Suren Baghdasaryan <surenb@google.com>,
KyongHo Cho <pullip.cho@samsung.com>,
John Dias <joaodias@google.com>,
Hridya Valsaraju <hridya@google.com>,
Sumit Semwal <sumit.semwal@linaro.org>,
linux-media <linux-media@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Rob Herring <robh+dt@kernel.org>,
"moderated list:DMA BUFFER SHARING FRAMEWORK"
<linaro-mm-sig@lists.linaro.org>
Subject: Re: [PATCH v4 4/4] dma-buf: heaps: add chunk heap to dmabuf heaps
Date: Tue, 26 Jan 2021 11:24:43 -0800 [thread overview]
Message-ID: <YBBse31hUxQcglig@google.com> (raw)
In-Reply-To: <CALAqxLWJDo=pM8bvt9YWrzJ+VyK5gojoL-v7ch1fQC=cjGwJOw@mail.gmail.com>
On Mon, Jan 25, 2021 at 11:32:57PM -0800, John Stultz wrote:
> On Thu, Jan 21, 2021 at 9:55 AM Minchan Kim <minchan@kernel.org> wrote:
>
> Hey Minchan,
> Thanks for sending this out! I'm still working through testing with
> this patch set, so I may have some more feedback tomorrow, but a few
> quick items I did hit below.
>
> > +
> > +#define CHUNK_PREFIX "chunk-"
> > +
> > +static int register_chunk_heap(struct chunk_heap *chunk_heap_info)
> > +{
> > + struct dma_heap_export_info exp_info;
> > + const char *name = cma_get_name(chunk_heap_info->cma);
> > + size_t len = strlen(CHUNK_PREFIX) + strlen(name) + 1;
> > + char *buf = kmalloc(len, GFP_KERNEL);
> > +
> > + if (!buf)
> > + return -ENOMEM;
> > +
> > + sprintf(buf, CHUNK_PREFIX"%s", cma_get_name(chunk_heap_info->cma));
> > + buf[len] = '\0';
> > +
> > + exp_info.name = buf;
> > + exp_info.name = cma_get_name(chunk_heap_info->cma);
>
> I think you intended to delete this line, as it's overwriting your
> prefixed name.
Hi John,
You're right. Will fix it.
>
> > + exp_info.ops = &chunk_heap_ops;
> > + exp_info.priv = chunk_heap_info;
> > +
> > + chunk_heap_info->heap = dma_heap_add(&exp_info);
> > + if (IS_ERR(chunk_heap_info->heap)) {
> > + kfree(buf);
> > + return PTR_ERR(chunk_heap_info->heap);
> > + }
> > +
> > + return 0;
> > +}
> > +
> > +static int __init chunk_heap_init(void)
> > +{
> > + unsigned int i;
> > +
> > + for (i = 0; i < chunk_heap_count; i++)
> > + register_chunk_heap(&chunk_heaps[i]);
> > +
> > + return 0;
> > +}
> > +module_init(chunk_heap_init);
> > +
> > +#ifdef CONFIG_OF_EARLY_FLATTREE
> > +
> > +static int __init dmabuf_chunk_heap_area_init(struct reserved_mem *rmem)
> > +{
> > + int ret;
> > + struct cma *cma;
> > + struct chunk_heap *chunk_heap_info;
> > + const __be32 *chunk_order;
> > +
> > + phys_addr_t align = PAGE_SIZE << max(MAX_ORDER - 1, pageblock_order);
> > + phys_addr_t mask = align - 1;
> > +
> > + if ((rmem->base & mask) || (rmem->size & mask)) {
> > + pr_err("Incorrect alignment for CMA region\n");
> > + return -EINVAL;
>
> Passing this check can be tough if you're using dynamically assigned
> rmem, so it might be helpful for debugging to print the base/size/mask
> values?
Let me fold this into next respin.
diff --git a/drivers/dma-buf/heaps/chunk_heap.c b/drivers/dma-buf/heaps/chunk_heap.c
index 6fe8e69d108f..cc2ed5341b54 100644
--- a/drivers/dma-buf/heaps/chunk_heap.c
+++ b/drivers/dma-buf/heaps/chunk_heap.c
@@ -456,7 +456,8 @@ static int __init dmabuf_chunk_heap_area_init(struct reserved_mem *rmem)
phys_addr_t mask = align - 1;
if ((rmem->base & mask) || (rmem->size & mask)) {
- pr_err("Incorrect alignment for CMA region\n");
+ pr_err("Incorrect alignment for CMA region: base %pa size %pa mask %pa\n",
+ rmem->base, rmem->size, mask);
return -EINVAL;
}
Thanks for the review, John!
next prev parent reply other threads:[~2021-01-26 23:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 17:54 [PATCH v4 0/4] Chunk Heap Support on DMA-HEAP Minchan Kim
2021-01-21 17:54 ` [PATCH v4 1/4] mm: cma: introduce gfp flag in cma_alloc instead of no_warn Minchan Kim
2021-01-21 18:46 ` David Hildenbrand
2021-01-21 18:50 ` Minchan Kim
2021-01-25 13:07 ` Michal Hocko
2021-01-25 19:42 ` Minchan Kim
2021-01-26 7:38 ` Michal Hocko
2021-01-26 19:12 ` Minchan Kim
2021-01-27 20:21 ` Minchan Kim
2021-01-21 17:55 ` [PATCH v4 2/4] mm: failfast mode with __GFP_NORETRY in alloc_contig_range Minchan Kim
2021-01-25 13:12 ` Michal Hocko
2021-01-25 13:13 ` Michal Hocko
2021-01-25 19:33 ` Minchan Kim
2021-01-26 7:44 ` Michal Hocko
2021-01-26 19:10 ` Minchan Kim
2021-01-27 8:14 ` Michal Hocko
2021-01-27 20:42 ` Minchan Kim
2021-01-28 7:53 ` Michal Hocko
2021-01-28 16:56 ` Minchan Kim
2021-01-21 17:55 ` [PATCH v4 3/4] dt-bindings: reserved-memory: Make DMA-BUF CMA heap DT-configurable Minchan Kim
2021-01-26 7:07 ` John Stultz
2021-01-27 20:25 ` Hridya Valsaraju
2021-02-05 22:55 ` Rob Herring
2021-01-21 17:55 ` [PATCH v4 4/4] dma-buf: heaps: add chunk heap to dmabuf heaps Minchan Kim
2021-01-26 7:07 ` Christoph Hellwig
2021-01-26 19:27 ` Minchan Kim
2021-01-26 7:32 ` John Stultz
2021-01-26 19:24 ` Minchan Kim [this message]
2021-01-26 7:46 ` Michal Hocko
2021-01-26 19:25 ` Minchan Kim
2021-01-27 8:09 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBBse31hUxQcglig@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=hch@infradead.org \
--cc=hridya@google.com \
--cc=hyesoo.yu@samsung.com \
--cc=joaodias@google.com \
--cc=john.stultz@linaro.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=pullip.cho@samsung.com \
--cc=robh+dt@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).