From: Minchan Kim <minchan@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
hyesoo.yu@samsung.com, david@redhat.com, mhocko@suse.com,
surenb@google.com, pullip.cho@samsung.com, joaodias@google.com,
hridya@google.com, john.stultz@linaro.org,
sumit.semwal@linaro.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH v4 4/4] dma-buf: heaps: add chunk heap to dmabuf heaps
Date: Tue, 26 Jan 2021 11:27:35 -0800 [thread overview]
Message-ID: <YBBtJ7zMrkdcNMuV@google.com> (raw)
In-Reply-To: <20210126070744.GA1244507@infradead.org>
On Tue, Jan 26, 2021 at 07:07:44AM +0000, Christoph Hellwig wrote:
> > +config DMABUF_HEAPS_CHUNK
> > + bool "DMA-BUF CHUNK Heap"
> > + depends on DMABUF_HEAPS && DMA_CMA
> > + help
> > + Choose this option to enable dma-buf CHUNK heap. This heap is backed
> > + by the Contiguous Memory Allocator (CMA) and allocates the buffers that
> > + are arranged into a list of fixed size chunks taken from CMA.
>
> Overly long line, which in text flowing text is really, really annoying.
>
> Many more later. Remember that > 80 chars are only allowed if they
> significantly improve readability.
Let me make it shorter than 80 chars in next revision.
Thanks for the reivew, Christoph.
next prev parent reply other threads:[~2021-01-27 10:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 17:54 [PATCH v4 0/4] Chunk Heap Support on DMA-HEAP Minchan Kim
2021-01-21 17:54 ` [PATCH v4 1/4] mm: cma: introduce gfp flag in cma_alloc instead of no_warn Minchan Kim
2021-01-21 18:46 ` David Hildenbrand
2021-01-21 18:50 ` Minchan Kim
2021-01-25 13:07 ` Michal Hocko
2021-01-25 19:42 ` Minchan Kim
2021-01-26 7:38 ` Michal Hocko
2021-01-26 19:12 ` Minchan Kim
2021-01-27 20:21 ` Minchan Kim
2021-01-21 17:55 ` [PATCH v4 2/4] mm: failfast mode with __GFP_NORETRY in alloc_contig_range Minchan Kim
2021-01-25 13:12 ` Michal Hocko
2021-01-25 13:13 ` Michal Hocko
2021-01-25 19:33 ` Minchan Kim
2021-01-26 7:44 ` Michal Hocko
2021-01-26 19:10 ` Minchan Kim
2021-01-27 8:14 ` Michal Hocko
2021-01-27 20:42 ` Minchan Kim
2021-01-28 7:53 ` Michal Hocko
2021-01-28 16:56 ` Minchan Kim
2021-01-21 17:55 ` [PATCH v4 3/4] dt-bindings: reserved-memory: Make DMA-BUF CMA heap DT-configurable Minchan Kim
2021-01-26 7:07 ` John Stultz
2021-01-27 20:25 ` Hridya Valsaraju
2021-02-05 22:55 ` Rob Herring
2021-01-21 17:55 ` [PATCH v4 4/4] dma-buf: heaps: add chunk heap to dmabuf heaps Minchan Kim
2021-01-26 7:07 ` Christoph Hellwig
2021-01-26 19:27 ` Minchan Kim [this message]
2021-01-26 7:32 ` John Stultz
2021-01-26 19:24 ` Minchan Kim
2021-01-26 7:46 ` Michal Hocko
2021-01-26 19:25 ` Minchan Kim
2021-01-27 8:09 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBBtJ7zMrkdcNMuV@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=hch@infradead.org \
--cc=hridya@google.com \
--cc=hyesoo.yu@samsung.com \
--cc=joaodias@google.com \
--cc=john.stultz@linaro.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=pullip.cho@samsung.com \
--cc=robh+dt@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).