From: Andrew Lunn <andrew@lunn.ch>
To: Harini Katakam <harini.katakam@xilinx.com>
Cc: robh+dt@kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, kuba@kernel.org,
steen.hegelund@microchip.com, bjarni.jonasson@microchip.com,
ioana.ciornei@nxp.com, likaige@loongson.cn,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, harinikatakamlinux@gmail.com,
michal.simek@xilinx.com, radhey.shyam.pandey@xilinx.com
Subject: Re: [PATCH 1/3] include: dt-bindings: Add mscc-vsc8531 RGMII clock delay definitions
Date: Tue, 29 Jun 2021 15:58:23 +0200 [thread overview]
Message-ID: <YNsm/0dmpBgO8mqr@lunn.ch> (raw)
In-Reply-To: <20210629094038.18610-2-harini.katakam@xilinx.com>
On Tue, Jun 29, 2021 at 03:10:36PM +0530, Harini Katakam wrote:
> Add RGMII clock delay definitions in mscc-phy-vsc8531 header.
>
> Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> include/dt-bindings/net/mscc-phy-vsc8531.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/include/dt-bindings/net/mscc-phy-vsc8531.h b/include/dt-bindings/net/mscc-phy-vsc8531.h
> index 9eb2ec2b2ea9..242eb4c7ede9 100644
> --- a/include/dt-bindings/net/mscc-phy-vsc8531.h
> +++ b/include/dt-bindings/net/mscc-phy-vsc8531.h
> @@ -28,4 +28,13 @@
> #define VSC8531_FORCE_LED_OFF 14
> #define VSC8531_FORCE_LED_ON 15
>
> +#define VSC8531_RGMII_CLK_DELAY_0_2_NS 0
> +#define VSC8531_RGMII_CLK_DELAY_0_8_NS 1
> +#define VSC8531_RGMII_CLK_DELAY_1_1_NS 2
> +#define VSC8531_RGMII_CLK_DELAY_1_7_NS 3
> +#define VSC8531_RGMII_CLK_DELAY_2_0_NS 4
> +#define VSC8531_RGMII_CLK_DELAY_2_3_NS 5
> +#define VSC8531_RGMII_CLK_DELAY_2_6_NS 6
> +#define VSC8531_RGMII_CLK_DELAY_3_4_NS 7
Using defines like this is no longer used. Please specify the delay in
pS and convert to a register value within the driver.
Andrew
next prev parent reply other threads:[~2021-06-29 13:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 9:40 [PATCH 0/3] Add support for VSC8531_02 PHY and DT RGMII tuning Harini Katakam
2021-06-29 9:40 ` [PATCH 1/3] include: dt-bindings: Add mscc-vsc8531 RGMII clock delay definitions Harini Katakam
2021-06-29 13:58 ` Andrew Lunn [this message]
2021-06-29 9:40 ` [PATCH 2/3] dt-bindings: mscc: Add RGMII RX and TX delay tuning Harini Katakam
2021-06-29 14:07 ` Andrew Lunn
2021-06-29 14:11 ` Harini Katakam
2021-07-14 21:08 ` Rob Herring
2021-08-17 10:16 ` Harini Katakam
2021-06-29 9:40 ` [PATCH 3/3] phy: mscc: Add support for VSC8531_02 with RGMII tuning Harini Katakam
2021-06-29 10:41 ` Heiner Kallweit
2021-06-29 14:19 ` Harini Katakam
2021-06-29 14:11 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNsm/0dmpBgO8mqr@lunn.ch \
--to=andrew@lunn.ch \
--cc=bjarni.jonasson@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=harini.katakam@xilinx.com \
--cc=harinikatakamlinux@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=likaige@loongson.cn \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michal.simek@xilinx.com \
--cc=radhey.shyam.pandey@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=steen.hegelund@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).