From: Andrew Lunn <andrew@lunn.ch>
To: Harini Katakam <harini.katakam@xilinx.com>
Cc: robh+dt@kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, kuba@kernel.org,
steen.hegelund@microchip.com, bjarni.jonasson@microchip.com,
ioana.ciornei@nxp.com, likaige@loongson.cn,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, harinikatakamlinux@gmail.com,
michal.simek@xilinx.com, radhey.shyam.pandey@xilinx.com
Subject: Re: [PATCH 2/3] dt-bindings: mscc: Add RGMII RX and TX delay tuning
Date: Tue, 29 Jun 2021 16:07:07 +0200 [thread overview]
Message-ID: <YNspC065DnVpzADe@lunn.ch> (raw)
In-Reply-To: <20210629094038.18610-3-harini.katakam@xilinx.com>
On Tue, Jun 29, 2021 at 03:10:37PM +0530, Harini Katakam wrote:
> Add optional properties to tune RGMII RX and TX delay.
>
> Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> .../devicetree/bindings/net/mscc-phy-vsc8531.txt | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> index 87a27d775d48..e201d24d8e27 100644
> --- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> @@ -33,7 +33,14 @@ Optional properties:
> VSC8531_DUPLEX_COLLISION (8).
> - load-save-gpios : GPIO used for the load/save operation of the PTP
> hardware clock (PHC).
> -
> +- vsc8531,rx-delay : RGMII RX delay. Allowed values are defined in
> + "include/dt-bindings/net/mscc-phy-vsc8531.h".
> + Default value, set by the driver is
> + VSC8531_RGMII_CLK_DELAY_2_0_NS.
> +- vsc8531,tx-delay : RGMII TX delay. Allowed values are defined in
> + "include/dt-bindings/net/mscc-phy-vsc8531.h".
> + Default value, set by the driver is
> + VSC8531_RGMII_CLK_DELAY_2_0_NS.
The default values need better explanation. So you are saying they are
only used when 'rgmii' is not used. And they replace the default 2ns
delay, they don't add to the default 2ns delay.
Andrew
next prev parent reply other threads:[~2021-06-29 14:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 9:40 [PATCH 0/3] Add support for VSC8531_02 PHY and DT RGMII tuning Harini Katakam
2021-06-29 9:40 ` [PATCH 1/3] include: dt-bindings: Add mscc-vsc8531 RGMII clock delay definitions Harini Katakam
2021-06-29 13:58 ` Andrew Lunn
2021-06-29 9:40 ` [PATCH 2/3] dt-bindings: mscc: Add RGMII RX and TX delay tuning Harini Katakam
2021-06-29 14:07 ` Andrew Lunn [this message]
2021-06-29 14:11 ` Harini Katakam
2021-07-14 21:08 ` Rob Herring
2021-08-17 10:16 ` Harini Katakam
2021-06-29 9:40 ` [PATCH 3/3] phy: mscc: Add support for VSC8531_02 with RGMII tuning Harini Katakam
2021-06-29 10:41 ` Heiner Kallweit
2021-06-29 14:19 ` Harini Katakam
2021-06-29 14:11 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNspC065DnVpzADe@lunn.ch \
--to=andrew@lunn.ch \
--cc=bjarni.jonasson@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=harini.katakam@xilinx.com \
--cc=harinikatakamlinux@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=likaige@loongson.cn \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michal.simek@xilinx.com \
--cc=radhey.shyam.pandey@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=steen.hegelund@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).