From: Matthias Kaehlcke <mka@chromium.org>
To: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
Cc: Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_pkondeti@quicinc.com,
quic_ppratap@quicinc.com
Subject: Re: [PATCH 1/2] arm64: qcom: sc7280: Remove USB2 controller and phy nodes from common dtsi
Date: Mon, 29 Nov 2021 10:02:20 -0800 [thread overview]
Message-ID: <YaUVrDw9j0Aks/pn@google.com> (raw)
In-Reply-To: <1637837815-8532-2-git-send-email-quic_c_sanm@quicinc.com>
On Thu, Nov 25, 2021 at 04:26:54PM +0530, Sandeep Maheswaram wrote:
> Remove USB2 controller and phy nodes from common dtsi file as it is
> required only for SKU1 board.
>
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
A series shouldn't break things if it is only applied partially (in order). In
this case the USB2 controller wouldn't work on the SKU1 board if only this patch
is applied. It should be squashed with patch 2 of this series ("arm64: qcom:
sc7280: Add USB2 controller and phy nodes for SKU1 board").
Also doing the move in a single patch instead of two separate patches for remove
and add makes it easier to review the latter part, since it's evident from the
patch itself that it's just a move.
next prev parent reply other threads:[~2021-11-29 22:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 10:56 [PATCH 0/2] Remove USB2 nodes from SC7280 IDP common dtsi file Sandeep Maheswaram
2021-11-25 10:56 ` [PATCH 1/2] arm64: qcom: sc7280: Remove USB2 controller and phy nodes from common dtsi Sandeep Maheswaram
2021-11-29 18:02 ` Matthias Kaehlcke [this message]
2021-12-01 4:59 ` Sandeep Maheswaram
2021-11-25 10:56 ` [PATCH 2/2] arm64: qcom: sc7280: Add USB2 controller and phy nodes for SKU1 board Sandeep Maheswaram
2021-12-01 3:28 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaUVrDw9j0Aks/pn@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_c_sanm@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).