From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, pure.logic@nexus-software.ie,
greg@kroah.com, linux-kernel@vger.kernel.org,
tsoni@codeaurora.org, psodagud@codeaurora.org,
satyap@codeaurora.org, pheragu@codeaurora.org,
rnayak@codeaurora.org, sibis@codeaurora.org,
saiprakash.ranjan@codeaurora.org
Subject: Re: [PATCH V3 5/7] arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector
Date: Thu, 6 Jan 2022 16:53:17 -0800 [thread overview]
Message-ID: <YdeO/T0kQtNQfmx+@ripper> (raw)
In-Reply-To: <baf41480be71bd4472fe09c2993e43a780554d94.1641288286.git.quic_schowdhu@quicinc.com>
On Tue 04 Jan 03:58 PST 2022, Souradeep Chowdhury wrote:
> Add the Embedded USB Debugger(EUD) device tree node. The
> node contains EUD base register region and EUD mode
> manager register regions along with the interrupt entry.
> Also add the connector to EUD which is mapped as the child
> of dwc3. The connector is attached to EUD via port. Also add
> the role-switch property to dwc3 node.
>
> Signed-off-by: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 53a21d0..2d14e5c 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -1315,6 +1315,18 @@
> phys = <&usb_2_hsphy>;
> phy-names = "usb2-phy";
> maximum-speed = "high-speed";
> + usb-role-switch;
> + usb_con: eud_usb_connector {
I think this is backwards.
Iiuc you have dwc3 <-> EUD <-> connector, where the connector typically
would be represented in relation to a Type-C controller.
So I think this graph should be looking something like:
dwc3 {
ports {
port {
dwc3_eud: endpoint {
remote-endpoint = <&eud_ep>;
};
};
};
};
eud {
ports {
port {
eud_dwc3: endpoint {
remote-endpoint = <&dwc3_eud>;
};
};
port {
eud_con: endpoint {
remote-endpoint = <&con_eud>;
};
};
};
};
connector {
compatible = "usb-c-connector";
ports {
port {
con_eud: endpoint {
remote-endpoint = <&eud_con>;
};
};
};
};
With EUD "forwarding" the role switching requests from the connector, or
overriding them if the EUD is enabled.
Alternatively the dwc3 would be in a graph with both the eud and the
connector, but I don't know how to ensure that the EUD decision takes
precedence over the type-c controllers role request...
In the case of us having a type-c controller, such as the pmic_glink,
the connector node would then be a child of the controller.
Regards,
Bjorn
> + compatible = "qcom,usb-connector-eud",
> + "usb-c-connector";
> + ports {
> + port@0 {
> + usb2_role_switch: endpoint {
> + remote-endpoint = <&eud_ep>;
> + };
> + };
> + };
> + };
> };
> };
>
> @@ -1339,6 +1351,19 @@
> interrupts = <GIC_SPI 582 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> + eud: eud@88e0000 {
> + compatible = "qcom,sc7280-eud","qcom,eud";
> + reg = <0 0x88e0000 0 0x2000>,
> + <0 0x88e2000 0 0x1000>;
> + interrupt-parent = <&pdc>;
> + interrupts = <11 IRQ_TYPE_LEVEL_HIGH>;
> + port {
> + eud_ep: endpoint {
> + remote-endpoint = <&usb2_role_switch>;
> + };
> + };
> + };
> +
> nsp_noc: interconnect@a0c0000 {
> reg = <0 0x0a0c0000 0 0x10000>;
> compatible = "qcom,sc7280-nsp-noc";
> --
> 2.7.4
>
next prev parent reply other threads:[~2022-01-07 0:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 11:58 [PATCH V3 0/7] Add Embedded USB Debugger (EUD) driver Souradeep Chowdhury
2022-01-04 11:58 ` [PATCH V3 1/7] dt-bindings: Add the yaml bindings for EUD Souradeep Chowdhury
2022-01-12 1:08 ` Rob Herring
2022-01-17 5:12 ` Souradeep Chowdhury
2022-01-04 11:58 ` [PATCH V3 2/7] dt-bindings: connector: Add property for EUD type-C connector Souradeep Chowdhury
2022-01-07 0:54 ` Bjorn Andersson
2022-01-17 5:08 ` Souradeep Chowdhury
2022-01-04 11:58 ` [PATCH V3 3/7] bindings: usb: dwc3: Update dwc3 properties for EUD connector Souradeep Chowdhury
2022-01-07 0:56 ` Bjorn Andersson
2022-01-17 5:09 ` Souradeep Chowdhury
2022-01-04 11:58 ` [PATCH V3 4/7] soc: qcom: eud: Add driver support for Embedded USB Debugger(EUD) Souradeep Chowdhury
2022-01-07 1:19 ` Bjorn Andersson
2022-01-17 4:58 ` Souradeep Chowdhury
2022-01-04 11:58 ` [PATCH V3 5/7] arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector Souradeep Chowdhury
2022-01-04 19:24 ` Dmitry Baryshkov
2022-01-07 0:53 ` Bjorn Andersson [this message]
2022-01-17 5:07 ` Souradeep Chowdhury
2022-01-04 11:58 ` [PATCH V3 6/7] arm64: dts: qcom: sc7280: Set the default dr_mode for usb2 Souradeep Chowdhury
2022-01-04 11:58 ` [PATCH V3 7/7] MAINTAINERS: Add maintainer entry for EUD Souradeep Chowdhury
2022-01-06 10:52 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdeO/T0kQtNQfmx+@ripper \
--to=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=greg@kroah.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pheragu@codeaurora.org \
--cc=psodagud@codeaurora.org \
--cc=pure.logic@nexus-software.ie \
--cc=quic_schowdhu@quicinc.com \
--cc=rnayak@codeaurora.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=satyap@codeaurora.org \
--cc=sibis@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).