From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, pure.logic@nexus-software.ie,
greg@kroah.com, linux-kernel@vger.kernel.org,
tsoni@codeaurora.org, psodagud@codeaurora.org,
satyap@codeaurora.org, pheragu@codeaurora.org,
rnayak@codeaurora.org, sibis@codeaurora.org,
saiprakash.ranjan@codeaurora.org
Subject: Re: [PATCH V3 3/7] bindings: usb: dwc3: Update dwc3 properties for EUD connector
Date: Thu, 6 Jan 2022 16:56:10 -0800 [thread overview]
Message-ID: <YdePqpJjIiPAuHlJ@ripper> (raw)
In-Reply-To: <163f4d977fb6a0d80d8fd8d358991aeeb58d31a6.1641288286.git.quic_schowdhu@quicinc.com>
On Tue 04 Jan 03:58 PST 2022, Souradeep Chowdhury wrote:
> Add the connector property for dwc3 node. This connector can
> be used to role-switch the controller from device to host and
> vice versa.
>
> Signed-off-by: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
> ---
> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> index 078fb78..9382168 100644
> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> @@ -318,6 +318,12 @@ properties:
> items:
> enum: [1, 4, 8, 16, 32, 64, 128, 256]
>
> + connector:
The dwc3 isn't the connector, so I think you should put a ports {} in
the dwc3 and link that to the connector that is described elsewhere.
Regards,
Bjorn
> + type: object
> + $ref: /connector/usb-connector.yaml#
> + description:
> + Connector for dual role switch, especially for "eud-usb-c-connector"
> +
> unevaluatedProperties: false
>
> required:
> --
> 2.7.4
>
next prev parent reply other threads:[~2022-01-07 0:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 11:58 [PATCH V3 0/7] Add Embedded USB Debugger (EUD) driver Souradeep Chowdhury
2022-01-04 11:58 ` [PATCH V3 1/7] dt-bindings: Add the yaml bindings for EUD Souradeep Chowdhury
2022-01-12 1:08 ` Rob Herring
2022-01-17 5:12 ` Souradeep Chowdhury
2022-01-04 11:58 ` [PATCH V3 2/7] dt-bindings: connector: Add property for EUD type-C connector Souradeep Chowdhury
2022-01-07 0:54 ` Bjorn Andersson
2022-01-17 5:08 ` Souradeep Chowdhury
2022-01-04 11:58 ` [PATCH V3 3/7] bindings: usb: dwc3: Update dwc3 properties for EUD connector Souradeep Chowdhury
2022-01-07 0:56 ` Bjorn Andersson [this message]
2022-01-17 5:09 ` Souradeep Chowdhury
2022-01-04 11:58 ` [PATCH V3 4/7] soc: qcom: eud: Add driver support for Embedded USB Debugger(EUD) Souradeep Chowdhury
2022-01-07 1:19 ` Bjorn Andersson
2022-01-17 4:58 ` Souradeep Chowdhury
2022-01-04 11:58 ` [PATCH V3 5/7] arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector Souradeep Chowdhury
2022-01-04 19:24 ` Dmitry Baryshkov
2022-01-07 0:53 ` Bjorn Andersson
2022-01-17 5:07 ` Souradeep Chowdhury
2022-01-04 11:58 ` [PATCH V3 6/7] arm64: dts: qcom: sc7280: Set the default dr_mode for usb2 Souradeep Chowdhury
2022-01-04 11:58 ` [PATCH V3 7/7] MAINTAINERS: Add maintainer entry for EUD Souradeep Chowdhury
2022-01-06 10:52 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdePqpJjIiPAuHlJ@ripper \
--to=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=greg@kroah.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pheragu@codeaurora.org \
--cc=psodagud@codeaurora.org \
--cc=pure.logic@nexus-software.ie \
--cc=quic_schowdhu@quicinc.com \
--cc=rnayak@codeaurora.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=satyap@codeaurora.org \
--cc=sibis@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).