From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Samuel Holland <samuel@sholland.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-i2c@vger.kernel.org,
Wolfram Sang <wsa@kernel.org>, Ondrej Jirman <x@xff.cz>
Subject: Re: [PATCH 3/5] Input: pinephone-keyboard - Build in the default keymap
Date: Mon, 31 Jan 2022 11:45:54 -0800 [thread overview]
Message-ID: <Yfg8crUuCLO0SxVj@google.com> (raw)
In-Reply-To: <20220129230043.12422-4-samuel@sholland.org>
Hi Samuel,
On Sat, Jan 29, 2022 at 05:00:40PM -0600, Samuel Holland wrote:
> The PinePhone keyboard comes with removable keys, but there is a default
> layout labeled from the factory. Use this keymap if none is provided in
> the devicetree.
Why can't we require to have it in device tree?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2022-01-31 19:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 23:00 [PATCH 0/5] Pine64 PinePhone keyboard support Samuel Holland
2022-01-29 23:00 ` [PATCH 1/5] dt-bindings: input: Add the PinePhone keyboard binding Samuel Holland
2022-02-11 13:23 ` Rob Herring
2022-02-14 4:41 ` Samuel Holland
2022-01-29 23:00 ` [PATCH 2/5] Input: pinephone-keyboard - Add PinePhone keyboard driver Samuel Holland
2022-02-02 8:07 ` Ondřej Jirman
2022-02-02 11:48 ` Ondřej Jirman
2022-01-29 23:00 ` [PATCH 3/5] Input: pinephone-keyboard - Build in the default keymap Samuel Holland
2022-01-31 19:45 ` Dmitry Torokhov [this message]
2022-02-02 4:58 ` Samuel Holland
2022-05-30 7:05 ` Pavel Machek
2022-04-12 10:20 ` Jarrah
2022-04-12 11:34 ` Ondřej Jirman
2022-01-29 23:00 ` [PATCH 4/5] Input: pinephone-keyboard - Support the proxied I2C bus Samuel Holland
2022-01-30 2:05 ` Ondřej Jirman
2022-01-30 2:43 ` Samuel Holland
2022-01-30 3:00 ` Ondřej Jirman
2022-01-29 23:00 ` [PATCH 5/5] [DO NOT MERGE] arm64: dts: allwinner: pinephone: Add keyboard Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yfg8crUuCLO0SxVj@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wsa@kernel.org \
--cc=x@xff.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).