From: Jarrah <kernel@undef.tools>
To: Samuel Holland <samuel@sholland.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-i2c@vger.kernel.org,
Wolfram Sang <wsa@kernel.org>, Ondrej Jirman <x@xff.cz>
Subject: Re: [PATCH 3/5] Input: pinephone-keyboard - Build in the default keymap
Date: Tue, 12 Apr 2022 20:20:24 +1000 [thread overview]
Message-ID: <bde4ae40-98b6-7a77-2059-33c34442b604@undef.tools> (raw)
In-Reply-To: <20220129230043.12422-4-samuel@sholland.org>
On 1/30/22 10:00, Samuel Holland wrote:
> +
> +static const uint32_t ppkb_default_fn_keymap[] = {
> + KEY(0, 0, KEY_FN_ESC),
> + KEY(0, 1, KEY_F1),
> + KEY(0, 2, KEY_F2),
> + KEY(0, 3, KEY_F3),
> + KEY(0, 4, KEY_F4),
> + KEY(0, 5, KEY_F5),
> + KEY(0, 6, KEY_F6),
> + KEY(0, 7, KEY_F7),
> + KEY(0, 8, KEY_F8),
> + KEY(0, 9, KEY_F9),
> + KEY(0, 10, KEY_F10),
> + KEY(0, 11, KEY_DELETE),
> +
> + KEY(2, 0, KEY_SYSRQ),
> + KEY(2, 10, KEY_INSERT),
> +
The driver currently being patched into most distros supporting the
keyboard exposes the symbols printed on the keyboard rather than the F*
keys on the function layer. While I agree than exposing function keys on
the Fn layer is more logical, in practice running this patch for a day
I've found it's far more useful to have quick access to the standard set
of symbols (such as | and -) than to have the function keys.
Would it be possible to either set the default back to symbols or expose
another layer (potentially under the "pine" key)? An alternative
solution proposed on the Mobian issue for this was to add a module
option, allowing these to be switched at runtime rather than compile time.
next prev parent reply other threads:[~2022-04-12 11:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 23:00 [PATCH 0/5] Pine64 PinePhone keyboard support Samuel Holland
2022-01-29 23:00 ` [PATCH 1/5] dt-bindings: input: Add the PinePhone keyboard binding Samuel Holland
2022-02-11 13:23 ` Rob Herring
2022-02-14 4:41 ` Samuel Holland
2022-01-29 23:00 ` [PATCH 2/5] Input: pinephone-keyboard - Add PinePhone keyboard driver Samuel Holland
2022-02-02 8:07 ` Ondřej Jirman
2022-02-02 11:48 ` Ondřej Jirman
2022-01-29 23:00 ` [PATCH 3/5] Input: pinephone-keyboard - Build in the default keymap Samuel Holland
2022-01-31 19:45 ` Dmitry Torokhov
2022-02-02 4:58 ` Samuel Holland
2022-05-30 7:05 ` Pavel Machek
2022-04-12 10:20 ` Jarrah [this message]
2022-04-12 11:34 ` Ondřej Jirman
2022-01-29 23:00 ` [PATCH 4/5] Input: pinephone-keyboard - Support the proxied I2C bus Samuel Holland
2022-01-30 2:05 ` Ondřej Jirman
2022-01-30 2:43 ` Samuel Holland
2022-01-30 3:00 ` Ondřej Jirman
2022-01-29 23:00 ` [PATCH 5/5] [DO NOT MERGE] arm64: dts: allwinner: pinephone: Add keyboard Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bde4ae40-98b6-7a77-2059-33c34442b604@undef.tools \
--to=kernel@undef.tools \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wsa@kernel.org \
--cc=x@xff.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).