From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Wei Xu <xuwei5@hisilicon.com>, Nishanth Menon <nm@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jan Kotas <jank@cadence.com>, Li Wei <liwei213@huawei.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Yaniv Gardi <ygardi@codeaurora.org>,
linux-scsi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 01/15] dt-bindings: ufs: add common platform bindings
Date: Fri, 25 Feb 2022 13:26:18 -0600 [thread overview]
Message-ID: <YhktWpoJekR2Lj0D@robh.at.kernel.org> (raw)
In-Reply-To: <20220222145854.358646-2-krzysztof.kozlowski@canonical.com>
On Tue, Feb 22, 2022 at 03:58:40PM +0100, Krzysztof Kozlowski wrote:
> Add bindings for common parts (platform) of Universal Flash Storage
> (UFS) Host Controllers in dtschema format.
>
> The 'freq-table-hz' is not correct in dtschema, because '-hz' suffix
> defines uint32 type, not an array. Therefore deprecate 'freq-table-hz'
> and use 'freq-table' instead.
-hz is an array type. We can extend it to matrix if needed.
I do think this property is a bit questionable. Do we really need a
minimum in DT and if not, wouldn't assigned-clocks-rate work? Or an OPP
table.
> Include also the bindings directory in UFS maintainers entry.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> .../devicetree/bindings/ufs/ti,j721e-ufs.yaml | 2 +-
> .../devicetree/bindings/ufs/ufs-common.yaml | 88 +++++++++++++++++++
> MAINTAINERS | 1 +
> 3 files changed, 90 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/ufs/ufs-common.yaml
>
> diff --git a/Documentation/devicetree/bindings/ufs/ti,j721e-ufs.yaml b/Documentation/devicetree/bindings/ufs/ti,j721e-ufs.yaml
> index 4d13e6bc1c50..dc93fe2d3458 100644
> --- a/Documentation/devicetree/bindings/ufs/ti,j721e-ufs.yaml
> +++ b/Documentation/devicetree/bindings/ufs/ti,j721e-ufs.yaml
> @@ -80,7 +80,7 @@ examples:
> compatible = "cdns,ufshc-m31-16nm", "jedec,ufs-2.0";
> reg = <0x0 0x4000 0x0 0x10000>;
> interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
> - freq-table-hz = <19200000 19200000>;
> + freq-table = <19200000 19200000>;
> power-domains = <&k3_pds 277>;
> clocks = <&k3_clks 277 1>;
> assigned-clocks = <&k3_clks 277 1>;
> diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> new file mode 100644
> index 000000000000..85c73d2853e9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> @@ -0,0 +1,88 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/ufs/ufs-common.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Common properties for Universal Flash Storage (UFS) Host Controllers
> +
> +maintainers:
> + - Alim Akhtar <alim.akhtar@samsung.com>
> + - Avri Altman <avri.altman@wdc.com>
> +
> +properties:
> + clocks: true
> +
> + clock-names: true
> +
> + freq-table-hz:
> + deprecated: true
> + description:
> + Use freq-table.
> +
> + freq-table:
> + $ref: /schemas/types.yaml#/definitions/uint32-matrix
> + items:
> + items:
> + - description: Minimum frequency for given clock
> + - description: Maximum frequency for given clock
> + description: |
> + Array of <min max> operating frequencies in Hz stored in the same order
> + as the clocks property. If this property is not defined or a value in the
> + array is "0" then it is assumed that the frequency is set by the parent
> + clock or a fixed rate clock source.
> +
> + interrupts:
> + maxItems: 1
> +
> + lanes-per-direction:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [1, 2]
> + default: 2
> + description:
> + Number of lanes available per direction. Note that it is assume same
> + number of lanes is used both directions at once.
> +
> + vdd-hba-supply:
> + description:
> + Phandle to UFS host controller supply regulator node.
> +
> + vcc-supply:
> + description:
> + Phandle to VCC supply regulator node.
> +
> + vccq-supply:
> + description:
> + Phandle to VCCQ supply regulator node.
> +
> + vccq2-supply:
> + description:
> + Phandle to VCCQ2 supply regulator node.
> +
> + vcc-supply-1p8:
> + type: boolean
> + description:
> + For embedded UFS devices, valid VCC range is 1.7-1.95V or 2.7-3.6V. This
> + boolean property when set, specifies to use low voltage range of
> + 1.7-1.95V. Note for external UFS cards this property is invalid and valid
> + VCC range is always 2.7-3.6V.
> +
> + vcc-max-microamp:
> + description:
> + Specifies max. load that can be drawn from VCC supply.
> +
> + vccq-max-microamp:
> + description:
> + Specifies max. load that can be drawn from VCCQ supply.
> +
> + vccq2-max-microamp:
> + description:
> + Specifies max. load that can be drawn from VCCQ2 supply.
> +
> +dependencies:
> + freq-table: [ 'clocks' ]
> +
> +required:
> + - interrupts
> +
> +additionalProperties: true
> diff --git a/MAINTAINERS b/MAINTAINERS
> index aa0f6cbb634e..c2cff57d32f8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20015,6 +20015,7 @@ R: Alim Akhtar <alim.akhtar@samsung.com>
> R: Avri Altman <avri.altman@wdc.com>
> L: linux-scsi@vger.kernel.org
> S: Supported
> +F: Documentation/devicetree/bindings/ufs/
> F: Documentation/scsi/ufs.rst
> F: drivers/scsi/ufs/
>
> --
> 2.32.0
>
>
next prev parent reply other threads:[~2022-02-25 19:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 14:58 [PATCH v2 00/15] dt-bindings: ufs: add common platform bindings + fixes Krzysztof Kozlowski
2022-02-22 14:58 ` [PATCH v2 01/15] dt-bindings: ufs: add common platform bindings Krzysztof Kozlowski
2022-02-25 19:26 ` Rob Herring [this message]
2022-02-27 10:24 ` Krzysztof Kozlowski
2022-02-22 14:58 ` [PATCH v2 02/15] dt-bindings: ufs: samsung,exynos-ufs: use common bindings Krzysztof Kozlowski
2022-02-25 19:26 ` Rob Herring
2022-02-22 14:58 ` [PATCH v2 03/15] dt-bindings: ufs: cdns,ufshc: convert to dtschema Krzysztof Kozlowski
2022-02-25 19:28 ` Rob Herring
2022-02-22 14:58 ` [PATCH v2 04/15] dt-bindings: ufs: drop unused/old ufs-qcom PHY bindings Krzysztof Kozlowski
2022-02-22 18:03 ` Bjorn Andersson
2022-02-25 19:32 ` Rob Herring
2022-02-22 14:58 ` [PATCH v2 05/15] dt-bindings: ufs: qcom,ufs: convert to dtschema Krzysztof Kozlowski
2022-02-22 15:01 ` Krzysztof Kozlowski
2022-02-25 19:33 ` Rob Herring
2022-02-22 14:58 ` [PATCH v2 06/15] dt-bindings: ufs: hisilicon,ufs: " Krzysztof Kozlowski
2022-02-25 19:34 ` Rob Herring
2022-02-22 14:58 ` [PATCH v2 07/15] dt-bindings: ufs: mediatek,ufs: " Krzysztof Kozlowski
2022-02-25 19:34 ` Rob Herring
2022-02-22 14:58 ` [PATCH v2 08/15] dt-bindings: ufs: snps,tc-dwc-g210: " Krzysztof Kozlowski
2022-02-25 19:35 ` Rob Herring
2022-02-22 14:58 ` [PATCH v2 09/15] scsi: ufs: deprecate 'freq-table-hz' property Krzysztof Kozlowski
2022-02-22 16:44 ` Alim Akhtar
2022-02-23 8:23 ` Krzysztof Kozlowski
2022-02-22 18:16 ` Bjorn Andersson
2022-02-23 9:15 ` Krzysztof Kozlowski
2022-02-24 16:51 ` Bjorn Andersson
2022-02-22 14:58 ` [PATCH v2 10/15] arm64: dts: hi3670: use 'freq-table' in UFS node Krzysztof Kozlowski
2022-02-22 14:58 ` [PATCH v2 11/15] arm64: dts: ti: " Krzysztof Kozlowski
2022-02-22 14:58 ` [PATCH v2 12/15] arm64: dts: qcom: " Krzysztof Kozlowski
2022-02-22 14:58 ` [PATCH v2 13/15] arm64: dts: qcom: msm8996: drop unsupported UFS vddp-ref-clk-max-microamp Krzysztof Kozlowski
2022-02-22 14:58 ` [PATCH v2 14/15] arm64: dts: qcom: msm8996: correct UFS compatible Krzysztof Kozlowski
2022-02-22 14:58 ` [PATCH v2 15/15] arm64: dts: qcom: sm8350: drop duplicated ref_clk in UFS Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhktWpoJekR2Lj0D@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jank@cadence.com \
--cc=jejb@linux.ibm.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=liwei213@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=nm@ti.com \
--cc=stanley.chu@mediatek.com \
--cc=vigneshr@ti.com \
--cc=xuwei5@hisilicon.com \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).