From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Eddie James" <eajames@linux.ibm.com>, linux-aspeed@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
mark.rutland@arm.com, "Jason Cooper" <jason@lakedaemon.net>,
"Marc Zyngier" <maz@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
tglx@linutronix.de, "Joel Stanley" <joel@jms.id.au>
Subject: Re: [PATCH v3 05/12] dt-bindings: soc: Add Aspeed XDMA Engine
Date: Fri, 20 Dec 2019 07:44:05 +1030 [thread overview]
Message-ID: <a0b5728c-4022-4cfb-bcd1-8816e4d80e4a@www.fastmail.com> (raw)
In-Reply-To: <45cabf88-063d-aea1-6c2b-fa8cc0d8cbd3@linux.ibm.com>
On Fri, 20 Dec 2019, at 02:18, Eddie James wrote:
>
> On 12/18/19 5:12 PM, Andrew Jeffery wrote:
> >
> > On Thu, 19 Dec 2019, at 01:39, Eddie James wrote:
> >> Document the bindings for the Aspeed AST25XX and AST26XX XDMA engine.
> >>
> >> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> >> Reviewed-by: Rob Herring <robh@kernel.org>
> >> ---
> >> Changes since v2:
> >> - Remove 'sdmc', rename 'vga-mem' to 'memory'
> >>
> >> .../devicetree/bindings/soc/aspeed/xdma.txt | 40 +++++++++++++++++++
> >> MAINTAINERS | 6 +++
> >> 2 files changed, 46 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/soc/aspeed/xdma.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/soc/aspeed/xdma.txt
> >> b/Documentation/devicetree/bindings/soc/aspeed/xdma.txt
> >> new file mode 100644
> >> index 000000000000..58253ea1587b
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/soc/aspeed/xdma.txt
> >> @@ -0,0 +1,40 @@
> >> +Aspeed AST25XX and AST26XX XDMA Engine
> >> +
> >> +The XDMA Engine embedded in the AST2500 and AST2600 SOCs can perform
> >> automatic
> >> +DMA operations over PCI between the SOC (acting as a BMC) and a host
> >> processor.
> >> +
> >> +Required properties:
> >> + - compatible : must be "aspeed,ast2500-xdma" or
> >> + "aspeed,ast2600-xdma"
> >> + - reg : contains the address and size of the memory region
> >> + associated with the XDMA engine registers
> >> + - clocks : clock specifier for the clock associated with the
> >> + XDMA engine
> >> + - resets : reset specifier for the syscon reset associated with
> >> + the XDMA engine
> >> + - interrupts-extended : two interrupt cells; the first specifies the
> >> global
> >> + interrupt for the XDMA engine and the second
> >> + specifies the PCI-E reset or PERST interrupt.
> >> + - scu : a phandle to the syscon node for the system control
> >> + unit of the SOC
> > I think this should be aspeed,scu.
>
>
> Sure.
>
>
> >
> >> + - memory : contains the address and size of the memory area to
> >> + be used by the XDMA engine for DMA operations
> > Hmm, I was thinking more like a phandle to a reserved memory region,
> > like we have in the aspeed-lpc-ctrl binding.
>
>
> I think I mentioned before, but that doesn't work with the VGA memory.
> Linux can't reserve it. I haven't quite understood what happens in the
> memory system but I've tried it and it didn't work.
>
Yeah, I think you have mentioned that before, sorry for the noise.
Andrew
next prev parent reply other threads:[~2019-12-19 21:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 15:09 [PATCH v3 00/12] aspeed: Add SCU interrupt controller and XDMA engine drivers Eddie James
2019-12-18 15:09 ` [PATCH v3 01/12] dt-bindings: interrupt-controller: Add Aspeed SCU interrupt controller Eddie James
2019-12-18 15:09 ` [PATCH v3 02/12] irqchip: " Eddie James
2019-12-18 15:09 ` [PATCH v3 03/12] ARM: dts: aspeed: ast2500: Add " Eddie James
2019-12-18 22:34 ` Andrew Jeffery
2019-12-18 15:09 ` [PATCH v3 04/12] ARM: dts: aspeed: ast2600: Add SCU interrupt controllers Eddie James
2019-12-18 15:09 ` [PATCH v3 05/12] dt-bindings: soc: Add Aspeed XDMA Engine Eddie James
2019-12-18 23:12 ` Andrew Jeffery
2019-12-19 15:48 ` Eddie James
2019-12-19 21:14 ` Andrew Jeffery [this message]
2019-12-18 15:09 ` [PATCH v3 06/12] soc: aspeed: Add XDMA Engine Driver Eddie James
2019-12-18 23:12 ` Andrew Jeffery
2019-12-18 15:09 ` [PATCH v3 07/12] soc: aspeed: xdma: Add user interface Eddie James
2019-12-19 1:19 ` Andrew Jeffery
2019-12-19 16:00 ` Eddie James
2019-12-19 21:16 ` Andrew Jeffery
2019-12-18 15:09 ` [PATCH v3 08/12] soc: aspeed: xdma: Add reset ioctl Eddie James
2019-12-18 15:09 ` [PATCH v3 09/12] ARM: dts: aspeed: ast2500: Add XDMA Engine Eddie James
2019-12-18 15:09 ` [PATCH v3 10/12] ARM: dts: aspeed: ast2600: " Eddie James
2019-12-18 15:09 ` [PATCH v3 11/12] ARM: dts: aspeed: witherspoon: Enable " Eddie James
2019-12-18 15:09 ` [PATCH v3 12/12] ARM: dts: aspeed: tacoma: Enable XDMA engine Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0b5728c-4022-4cfb-bcd1-8816e4d80e4a@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=jason@lakedaemon.net \
--cc=joel@jms.id.au \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).