devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	robdclark@gmail.com, quic_abhinavk@quicinc.com,
	dmitry.baryshkov@linaro.org, sean@poorly.run, airlied@linux.ie,
	daniel@ffwll.ch, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org
Cc: quic_mkrishn@quicinc.com, swboyd@chromium.org,
	bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org,
	dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 5/7] dt-bindings: msm: dsi: Fix clock declarations
Date: Thu, 30 Jun 2022 21:04:05 +0200	[thread overview]
Message-ID: <a19ea366-6607-e54b-4ee2-8d8fa7fb9752@linaro.org> (raw)
In-Reply-To: <20220630120845.3356144-6-bryan.odonoghue@linaro.org>

On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> When converting from .txt to .yaml dt-binding descriptions we appear to
> have missed some of the previous detail on the number and names of
> permissible clocks.
> 
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  .../display/msm/dsi-controller-main.yaml      | 23 +++++++++++++------
>  1 file changed, 16 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> index fd9d472437853..b24ba6c346a77 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> @@ -28,22 +28,31 @@ properties:
>      maxItems: 1
>  
>    clocks:
> -    items:
> -      - description: Display byte clock
> -      - description: Display byte interface clock
> -      - description: Display pixel clock
> -      - description: Display escape clock
> -      - description: Display AHB clock
> -      - description: Display AXI clock
> +    minItems: 6
> +    maxItems: 9
>  
>    clock-names:
>      items:
>        - const: byte
> +        description: Display byte clock

Descriptions should stay where they were. Just add minItems and new items.

>        - const: byte_intf
> +        description: Display byte interface clock
>        - const: pixel
> +        description: Display pixel clock
>        - const: core
> +        description: Display escape clock
>        - const: iface
> +        description: Display AHB clock
>        - const: bus
> +        description: Display AXI clock
> +      - const: core_mmss
> +        description: Core MultiMedia SubSystem clock
> +      - const: mdp_core
> +        description: MDP Core clock
> +      - const: mnoc
> +        description: MNOC clock
> +    minItems: 6
> +    maxItems: 9

maxItems are not needed.

>  
>    phys:
>      maxItems: 1


Best regards,
Krzysztof

  parent reply	other threads:[~2022-06-30 19:04 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-30 12:08 [PATCH 0/7] msm8916/msm8939 DSI controller and DSI PHY bindings fixes Bryan O'Donoghue
2022-06-30 12:08 ` [PATCH 1/7] dt-bindings: msm: dsi: Fix phy-name binding Bryan O'Donoghue
2022-06-30 17:06   ` Dmitry Baryshkov
2022-06-30 18:59   ` Krzysztof Kozlowski
2022-07-01 19:57     ` Rob Herring
2022-07-01 20:08   ` Rob Herring
2022-06-30 12:08 ` [PATCH 2/7] dt-bindings: msm: dsi: Fix operating-points-v2 constraint Bryan O'Donoghue
2022-06-30 17:07   ` Dmitry Baryshkov
2022-06-30 19:00   ` Krzysztof Kozlowski
2022-06-30 12:08 ` [PATCH 3/7] dt-bindings: msm: dsi: Fix power-domains constraint Bryan O'Donoghue
2022-06-30 17:15   ` Dmitry Baryshkov
2022-06-30 19:01   ` Krzysztof Kozlowski
2022-06-30 19:49     ` Bryan O'Donoghue
2022-06-30 20:18       ` [Freedreno] " Stephan Gerhold
2022-06-30 12:08 ` [PATCH 4/7] dt-bindings: msm: dsi: Add vdd* descriptions back in Bryan O'Donoghue
2022-06-30 17:16   ` Dmitry Baryshkov
2022-06-30 17:30     ` Bryan O'Donoghue
2022-06-30 19:03       ` Krzysztof Kozlowski
2022-06-30 19:02   ` Krzysztof Kozlowski
2022-06-30 12:08 ` [PATCH 5/7] dt-bindings: msm: dsi: Fix clock declarations Bryan O'Donoghue
2022-06-30 17:21   ` Dmitry Baryshkov
2022-06-30 19:04   ` Krzysztof Kozlowski [this message]
2022-06-30 12:08 ` [PATCH 6/7] dt-bindings: msm: dsi: Add missing clocks to 28nm DSI PHY YAML Bryan O'Donoghue
2022-06-30 17:20   ` Dmitry Baryshkov
2022-06-30 19:05   ` Krzysztof Kozlowski
2022-07-06 12:57   ` Dmitry Baryshkov
2022-06-30 12:08 ` [PATCH 7/7] dt-bindings: msm: dsi: Add missing qcom,dsi-phy-regulator-ldo-mode Bryan O'Donoghue
2022-06-30 17:18   ` Dmitry Baryshkov
2022-06-30 19:07   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a19ea366-6607-e54b-4ee2-8d8fa7fb9752@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=airlied@linux.ie \
    --cc=bjorn.andersson@linaro.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_mkrishn@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sean@poorly.run \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).