Re: [PATCH 6/7] dt-bindings: msm: dsi: Add missing clocks to 28nm DSI PHY YAML

[Dmitry Baryshkov <dmitry.baryshkov@linaro.org>]

On 30/06/2022 15:08, Bryan O'Donoghue wrote:
> Add in missing clock and clock-names declarations to the 28nm DSI PHY.
> When converting from .txt to .yaml we missed these.
> 
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

I checked the schema. I think you can drop this patch. The issue that 
you probably saw with apq8064 should be solved in the dtsi, not in the 
schema.

> ---
>   .../bindings/display/msm/dsi-phy-28nm.yaml      | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> index 3d8540a06fe22..9ecd513d93661 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> @@ -19,6 +19,21 @@ properties:
>         - qcom,dsi-phy-28nm-lp
>         - qcom,dsi-phy-28nm-8960
>   
> +  clocks:
> +    minItems: 1
> +    maxItems: 2
> +
> +  clock-names:
> +    items:
> +      - const: iface
> +        description: AHB clock
> +      - const: iface_clk
> +        description: AHB clock
> +      - const: ref
> +        description: Block reference clock
> +    minItems: 1
> +    maxItems: 2
> +
>     reg:
>       items:
>         - description: dsi pll register set
> @@ -36,6 +51,8 @@ properties:
>   
>   required:
>     - compatible
> +  - clocks
> +  - clock-names
>     - reg
>     - reg-names
>     - vddio-supply


-- 
With best wishes
Dmitry