* [PATCH V2 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 bindings
@ 2021-04-21 22:31 Marek Vasut
2021-04-21 22:56 ` Laurent Pinchart
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Marek Vasut @ 2021-04-21 22:31 UTC (permalink / raw)
To: dri-devel
Cc: ch, Marek Vasut, Douglas Anderson, Jagan Teki, Laurent Pinchart,
Linus Walleij, Rob Herring, Sam Ravnborg, Stephen Boyd,
devicetree
Add DT binding document for TI SN65DSI83 and SN65DSI84 DSI to LVDS bridge.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Jagan Teki <jagan@amarulasolutions.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Stephen Boyd <swboyd@chromium.org>
Cc: devicetree@vger.kernel.org
To: dri-devel@lists.freedesktop.org
---
V2: Add compatible string for SN65DSI84, since this is now tested on it
---
.../bindings/display/bridge/ti,sn65dsi83.yaml | 134 ++++++++++++++++++
1 file changed, 134 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
new file mode 100644
index 000000000000..42d11b46a1eb
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
@@ -0,0 +1,134 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/bridge/ti,sn65dsi83.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: SN65DSI83 and SN65DSI84 DSI to LVDS bridge chip
+
+maintainers:
+ - Marek Vasut <marex@denx.de>
+
+description: |
+ Texas Instruments SN65DSI83 1x Single-link MIPI DSI
+ to 1x Single-link LVDS
+ https://www.ti.com/lit/gpn/sn65dsi83
+ Texas Instruments SN65DSI84 1x Single-link MIPI DSI
+ to 1x Dual-link or 2x Single-link LVDS
+ https://www.ti.com/lit/gpn/sn65dsi84
+
+properties:
+ compatible:
+ oneOf:
+ - const: ti,sn65dsi83
+ - const: ti,sn65dsi84
+
+ reg:
+ const: 0x2d
+
+ enable-gpios:
+ maxItems: 1
+ description: GPIO specifier for bridge_en pin (active high).
+
+ ports:
+ type: object
+ additionalProperties: false
+
+ properties:
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+ port@0:
+ type: object
+ additionalProperties: false
+
+ description:
+ Video port for MIPI DSI input
+
+ properties:
+ reg:
+ const: 0
+
+ endpoint:
+ type: object
+ additionalProperties: false
+ properties:
+ remote-endpoint: true
+ data-lanes:
+ description: array of physical DSI data lane indexes.
+
+ required:
+ - reg
+
+ port@1:
+ type: object
+ additionalProperties: false
+
+ description:
+ Video port for LVDS output (panel or bridge).
+
+ properties:
+ reg:
+ const: 1
+
+ endpoint:
+ type: object
+ additionalProperties: false
+ properties:
+ remote-endpoint: true
+
+ required:
+ - reg
+
+ required:
+ - "#address-cells"
+ - "#size-cells"
+ - port@0
+ - port@1
+
+required:
+ - compatible
+ - reg
+ - enable-gpios
+ - ports
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ bridge@2d {
+ compatible = "ti,sn65dsi83";
+ reg = <0x2d>;
+
+ enable-gpios = <&gpio2 1 GPIO_ACTIVE_HIGH>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ endpoint {
+ remote-endpoint = <&dsi0_out>;
+ data-lanes = <1 2 3 4>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ endpoint {
+ remote-endpoint = <&panel_in_lvds>;
+ };
+ };
+ };
+ };
+ };
--
2.30.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 bindings
2021-04-21 22:31 [PATCH V2 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 bindings Marek Vasut
@ 2021-04-21 22:56 ` Laurent Pinchart
2021-04-22 8:38 ` Neil Armstrong
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2021-04-21 22:56 UTC (permalink / raw)
To: Marek Vasut
Cc: dri-devel, ch, Douglas Anderson, Jagan Teki, Linus Walleij,
Rob Herring, Sam Ravnborg, Stephen Boyd, devicetree
Hi Marek,
Thank you for the patch.
On Thu, Apr 22, 2021 at 12:31:21AM +0200, Marek Vasut wrote:
> Add DT binding document for TI SN65DSI83 and SN65DSI84 DSI to LVDS bridge.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Jagan Teki <jagan@amarulasolutions.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Stephen Boyd <swboyd@chromium.org>
> Cc: devicetree@vger.kernel.org
> To: dri-devel@lists.freedesktop.org
> ---
> V2: Add compatible string for SN65DSI84, since this is now tested on it
> ---
> .../bindings/display/bridge/ti,sn65dsi83.yaml | 134 ++++++++++++++++++
> 1 file changed, 134 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> new file mode 100644
> index 000000000000..42d11b46a1eb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> @@ -0,0 +1,134 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/ti,sn65dsi83.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: SN65DSI83 and SN65DSI84 DSI to LVDS bridge chip
> +
> +maintainers:
> + - Marek Vasut <marex@denx.de>
> +
> +description: |
> + Texas Instruments SN65DSI83 1x Single-link MIPI DSI
> + to 1x Single-link LVDS
> + https://www.ti.com/lit/gpn/sn65dsi83
> + Texas Instruments SN65DSI84 1x Single-link MIPI DSI
> + to 1x Dual-link or 2x Single-link LVDS
> + https://www.ti.com/lit/gpn/sn65dsi84
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: ti,sn65dsi83
> + - const: ti,sn65dsi84
> +
> + reg:
> + const: 0x2d
> +
> + enable-gpios:
> + maxItems: 1
> + description: GPIO specifier for bridge_en pin (active high).
> +
> + ports:
> + type: object
Could you use the OF graph schema, now that it is available ? There
should be plenty of examples in bindings, both in display and in media.
You will be able to drop quite a bit of boilerplate.
> + additionalProperties: false
> +
> + properties:
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> + port@0:
> + type: object
> + additionalProperties: false
> +
> + description:
> + Video port for MIPI DSI input
> +
> + properties:
> + reg:
> + const: 0
> +
> + endpoint:
> + type: object
> + additionalProperties: false
> + properties:
> + remote-endpoint: true
> + data-lanes:
> + description: array of physical DSI data lane indexes.
> +
> + required:
> + - reg
> +
> + port@1:
> + type: object
> + additionalProperties: false
> +
> + description:
> + Video port for LVDS output (panel or bridge).
> +
> + properties:
> + reg:
> + const: 1
> +
> + endpoint:
> + type: object
> + additionalProperties: false
> + properties:
> + remote-endpoint: true
> +
> + required:
> + - reg
> +
> + required:
> + - "#address-cells"
> + - "#size-cells"
> + - port@0
> + - port@1
> +
> +required:
> + - compatible
> + - reg
> + - enable-gpios
> + - ports
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
While not a hard rule, it's customary to indent DT examples with 4
spaces. I find it to increase readability, but if you feel otherwise,
that's OK.
> +
> + bridge@2d {
> + compatible = "ti,sn65dsi83";
> + reg = <0x2d>;
> +
> + enable-gpios = <&gpio2 1 GPIO_ACTIVE_HIGH>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + endpoint {
> + remote-endpoint = <&dsi0_out>;
> + data-lanes = <1 2 3 4>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> + endpoint {
> + remote-endpoint = <&panel_in_lvds>;
> + };
> + };
> + };
> + };
> + };
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 bindings
2021-04-21 22:31 [PATCH V2 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 bindings Marek Vasut
2021-04-21 22:56 ` Laurent Pinchart
@ 2021-04-22 8:38 ` Neil Armstrong
2021-04-22 16:16 ` Marek Vasut
2021-04-22 8:43 ` Jagan Teki
2021-04-28 7:56 ` Frieder Schrempf
3 siblings, 1 reply; 8+ messages in thread
From: Neil Armstrong @ 2021-04-22 8:38 UTC (permalink / raw)
To: Marek Vasut, dri-devel
Cc: devicetree, ch, Douglas Anderson, Stephen Boyd, Rob Herring,
Jagan Teki, Sam Ravnborg, Laurent Pinchart
On 22/04/2021 00:31, Marek Vasut wrote:
> Add DT binding document for TI SN65DSI83 and SN65DSI84 DSI to LVDS bridge.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Jagan Teki <jagan@amarulasolutions.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Stephen Boyd <swboyd@chromium.org>
> Cc: devicetree@vger.kernel.org
> To: dri-devel@lists.freedesktop.org
> ---
> V2: Add compatible string for SN65DSI84, since this is now tested on it
> ---
> .../bindings/display/bridge/ti,sn65dsi83.yaml | 134 ++++++++++++++++++
> 1 file changed, 134 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> new file mode 100644
> index 000000000000..42d11b46a1eb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> @@ -0,0 +1,134 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/ti,sn65dsi83.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: SN65DSI83 and SN65DSI84 DSI to LVDS bridge chip
> +
> +maintainers:
> + - Marek Vasut <marex@denx.de>
> +
> +description: |
> + Texas Instruments SN65DSI83 1x Single-link MIPI DSI
> + to 1x Single-link LVDS
> + https://www.ti.com/lit/gpn/sn65dsi83
> + Texas Instruments SN65DSI84 1x Single-link MIPI DSI
> + to 1x Dual-link or 2x Single-link LVDS
> + https://www.ti.com/lit/gpn/sn65dsi84
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: ti,sn65dsi83
> + - const: ti,sn65dsi84
> +
> + reg:
> + const: 0x2d
> +
> + enable-gpios:
> + maxItems: 1
> + description: GPIO specifier for bridge_en pin (active high).
> +
> + ports:
> + type: object
> + additionalProperties: false
> +
> + properties:
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> + port@0:
> + type: object
> + additionalProperties: false
> +
> + description:
> + Video port for MIPI DSI input
> +
> + properties:
> + reg:
> + const: 0
> +
> + endpoint:
> + type: object
> + additionalProperties: false
> + properties:
> + remote-endpoint: true
> + data-lanes:
> + description: array of physical DSI data lane indexes.
> +
> + required:
> + - reg
> +
> + port@1:
> + type: object
> + additionalProperties: false
> +
> + description:
> + Video port for LVDS output (panel or bridge).
> +
> + properties:
> + reg:
> + const: 1
> +
> + endpoint:
> + type: object
> + additionalProperties: false
> + properties:
> + remote-endpoint: true
Similar to Jagan's serie, would be great to add bindings for the dual-link LVDS even if not supported
by the driver (the driver can fails with a verbose error).
Neil
> +
> + required:
> + - reg
> +
> + required:
> + - "#address-cells"
> + - "#size-cells"
> + - port@0
> + - port@1
> +
> +required:
> + - compatible
> + - reg
> + - enable-gpios
> + - ports
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + bridge@2d {
> + compatible = "ti,sn65dsi83";
> + reg = <0x2d>;
> +
> + enable-gpios = <&gpio2 1 GPIO_ACTIVE_HIGH>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + endpoint {
> + remote-endpoint = <&dsi0_out>;
> + data-lanes = <1 2 3 4>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> + endpoint {
> + remote-endpoint = <&panel_in_lvds>;
> + };
> + };
> + };
> + };
> + };
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 bindings
2021-04-21 22:31 [PATCH V2 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 bindings Marek Vasut
2021-04-21 22:56 ` Laurent Pinchart
2021-04-22 8:38 ` Neil Armstrong
@ 2021-04-22 8:43 ` Jagan Teki
2021-04-22 16:22 ` Marek Vasut
2021-04-28 7:56 ` Frieder Schrempf
3 siblings, 1 reply; 8+ messages in thread
From: Jagan Teki @ 2021-04-22 8:43 UTC (permalink / raw)
To: Marek Vasut
Cc: dri-devel, Claudius Heine, Douglas Anderson, Laurent Pinchart,
Linus Walleij, Rob Herring, Sam Ravnborg, Stephen Boyd,
devicetree
On Thu, Apr 22, 2021 at 4:01 AM Marek Vasut <marex@denx.de> wrote:
>
> Add DT binding document for TI SN65DSI83 and SN65DSI84 DSI to LVDS bridge.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Jagan Teki <jagan@amarulasolutions.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Stephen Boyd <swboyd@chromium.org>
> Cc: devicetree@vger.kernel.org
> To: dri-devel@lists.freedesktop.org
> ---
> V2: Add compatible string for SN65DSI84, since this is now tested on it
> ---
> .../bindings/display/bridge/ti,sn65dsi83.yaml | 134 ++++++++++++++++++
> 1 file changed, 134 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> new file mode 100644
> index 000000000000..42d11b46a1eb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> @@ -0,0 +1,134 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/ti,sn65dsi83.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: SN65DSI83 and SN65DSI84 DSI to LVDS bridge chip
Can it possible to wait for my v4 to have dual-link LVDS supported
which is quite discussing points on previous versions?
Jagan.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 bindings
2021-04-22 8:38 ` Neil Armstrong
@ 2021-04-22 16:16 ` Marek Vasut
0 siblings, 0 replies; 8+ messages in thread
From: Marek Vasut @ 2021-04-22 16:16 UTC (permalink / raw)
To: Neil Armstrong, dri-devel
Cc: devicetree, ch, Douglas Anderson, Stephen Boyd, Rob Herring,
Jagan Teki, Sam Ravnborg, Laurent Pinchart
On 4/22/21 10:38 AM, Neil Armstrong wrote:
[...]
>> + port@1:
>> + type: object
>> + additionalProperties: false
>> +
>> + description:
>> + Video port for LVDS output (panel or bridge).
>> +
>> + properties:
>> + reg:
>> + const: 1
>> +
>> + endpoint:
>> + type: object
>> + additionalProperties: false
>> + properties:
>> + remote-endpoint: true
>
> Similar to Jagan's serie, would be great to add bindings for the dual-link LVDS even if not supported
> by the driver (the driver can fails with a verbose error).
I don't want to add any sort of bindings which I cannot validate against
real hardware. I would argue that adding the 2x single / dual link LVDS
DT property could be added when someone has a need for it and can test
it on real hardware, and such a binding should be simple develop and
add. And that is better, because we won't end up with some possibly
misdesigned untested DT binding which would become part of the ABI and
would have to be supported forever.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 bindings
2021-04-22 8:43 ` Jagan Teki
@ 2021-04-22 16:22 ` Marek Vasut
0 siblings, 0 replies; 8+ messages in thread
From: Marek Vasut @ 2021-04-22 16:22 UTC (permalink / raw)
To: Jagan Teki
Cc: dri-devel, Claudius Heine, Douglas Anderson, Laurent Pinchart,
Linus Walleij, Rob Herring, Sam Ravnborg, Stephen Boyd,
devicetree
On 4/22/21 10:43 AM, Jagan Teki wrote:
[...]
>> diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
>> new file mode 100644
>> index 000000000000..42d11b46a1eb
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
>> @@ -0,0 +1,134 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/bridge/ti,sn65dsi83.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: SN65DSI83 and SN65DSI84 DSI to LVDS bridge chip
>
> Can it possible to wait for my v4 to have dual-link LVDS supported
> which is quite discussing points on previous versions?
This driver already has the dual-link LVDS support on DSI84 and it is
tested on real hardware. So is the single-link LVDS on DSI83, on
multiple hardware instances.
In addition to that, this driver has proper regmap support and constant
time calculation of DSI83/84 clock register settings.
Note that I did wait for your v4 for over two weeks already, it just
didn't materialize, so I determined it might be a good idea to restart
work on this driver instead.
Maybe you can test this driver and check what is missing for your usecase?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 bindings
2021-04-21 22:31 [PATCH V2 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 bindings Marek Vasut
` (2 preceding siblings ...)
2021-04-22 8:43 ` Jagan Teki
@ 2021-04-28 7:56 ` Frieder Schrempf
2021-04-28 14:19 ` Marek Vasut
3 siblings, 1 reply; 8+ messages in thread
From: Frieder Schrempf @ 2021-04-28 7:56 UTC (permalink / raw)
To: Marek Vasut, dri-devel
Cc: devicetree, ch, Douglas Anderson, Stephen Boyd, Rob Herring,
Jagan Teki, Sam Ravnborg, Laurent Pinchart
On 22.04.21 00:31, Marek Vasut wrote:
> Add DT binding document for TI SN65DSI83 and SN65DSI84 DSI to LVDS bridge.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Jagan Teki <jagan@amarulasolutions.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Stephen Boyd <swboyd@chromium.org>
> Cc: devicetree@vger.kernel.org
> To: dri-devel@lists.freedesktop.org
> ---
> V2: Add compatible string for SN65DSI84, since this is now tested on it
> ---
> .../bindings/display/bridge/ti,sn65dsi83.yaml | 134 ++++++++++++++++++
> 1 file changed, 134 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> new file mode 100644
> index 000000000000..42d11b46a1eb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> @@ -0,0 +1,134 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/ti,sn65dsi83.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: SN65DSI83 and SN65DSI84 DSI to LVDS bridge chip
> +
> +maintainers:
> + - Marek Vasut <marex@denx.de>
> +
> +description: |
> + Texas Instruments SN65DSI83 1x Single-link MIPI DSI
> + to 1x Single-link LVDS
> + https://www.ti.com/lit/gpn/sn65dsi83
> + Texas Instruments SN65DSI84 1x Single-link MIPI DSI
> + to 1x Dual-link or 2x Single-link LVDS
> + https://www.ti.com/lit/gpn/sn65dsi84
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: ti,sn65dsi83
> + - const: ti,sn65dsi84
> +
> + reg:
> + const: 0x2d
There is a strapping pin to select the last bit of the address, so apart
from 0x2d also 0x2c is valid here.
> +
> + enable-gpios:
> + maxItems: 1
> + description: GPIO specifier for bridge_en pin (active high).
> +
> + ports:
> + type: object
> + additionalProperties: false
> +
> + properties:
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> + port@0:
> + type: object
> + additionalProperties: false
> +
> + description:
> + Video port for MIPI DSI input
> +
> + properties:
> + reg:
> + const: 0
> +
> + endpoint:
> + type: object
> + additionalProperties: false
> + properties:
> + remote-endpoint: true
> + data-lanes:
> + description: array of physical DSI data lane indexes.
> +
> + required:
> + - reg
> +
> + port@1:
> + type: object
> + additionalProperties: false
> +
> + description:
> + Video port for LVDS output (panel or bridge).
> +
> + properties:
> + reg:
> + const: 1
> +
> + endpoint:
> + type: object
> + additionalProperties: false
> + properties:
> + remote-endpoint: true
> +
> + required:
> + - reg
> +
> + required:
> + - "#address-cells"
> + - "#size-cells"
> + - port@0
> + - port@1
> +
> +required:
> + - compatible
> + - reg
> + - enable-gpios
> + - ports
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + bridge@2d {
> + compatible = "ti,sn65dsi83";
> + reg = <0x2d>;
> +
> + enable-gpios = <&gpio2 1 GPIO_ACTIVE_HIGH>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + endpoint {
> + remote-endpoint = <&dsi0_out>;
> + data-lanes = <1 2 3 4>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> + endpoint {
> + remote-endpoint = <&panel_in_lvds>;
> + };
> + };
> + };
> + };
> + };
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 bindings
2021-04-28 7:56 ` Frieder Schrempf
@ 2021-04-28 14:19 ` Marek Vasut
0 siblings, 0 replies; 8+ messages in thread
From: Marek Vasut @ 2021-04-28 14:19 UTC (permalink / raw)
To: Frieder Schrempf, dri-devel
Cc: devicetree, ch, Douglas Anderson, Stephen Boyd, Rob Herring,
Jagan Teki, Sam Ravnborg, Laurent Pinchart
On 4/28/21 9:56 AM, Frieder Schrempf wrote:
[...]
>> +properties:
>> + compatible:
>> + oneOf:
>> + - const: ti,sn65dsi83
>> + - const: ti,sn65dsi84
>> +
>> + reg:
>> + const: 0x2d
>
> There is a strapping pin to select the last bit of the address, so apart
> from 0x2d also 0x2c is valid here.
Fixed, along with the other DT details pointed out by Laurent, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-04-28 14:19 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21 22:31 [PATCH V2 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 bindings Marek Vasut
2021-04-21 22:56 ` Laurent Pinchart
2021-04-22 8:38 ` Neil Armstrong
2021-04-22 16:16 ` Marek Vasut
2021-04-22 8:43 ` Jagan Teki
2021-04-22 16:22 ` Marek Vasut
2021-04-28 7:56 ` Frieder Schrempf
2021-04-28 14:19 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).