* [PATCH 1/2] dt-bindings: net: ipq4019-mdio: Add ipq6018 compatible
@ 2022-02-21 14:33 Baruch Siach
2022-02-21 14:33 ` [PATCH 2/2] arm64: dts: qcom: ipq6018: Add mdio bus description Baruch Siach
0 siblings, 1 reply; 5+ messages in thread
From: Baruch Siach @ 2022-02-21 14:33 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Robert Marko
Cc: Baruch Siach, Bryan O'Donoghue, netdev, devicetree, linux-arm-msm
From: Baruch Siach <baruch.siach@siklu.com>
The IPQ60xx MDIO bus is the same as IPQ4019.
Signed-off-by: Baruch Siach <baruch.siach@siklu.com>
---
Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
index 2af304341772..214e5270d89c 100644
--- a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
@@ -17,6 +17,7 @@ properties:
enum:
- qcom,ipq4019-mdio
- qcom,ipq5018-mdio
+ - qcom,ipq6018-mdio
"#address-cells":
const: 1
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: ipq6018: Add mdio bus description
2022-02-21 14:33 [PATCH 1/2] dt-bindings: net: ipq4019-mdio: Add ipq6018 compatible Baruch Siach
@ 2022-02-21 14:33 ` Baruch Siach
2022-02-22 2:35 ` Bryan O'Donoghue
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Baruch Siach @ 2022-02-21 14:33 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Robert Marko
Cc: Baruch Siach, Bryan O'Donoghue, netdev, devicetree, linux-arm-msm
From: Baruch Siach <baruch.siach@siklu.com>
The IPQ60xx has the same MDIO bug block as IPQ4019. Add IO range and
clock resources description.
Signed-off-by: Baruch Siach <baruch.siach@siklu.com>
---
arch/arm64/boot/dts/qcom/ipq6018.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
index 5eb7dc9cc231..093011d18ca6 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
@@ -635,6 +635,16 @@ qrtr_requests {
};
};
+ mdio: mdio@90000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "qcom,ipq6018-mdio", "qcom,ipq4019-mdio";
+ reg = <0x0 0x90000 0x0 0x64>;
+ clocks = <&gcc GCC_MDIO_AHB_CLK>;
+ clock-names = "gcc_mdio_ahb_clk";
+ status = "disabled";
+ };
+
qusb_phy_1: qusb@59000 {
compatible = "qcom,ipq6018-qusb2-phy";
reg = <0x0 0x059000 0x0 0x180>;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: ipq6018: Add mdio bus description
2022-02-21 14:33 ` [PATCH 2/2] arm64: dts: qcom: ipq6018: Add mdio bus description Baruch Siach
@ 2022-02-22 2:35 ` Bryan O'Donoghue
2022-02-22 2:41 ` Bryan O'Donoghue
2022-02-25 19:11 ` Rob Herring
2 siblings, 0 replies; 5+ messages in thread
From: Bryan O'Donoghue @ 2022-02-22 2:35 UTC (permalink / raw)
To: Baruch Siach, Andy Gross, Bjorn Andersson, Robert Marko
Cc: Baruch Siach, Bryan O'Donoghue, netdev, devicetree, linux-arm-msm
On 21/02/2022 14:33, Baruch Siach wrote:
> From: Baruch Siach <baruch.siach@siklu.com>
>
> The IPQ60xx has the same MDIO bug block as IPQ4019. Add IO range and
> clock resources description.
>
> Signed-off-by: Baruch Siach <baruch.siach@siklu.com>
> ---
> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index 5eb7dc9cc231..093011d18ca6 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -635,6 +635,16 @@ qrtr_requests {
> };
> };
>
> + mdio: mdio@90000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "qcom,ipq6018-mdio", "qcom,ipq4019-mdio";
> + reg = <0x0 0x90000 0x0 0x64>;
> + clocks = <&gcc GCC_MDIO_AHB_CLK>;
> + clock-names = "gcc_mdio_ahb_clk";
> + status = "disabled";
> + };
> +
> qusb_phy_1: qusb@59000 {
> compatible = "qcom,ipq6018-qusb2-phy";
> reg = <0x0 0x059000 0x0 0x180>;
LGTM
Reviewd-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: ipq6018: Add mdio bus description
2022-02-21 14:33 ` [PATCH 2/2] arm64: dts: qcom: ipq6018: Add mdio bus description Baruch Siach
2022-02-22 2:35 ` Bryan O'Donoghue
@ 2022-02-22 2:41 ` Bryan O'Donoghue
2022-02-25 19:11 ` Rob Herring
2 siblings, 0 replies; 5+ messages in thread
From: Bryan O'Donoghue @ 2022-02-22 2:41 UTC (permalink / raw)
To: Baruch Siach, Andy Gross, Bjorn Andersson, Robert Marko
Cc: Baruch Siach, netdev, devicetree, linux-arm-msm
On 21/02/2022 14:33, Baruch Siach wrote:
> From: Baruch Siach <baruch.siach@siklu.com>
>
> The IPQ60xx has the same MDIO bug block as IPQ4019. Add IO range and
> clock resources description.
>
> Signed-off-by: Baruch Siach <baruch.siach@siklu.com>
> ---
> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index 5eb7dc9cc231..093011d18ca6 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -635,6 +635,16 @@ qrtr_requests {
> };
> };
>
> + mdio: mdio@90000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "qcom,ipq6018-mdio", "qcom,ipq4019-mdio";
> + reg = <0x0 0x90000 0x0 0x64>;
> + clocks = <&gcc GCC_MDIO_AHB_CLK>;
> + clock-names = "gcc_mdio_ahb_clk";
> + status = "disabled";
> + };
> +
> qusb_phy_1: qusb@59000 {
> compatible = "qcom,ipq6018-qusb2-phy";
> reg = <0x0 0x059000 0x0 0x180>;
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: ipq6018: Add mdio bus description
2022-02-21 14:33 ` [PATCH 2/2] arm64: dts: qcom: ipq6018: Add mdio bus description Baruch Siach
2022-02-22 2:35 ` Bryan O'Donoghue
2022-02-22 2:41 ` Bryan O'Donoghue
@ 2022-02-25 19:11 ` Rob Herring
2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2022-02-25 19:11 UTC (permalink / raw)
To: Baruch Siach
Cc: Andy Gross, Bjorn Andersson, Robert Marko, Baruch Siach,
Bryan O'Donoghue, netdev, devicetree, linux-arm-msm
On Mon, Feb 21, 2022 at 04:33:22PM +0200, Baruch Siach wrote:
> From: Baruch Siach <baruch.siach@siklu.com>
>
> The IPQ60xx has the same MDIO bug block as IPQ4019. Add IO range and
> clock resources description.
>
> Signed-off-by: Baruch Siach <baruch.siach@siklu.com>
> ---
> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index 5eb7dc9cc231..093011d18ca6 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -635,6 +635,16 @@ qrtr_requests {
> };
> };
>
> + mdio: mdio@90000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "qcom,ipq6018-mdio", "qcom,ipq4019-mdio";
This looks correct with the fallback based on your description, but it
doesn't match the schema.
You tested this with the schemas, right? That's why we have them.
> + reg = <0x0 0x90000 0x0 0x64>;
> + clocks = <&gcc GCC_MDIO_AHB_CLK>;
> + clock-names = "gcc_mdio_ahb_clk";
> + status = "disabled";
> + };
> +
> qusb_phy_1: qusb@59000 {
> compatible = "qcom,ipq6018-qusb2-phy";
> reg = <0x0 0x059000 0x0 0x180>;
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-25 19:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-21 14:33 [PATCH 1/2] dt-bindings: net: ipq4019-mdio: Add ipq6018 compatible Baruch Siach
2022-02-21 14:33 ` [PATCH 2/2] arm64: dts: qcom: ipq6018: Add mdio bus description Baruch Siach
2022-02-22 2:35 ` Bryan O'Donoghue
2022-02-22 2:41 ` Bryan O'Donoghue
2022-02-25 19:11 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).