From: Matthias Brugger <matthias.bgg@gmail.com>
To: Fabien Parent <fparent@baylibre.com>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Cc: bibby.hsieh@mediatek.com, robh+dt@kernel.org
Subject: Re: [PATCH] arm64: dts: mediatek: mt8183: fix gce incorrect mbox-cells value
Date: Mon, 19 Oct 2020 12:20:06 +0200 [thread overview]
Message-ID: <a7798c9b-ac25-6eed-055b-af3efe5a18e8@gmail.com> (raw)
In-Reply-To: <20201018194225.3361182-1-fparent@baylibre.com>
On 18/10/2020 21:42, Fabien Parent wrote:
> The binding documentation says:
> - #mbox-cells: Should be 2.
> <&phandle channel priority>
> phandle: Label name of a gce node.
> channel: Channel of mailbox. Be equal to the thread id of GCE.
> priority: Priority of GCE thread.
>
> Fix the value of #mbox-cells.
>
> Fixes: d3c306e31bc7 ("arm64: dts: add gce node for mt8183")
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
Applied, to v5.10-tmp/dts64 thanks!
> ---
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 102105871db2..9a3cf95676e1 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -352,7 +352,7 @@ gce: mailbox@10238000 {
> compatible = "mediatek,mt8183-gce";
> reg = <0 0x10238000 0 0x4000>;
> interrupts = <GIC_SPI 162 IRQ_TYPE_LEVEL_LOW>;
> - #mbox-cells = <3>;
> + #mbox-cells = <2>;
> clocks = <&infracfg CLK_INFRA_GCE>;
> clock-names = "gce";
> };
>
prev parent reply other threads:[~2020-10-19 10:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 19:42 [PATCH] arm64: dts: mediatek: mt8183: fix gce incorrect mbox-cells value Fabien Parent
2020-10-19 10:20 ` Matthias Brugger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7798c9b-ac25-6eed-055b-af3efe5a18e8@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=bibby.hsieh@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=fparent@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).