* [PATCH] arm64: dts: mediatek: mt8183: fix gce incorrect mbox-cells value
@ 2020-10-18 19:42 Fabien Parent
2020-10-19 10:20 ` Matthias Brugger
0 siblings, 1 reply; 2+ messages in thread
From: Fabien Parent @ 2020-10-18 19:42 UTC (permalink / raw)
To: linux-kernel, linux-mediatek, linux-arm-kernel, devicetree
Cc: bibby.hsieh, matthias.bgg, robh+dt, Fabien Parent
The binding documentation says:
- #mbox-cells: Should be 2.
<&phandle channel priority>
phandle: Label name of a gce node.
channel: Channel of mailbox. Be equal to the thread id of GCE.
priority: Priority of GCE thread.
Fix the value of #mbox-cells.
Fixes: d3c306e31bc7 ("arm64: dts: add gce node for mt8183")
Signed-off-by: Fabien Parent <fparent@baylibre.com>
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 102105871db2..9a3cf95676e1 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -352,7 +352,7 @@ gce: mailbox@10238000 {
compatible = "mediatek,mt8183-gce";
reg = <0 0x10238000 0 0x4000>;
interrupts = <GIC_SPI 162 IRQ_TYPE_LEVEL_LOW>;
- #mbox-cells = <3>;
+ #mbox-cells = <2>;
clocks = <&infracfg CLK_INFRA_GCE>;
clock-names = "gce";
};
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: mediatek: mt8183: fix gce incorrect mbox-cells value
2020-10-18 19:42 [PATCH] arm64: dts: mediatek: mt8183: fix gce incorrect mbox-cells value Fabien Parent
@ 2020-10-19 10:20 ` Matthias Brugger
0 siblings, 0 replies; 2+ messages in thread
From: Matthias Brugger @ 2020-10-19 10:20 UTC (permalink / raw)
To: Fabien Parent, linux-kernel, linux-mediatek, linux-arm-kernel,
devicetree
Cc: bibby.hsieh, robh+dt
On 18/10/2020 21:42, Fabien Parent wrote:
> The binding documentation says:
> - #mbox-cells: Should be 2.
> <&phandle channel priority>
> phandle: Label name of a gce node.
> channel: Channel of mailbox. Be equal to the thread id of GCE.
> priority: Priority of GCE thread.
>
> Fix the value of #mbox-cells.
>
> Fixes: d3c306e31bc7 ("arm64: dts: add gce node for mt8183")
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
Applied, to v5.10-tmp/dts64 thanks!
> ---
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 102105871db2..9a3cf95676e1 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -352,7 +352,7 @@ gce: mailbox@10238000 {
> compatible = "mediatek,mt8183-gce";
> reg = <0 0x10238000 0 0x4000>;
> interrupts = <GIC_SPI 162 IRQ_TYPE_LEVEL_LOW>;
> - #mbox-cells = <3>;
> + #mbox-cells = <2>;
> clocks = <&infracfg CLK_INFRA_GCE>;
> clock-names = "gce";
> };
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-19 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-18 19:42 [PATCH] arm64: dts: mediatek: mt8183: fix gce incorrect mbox-cells value Fabien Parent
2020-10-19 10:20 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).