From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Andy Gross <agross@kernel.org>, Lee Jones <lee@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/6] arm: dts: qcom: mdm9615: fix pinctrl subnodes
Date: Fri, 7 Oct 2022 21:36:36 +0200 [thread overview]
Message-ID: <ad9f1515-a7ff-e8a5-bbc0-4f0278c08952@somainline.org> (raw)
In-Reply-To: <20221005-mdm9615-pinctrl-yaml-v1-2-0cbc006e2a30@linaro.org>
On 6.10.2022 11:57, Neil Armstrong wrote:
> Fix the MDM9615 DT to the expected subnodes namings.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> .../boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts | 8 ++++----
> arch/arm/boot/dts/qcom-mdm9615-wp8548.dtsi | 22 +++++++++++-----------
> 2 files changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
> index 4e53b3d70195..30a110984597 100644
> --- a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
> +++ b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
> @@ -45,8 +45,8 @@ &msmgpio {
> * - 42: IOT0_GPIO1 and SD Card Detect
> */
>
> - gpioext1_pins: gpioext1_pins {
> - pins {
> + gpioext1_pins: gpioext1-state {
> + gpioext1-pins {
> pins = "gpio2";
> function = "gpio";
> input-enable;
> @@ -54,8 +54,8 @@ pins {
> };
> };
>
> - sdc_cd_pins: sdc_cd_pins {
> - pins {
> + sdc_cd_pins: sdc-cd-state {
> + sdc-cd-pins {
> pins = "gpio42";
> function = "gpio";
> drive-strength = <2>;
> diff --git a/arch/arm/boot/dts/qcom-mdm9615-wp8548.dtsi b/arch/arm/boot/dts/qcom-mdm9615-wp8548.dtsi
> index 2fe8693dc3cd..92c8003dac25 100644
> --- a/arch/arm/boot/dts/qcom-mdm9615-wp8548.dtsi
> +++ b/arch/arm/boot/dts/qcom-mdm9615-wp8548.dtsi
> @@ -22,8 +22,8 @@ &msmgpio {
> pinctrl-0 = <&reset_out_pins>;
> pinctrl-names = "default";
>
> - gsbi3_pins: gsbi3_pins {
> - mux {
> + gsbi3_pins: gsbi3-state {
> + gsbi3-pins {
> pins = "gpio8", "gpio9", "gpio10", "gpio11";
> function = "gsbi3";
> drive-strength = <8>;
> @@ -31,8 +31,8 @@ mux {
> };
> };
>
> - gsbi4_pins: gsbi4_pins {
> - mux {
> + gsbi4_pins: gsbi4-state {
> + gsbi4-pins {
> pins = "gpio12", "gpio13", "gpio14", "gpio15";
> function = "gsbi4";
> drive-strength = <8>;
> @@ -40,15 +40,15 @@ mux {
> };
> };
>
> - gsbi5_i2c_pins: gsbi5_i2c_pins {
> - pin16 {
> + gsbi5_i2c_pins: gsbi5-i2c-state {
> + sda-pins {
> pins = "gpio16";
> function = "gsbi5_i2c";
> drive-strength = <8>;
> bias-disable;
> };
>
> - pin17 {
> + scl-pins {
> pins = "gpio17";
> function = "gsbi5_i2c";
> drive-strength = <2>;
> @@ -56,8 +56,8 @@ pin17 {
> };
> };
>
> - gsbi5_uart_pins: gsbi5_uart_pins {
> - mux {
> + gsbi5_uart_pins: gsbi5-uart-state {
> + gsbi5-uart-pins {
> pins = "gpio18", "gpio19";
> function = "gsbi5_uart";
> drive-strength = <8>;
> @@ -65,8 +65,8 @@ mux {
> };
> };
>
> - reset_out_pins: reset_out_pins {
> - pins {
> + reset_out_pins: reset-out-state {
> + reset-out-pins {
> pins = "gpio66";
> function = "gpio";
> drive-strength = <2>;
>
next prev parent reply other threads:[~2022-10-07 19:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 9:57 [PATCH 0/6] arm: qcom: mdm9615: second round of bindings and DT fixes Neil Armstrong
2022-10-06 9:57 ` [PATCH 1/6] dt-bindings: pinctrl: convert qcom,mdm9615-pinctrl.txt to dt-schema Neil Armstrong
2022-10-06 11:09 ` Krzysztof Kozlowski
2022-10-06 16:20 ` Neil Armstrong
2022-10-06 20:20 ` Krzysztof Kozlowski
2022-10-06 12:27 ` Rob Herring
2022-10-06 16:21 ` Neil Armstrong
2022-10-06 19:42 ` Rob Herring
2022-10-06 9:57 ` [PATCH 2/6] arm: dts: qcom: mdm9615: fix pinctrl subnodes Neil Armstrong
2022-10-06 11:10 ` Krzysztof Kozlowski
2022-10-07 19:36 ` Konrad Dybcio [this message]
2022-10-06 9:58 ` [PATCH 3/6] arm: dts: qcom: mdm9615: wp8548-mangoh-green: fix sx150xq node names and probe-reset property Neil Armstrong
2022-10-07 19:38 ` Konrad Dybcio
2022-10-10 7:45 ` Neil Armstrong
2022-10-06 9:58 ` [PATCH 4/6] dt-bindings: soc: qcom: convert non-smd RPM bindings to dt-schema Neil Armstrong
2022-10-06 19:53 ` Rob Herring
2022-10-06 9:58 ` [PATCH 5/6] dt-bindings: regulators: convert non-smd RPM Regulators " Neil Armstrong
2022-10-06 12:27 ` Rob Herring
2022-10-06 20:04 ` Rob Herring
2022-10-06 9:58 ` [PATCH 6/6] dt-bindings: soc: qcom: ipc-rpm: refer to qcom,ipc-rpm-regulator.yaml Neil Armstrong
2022-10-06 12:27 ` Rob Herring
2022-10-06 20:05 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad9f1515-a7ff-e8a5-bbc0-4f0278c08952@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).