* [PATCH v2 1/1] dt-bindings: display: meson-vpu: Add missing amlogic,canvas property
@ 2021-12-19 9:41 Alexander Stein
2021-12-19 15:30 ` Martin Blumenstingl
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Alexander Stein @ 2021-12-19 9:41 UTC (permalink / raw)
To: Neil Armstrong, David Airlie, Daniel Vetter, Rob Herring,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl
Cc: Alexander Stein, linux-amlogic, devicetree
This property was already mentioned in the old textual bindings
amlogic,meson-vpu.txt, but got dropped during conversion.
Adding it back similar to amlogic,gx-vdec.yaml.
Fixes: 6b9ebf1e0e67 ("dt-bindings: display: amlogic, meson-vpu: convert to yaml")
Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
---
Changes in v2:
* Do not linebreak Fixes tag
* Make amlogic,canvas mandatory as it was in textual binding already
* Add amlogic,canvas to example
.../devicetree/bindings/display/amlogic,meson-vpu.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml b/Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml
index 851cb0781217..047fd69e0377 100644
--- a/Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml
+++ b/Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml
@@ -78,6 +78,10 @@ properties:
interrupts:
maxItems: 1
+ amlogic,canvas:
+ description: should point to a canvas provider node
+ $ref: /schemas/types.yaml#/definitions/phandle
+
power-domains:
maxItems: 1
description: phandle to the associated power domain
@@ -106,6 +110,7 @@ required:
- port@1
- "#address-cells"
- "#size-cells"
+ - amlogic,canvas
additionalProperties: false
@@ -118,6 +123,7 @@ examples:
interrupts = <3>;
#address-cells = <1>;
#size-cells = <0>;
+ amlogic,canvas = <&canvas>;
/* CVBS VDAC output port */
port@0 {
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: display: meson-vpu: Add missing amlogic,canvas property
2021-12-19 9:41 [PATCH v2 1/1] dt-bindings: display: meson-vpu: Add missing amlogic,canvas property Alexander Stein
@ 2021-12-19 15:30 ` Martin Blumenstingl
2021-12-20 14:12 ` Neil Armstrong
2021-12-22 17:29 ` Rob Herring
2022-01-03 11:16 ` Neil Armstrong
2 siblings, 1 reply; 5+ messages in thread
From: Martin Blumenstingl @ 2021-12-19 15:30 UTC (permalink / raw)
To: Alexander Stein
Cc: Neil Armstrong, David Airlie, Daniel Vetter, Rob Herring,
Kevin Hilman, Jerome Brunet, linux-amlogic, devicetree
On Sun, Dec 19, 2021 at 10:42 AM Alexander Stein
<alexander.stein@mailbox.org> wrote:
>
> This property was already mentioned in the old textual bindings
> amlogic,meson-vpu.txt, but got dropped during conversion.
> Adding it back similar to amlogic,gx-vdec.yaml.
>
> Fixes: 6b9ebf1e0e67 ("dt-bindings: display: amlogic, meson-vpu: convert to yaml")
> Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Thank you very much for this contribution!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: display: meson-vpu: Add missing amlogic,canvas property
2021-12-19 15:30 ` Martin Blumenstingl
@ 2021-12-20 14:12 ` Neil Armstrong
0 siblings, 0 replies; 5+ messages in thread
From: Neil Armstrong @ 2021-12-20 14:12 UTC (permalink / raw)
To: Martin Blumenstingl, Alexander Stein
Cc: David Airlie, Daniel Vetter, Rob Herring, Kevin Hilman,
Jerome Brunet, linux-amlogic, devicetree
Hi,
+ dri-devel@lists.freedesktop.org
Thanks for fixing this.
Le 19/12/2021 à 16:30, Martin Blumenstingl a écrit :
> On Sun, Dec 19, 2021 at 10:42 AM Alexander Stein
> <alexander.stein@mailbox.org> wrote:
>>
>> This property was already mentioned in the old textual bindings
>> amlogic,meson-vpu.txt, but got dropped during conversion.
>> Adding it back similar to amlogic,gx-vdec.yaml.
>>
>> Fixes: 6b9ebf1e0e67 ("dt-bindings: display: amlogic, meson-vpu: convert to yaml")
>> Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
> Thank you very much for this contribution!
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
I'll apply it to drm-misc-next next year or if another drm-misc maintainer can in the meantime, I'm ok with it.
Neil
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: display: meson-vpu: Add missing amlogic,canvas property
2021-12-19 9:41 [PATCH v2 1/1] dt-bindings: display: meson-vpu: Add missing amlogic,canvas property Alexander Stein
2021-12-19 15:30 ` Martin Blumenstingl
@ 2021-12-22 17:29 ` Rob Herring
2022-01-03 11:16 ` Neil Armstrong
2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2021-12-22 17:29 UTC (permalink / raw)
To: Alexander Stein
Cc: Kevin Hilman, Neil Armstrong, linux-amlogic, Martin Blumenstingl,
devicetree, Rob Herring, Daniel Vetter, Jerome Brunet,
David Airlie
On Sun, 19 Dec 2021 10:41:55 +0100, Alexander Stein wrote:
> This property was already mentioned in the old textual bindings
> amlogic,meson-vpu.txt, but got dropped during conversion.
> Adding it back similar to amlogic,gx-vdec.yaml.
>
> Fixes: 6b9ebf1e0e67 ("dt-bindings: display: amlogic, meson-vpu: convert to yaml")
> Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
> ---
> Changes in v2:
> * Do not linebreak Fixes tag
> * Make amlogic,canvas mandatory as it was in textual binding already
> * Add amlogic,canvas to example
>
> .../devicetree/bindings/display/amlogic,meson-vpu.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: display: meson-vpu: Add missing amlogic,canvas property
2021-12-19 9:41 [PATCH v2 1/1] dt-bindings: display: meson-vpu: Add missing amlogic,canvas property Alexander Stein
2021-12-19 15:30 ` Martin Blumenstingl
2021-12-22 17:29 ` Rob Herring
@ 2022-01-03 11:16 ` Neil Armstrong
2 siblings, 0 replies; 5+ messages in thread
From: Neil Armstrong @ 2022-01-03 11:16 UTC (permalink / raw)
To: Alexander Stein, David Airlie, Daniel Vetter, Rob Herring,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl
Cc: linux-amlogic, devicetree
On 19/12/2021 10:41, Alexander Stein wrote:
> This property was already mentioned in the old textual bindings
> amlogic,meson-vpu.txt, but got dropped during conversion.
> Adding it back similar to amlogic,gx-vdec.yaml.
>
> Fixes: 6b9ebf1e0e67 ("dt-bindings: display: amlogic, meson-vpu: convert to yaml")
> Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
> ---
> Changes in v2:
> * Do not linebreak Fixes tag
> * Make amlogic,canvas mandatory as it was in textual binding already
> * Add amlogic,canvas to example
>
> .../devicetree/bindings/display/amlogic,meson-vpu.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml b/Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml
> index 851cb0781217..047fd69e0377 100644
> --- a/Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml
> +++ b/Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml
> @@ -78,6 +78,10 @@ properties:
> interrupts:
> maxItems: 1
>
> + amlogic,canvas:
> + description: should point to a canvas provider node
> + $ref: /schemas/types.yaml#/definitions/phandle
> +
> power-domains:
> maxItems: 1
> description: phandle to the associated power domain
> @@ -106,6 +110,7 @@ required:
> - port@1
> - "#address-cells"
> - "#size-cells"
> + - amlogic,canvas
>
> additionalProperties: false
>
> @@ -118,6 +123,7 @@ examples:
> interrupts = <3>;
> #address-cells = <1>;
> #size-cells = <0>;
> + amlogic,canvas = <&canvas>;
>
> /* CVBS VDAC output port */
> port@0 {
>
Applying to drm-misc-fixes,
Thanks,
Neil
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-03 11:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-19 9:41 [PATCH v2 1/1] dt-bindings: display: meson-vpu: Add missing amlogic,canvas property Alexander Stein
2021-12-19 15:30 ` Martin Blumenstingl
2021-12-20 14:12 ` Neil Armstrong
2021-12-22 17:29 ` Rob Herring
2022-01-03 11:16 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).