* [PATCH] dt-bindings: iio: adc: ad7923: Add dt-bindings for AD7928
@ 2020-02-05 0:21 Daniel Junho
2020-02-05 8:23 ` Ardelean, Alexandru
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Junho @ 2020-02-05 0:21 UTC (permalink / raw)
To: jic23, knaack.h, lars, pmeerw, robh+dt, mark.rutland, linux-iio,
devicetree, linux-kernel, lkcamp, hennerich, patrick.vasseur
From: Daniel Junho <djunho@gmail.com>
Add device tree bindings documentation for AD7923 adc in YAML format.
Tested with:
make ARCH=arm dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
make ARCH=arm dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
Signed-off-by: Daniel Junho <djunho@gmail.com>
---
Hi,
I got maintainers from the driver authors list. Let me know if this is
fine.
Thanks.
.../bindings/iio/adc/adi,ad7923.yaml | 65 +++++++++++++++++++
1 file changed, 65 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
new file mode 100644
index 000000000000..8097441c97be
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
@@ -0,0 +1,65 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/adi,ad7923.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices AD7923 and similars with 4 and 8 Channel ADCs.
+
+maintainers:
+ - Michael Hennerich <hennerich@blackfin.uclinux.org>"
+ - Patrick Vasseur <patrick.vasseur@c-s.fr>"
+
+description: |
+ Analog Devices AD7904, AD7914, AD7923, AD7924 4 Channel ADCs, and AD7908,
+ AD7918, AD7928 8 Channels ADCs.
+
+ Specifications about the part can be found at:
+ https://www.analog.com/media/en/technical-documentation/data-sheets/AD7923.pdf
+ https://www.analog.com/media/en/technical-documentation/data-sheets/AD7904_7914_7924.pdf
+ https://www.analog.com/media/en/technical-documentation/data-sheets/AD7908_7918_7928.pdf
+
+properties:
+ compatible:
+ enum:
+ - adi,ad7904
+ - adi,ad7914
+ - adi,ad7923
+ - adi,ad7924
+ - adi,ad7908
+ - adi,ad7918
+ - adi,ad7928
+
+ reg:
+ maxItems: 1
+
+ refin-supply:
+ description: |
+ The regulator supply for ADC reference voltage.
+
+ '#address-cells':
+ const: 1
+
+ '#size-cells':
+ const: 0
+
+required:
+ - compatible
+ - reg
+
+examples:
+ - |
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ad7928: adc@0 {
+ compatible = "adi,ad7928";
+ reg = <0>;
+ spi-max-frequency = <25000000>;
+ refin-supply = <&adc_vref>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+ };
--
2.25.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: iio: adc: ad7923: Add dt-bindings for AD7928
2020-02-05 0:21 [PATCH] dt-bindings: iio: adc: ad7923: Add dt-bindings for AD7928 Daniel Junho
@ 2020-02-05 8:23 ` Ardelean, Alexandru
2020-02-12 10:57 ` Daniel Junho
0 siblings, 1 reply; 3+ messages in thread
From: Ardelean, Alexandru @ 2020-02-05 8:23 UTC (permalink / raw)
To: patrick.vasseur, linux-kernel, lkcamp, linux-iio, mark.rutland,
devicetree, pmeerw, knaack.h, jic23, hennerich, robh+dt, lars,
djunho
On Tue, 2020-02-04 at 21:21 -0300, Daniel Junho wrote:
> From: Daniel Junho <djunho@gmail.com>
>
> Add device tree bindings documentation for AD7923 adc in YAML format.
>
> Tested with:
> make ARCH=arm dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> make ARCH=arm dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
>
Hey,
Some comments inline.
> Signed-off-by: Daniel Junho <djunho@gmail.com>
> ---
>
> Hi,
>
> I got maintainers from the driver authors list. Let me know if this is
> fine.
>
> Thanks.
>
> .../bindings/iio/adc/adi,ad7923.yaml | 65 +++++++++++++++++++
> 1 file changed, 65 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> b/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> new file mode 100644
> index 000000000000..8097441c97be
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: GPL-2.0-only
License header should be:
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/adi,ad7923.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AD7923 and similars with 4 and 8 Channel ADCs.
> +
> +maintainers:
> + - Michael Hennerich <hennerich@blackfin.uclinux.org>"
For Michael, email now is: michael.hennerich@analog.com
That email may still work, but for new stuff, it should be updated.
> + - Patrick Vasseur <patrick.vasseur@c-s.fr>"
> +
> +description: |
> + Analog Devices AD7904, AD7914, AD7923, AD7924 4 Channel ADCs, and AD7908,
> + AD7918, AD7928 8 Channels ADCs.
> +
> + Specifications about the part can be found at:
> +
> https://www.analog.com/media/en/technical-documentation/data-sheets/AD7923.pdf
> +
> https://www.analog.com/media/en/technical-documentation/data-sheets/AD7904_7914_7924.pdf
> +
> https://www.analog.com/media/en/technical-documentation/data-sheets/AD7908_7918_7928.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - adi,ad7904
> + - adi,ad7914
> + - adi,ad7923
> + - adi,ad7924
> + - adi,ad7908
> + - adi,ad7918
> + - adi,ad7928
> +
> + reg:
> + maxItems: 1
> +
> + refin-supply:
> + description: |
> + The regulator supply for ADC reference voltage.
> +
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ad7928: adc@0 {
> + compatible = "adi,ad7928";
> + reg = <0>;
> + spi-max-frequency = <25000000>;
> + refin-supply = <&adc_vref>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> + };
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: iio: adc: ad7923: Add dt-bindings for AD7928
2020-02-05 8:23 ` Ardelean, Alexandru
@ 2020-02-12 10:57 ` Daniel Junho
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Junho @ 2020-02-12 10:57 UTC (permalink / raw)
To: Ardelean, Alexandru
Cc: patrick.vasseur, linux-kernel, lkcamp, linux-iio, mark.rutland,
devicetree, pmeerw, knaack.h, jic23, robh+dt, lars,
Michael Hennerich
Hi.
Thank you for your review. I will make these changes and send a v2.
On Wed, Feb 5, 2020 at 5:24 AM Ardelean, Alexandru
<alexandru.Ardelean@analog.com> wrote:
>
> On Tue, 2020-02-04 at 21:21 -0300, Daniel Junho wrote:
> > From: Daniel Junho <djunho@gmail.com>
> >
> > Add device tree bindings documentation for AD7923 adc in YAML format.
> >
> > Tested with:
> > make ARCH=arm dt_binding_check
> > DT_SCHEMA_FILES=Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> > make ARCH=arm dtbs_check
> > DT_SCHEMA_FILES=Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> >
>
> Hey,
>
> Some comments inline.
>
>
> > Signed-off-by: Daniel Junho <djunho@gmail.com>
> > ---
> >
> > Hi,
> >
> > I got maintainers from the driver authors list. Let me know if this is
> > fine.
> >
> > Thanks.
> >
> > .../bindings/iio/adc/adi,ad7923.yaml | 65 +++++++++++++++++++
> > 1 file changed, 65 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> > b/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> > new file mode 100644
> > index 000000000000..8097441c97be
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> > @@ -0,0 +1,65 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
>
> License header should be:
> # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>
>
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/adc/adi,ad7923.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices AD7923 and similars with 4 and 8 Channel ADCs.
> > +
> > +maintainers:
> > + - Michael Hennerich <hennerich@blackfin.uclinux.org>"
>
> For Michael, email now is: michael.hennerich@analog.com
> That email may still work, but for new stuff, it should be updated.
>
> > + - Patrick Vasseur <patrick.vasseur@c-s.fr>"
> > +
> > +description: |
> > + Analog Devices AD7904, AD7914, AD7923, AD7924 4 Channel ADCs, and AD7908,
> > + AD7918, AD7928 8 Channels ADCs.
> > +
> > + Specifications about the part can be found at:
> > +
> > https://www.analog.com/media/en/technical-documentation/data-sheets/AD7923.pdf
> > +
> > https://www.analog.com/media/en/technical-documentation/data-sheets/AD7904_7914_7924.pdf
> > +
> > https://www.analog.com/media/en/technical-documentation/data-sheets/AD7908_7918_7928.pdf
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - adi,ad7904
> > + - adi,ad7914
> > + - adi,ad7923
> > + - adi,ad7924
> > + - adi,ad7908
> > + - adi,ad7918
> > + - adi,ad7928
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + refin-supply:
> > + description: |
> > + The regulator supply for ADC reference voltage.
> > +
> > + '#address-cells':
> > + const: 1
> > +
> > + '#size-cells':
> > + const: 0
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +examples:
> > + - |
> > + spi {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + ad7928: adc@0 {
> > + compatible = "adi,ad7928";
> > + reg = <0>;
> > + spi-max-frequency = <25000000>;
> > + refin-supply = <&adc_vref>;
> > +
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + };
> > + };
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-12 10:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-05 0:21 [PATCH] dt-bindings: iio: adc: ad7923: Add dt-bindings for AD7928 Daniel Junho
2020-02-05 8:23 ` Ardelean, Alexandru
2020-02-12 10:57 ` Daniel Junho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).