[PATCH 1/2] ARM: dts: imx6q-cm-fx6: fix the operation points

[PATCH 1/2] ARM: dts: imx6q-cm-fx6: fix the operation points

[christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg]

From: Valentin Raevsky <valentin-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>

Fix the cm-fx6 operation points. Remove settings for 1.2GHz.
The current ldo settings do not allow 1.2GHz cpu frequency.

Signed-off-by: Valentin Raevsky <valentin-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
[christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org: rebased on upstream and adapted
 commit title]
Signed-off-by: Christopher Spinrath <christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org>
---
 arch/arm/boot/dts/imx6q-cm-fx6.dts | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm/boot/dts/imx6q-cm-fx6.dts b/arch/arm/boot/dts/imx6q-cm-fx6.dts
index 6d8d5e9..c912d58 100644
--- a/arch/arm/boot/dts/imx6q-cm-fx6.dts
+++ b/arch/arm/boot/dts/imx6q-cm-fx6.dts
@@ -91,6 +91,23 @@
 	};
 };
 
+&cpu0 {
+	operating-points = <
+		/* kHz	uV */
+		996000	1250000
+		852000	1250000
+		792000	1150000
+		396000	975000
+	>;
+	fsl,soc-operating-points = <
+		/* ARM kHz	SOC-PU uV */
+		996000		1250000
+		852000		1250000
+		792000		1175000
+		396000		1175000
+	>;
+};
+
 &ecspi1 {
 	fsl,spi-num-chipselects = <2>;
 	cs-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>, <&gpio3 19 GPIO_ACTIVE_HIGH>;
-- 
2.8.3

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dts: imx6q-cm-fx6: fix the operation points

[Fabio Estevam]

Hi Christopher,

On Sun, Jun 12, 2016 at 10:20 AM,  <christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> wrote:
> From: Valentin Raevsky <valentin-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
>
> Fix the cm-fx6 operation points. Remove settings for 1.2GHz.
> The current ldo settings do not allow 1.2GHz cpu frequency.
>
> Signed-off-by: Valentin Raevsky <valentin-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
> [christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org: rebased on upstream and adapted
>  commit title]
> Signed-off-by: Christopher Spinrath <christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org>
> ---
>  arch/arm/boot/dts/imx6q-cm-fx6.dts | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6q-cm-fx6.dts b/arch/arm/boot/dts/imx6q-cm-fx6.dts
> index 6d8d5e9..c912d58 100644
> --- a/arch/arm/boot/dts/imx6q-cm-fx6.dts
> +++ b/arch/arm/boot/dts/imx6q-cm-fx6.dts
> @@ -91,6 +91,23 @@
>         };
>  };
>
> +&cpu0 {
> +       operating-points = <
> +               /* kHz  uV */
> +               996000  1250000
> +               852000  1250000
> +               792000  1150000
> +               396000  975000
> +       >;
> +       fsl,soc-operating-points = <
> +               /* ARM kHz      SOC-PU uV */
> +               996000          1250000
> +               852000          1250000
> +               792000          1175000
> +               396000          1175000
> +       >;

These operating points do not match the ones from imx6q.dtsi.

In order to avoid 1.2GHz operation we have
imx6q_opp_check_speed_grading() inside arch/arm/mach-imx/mach-imx6q.c.
This function checks if the mx6q is capable of running at 1.2GHz or
not, depending on the fuse reading and then it will skip the 1.2GHz
operating point if it detects it can't run at such frequency.

These operating points are defined at the SoC dtsi and we don't have
any board dts that define them locally like this patch proposes, so I
recommend we keep using the operating points from imx6q.dtsi.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dts: imx6q-cm-fx6: fix the operation points

[Christopher Spinrath]

Hi Fabio,

thanks for your review!

On 06/12/2016 03:43 PM, Fabio Estevam wrote:
> Hi Christopher,
> 
> On Sun, Jun 12, 2016 at 10:20 AM,  <christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> wrote:
>> From: Valentin Raevsky <valentin-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
>>
>> Fix the cm-fx6 operation points. Remove settings for 1.2GHz.
>> The current ldo settings do not allow 1.2GHz cpu frequency.
>>
>> Signed-off-by: Valentin Raevsky <valentin-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
>> [christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org: rebased on upstream and adapted
>>  commit title]
>> Signed-off-by: Christopher Spinrath <christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org>
>> ---
>>  arch/arm/boot/dts/imx6q-cm-fx6.dts | 17 +++++++++++++++++
>>  1 file changed, 17 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6q-cm-fx6.dts b/arch/arm/boot/dts/imx6q-cm-fx6.dts
>> index 6d8d5e9..c912d58 100644
>> --- a/arch/arm/boot/dts/imx6q-cm-fx6.dts
>> +++ b/arch/arm/boot/dts/imx6q-cm-fx6.dts
>> @@ -91,6 +91,23 @@
>>         };
>>  };
>>
>> +&cpu0 {
>> +       operating-points = <
>> +               /* kHz  uV */
>> +               996000  1250000
>> +               852000  1250000
>> +               792000  1150000
>> +               396000  975000
>> +       >;
>> +       fsl,soc-operating-points = <
>> +               /* ARM kHz      SOC-PU uV */
>> +               996000          1250000
>> +               852000          1250000
>> +               792000          1175000
>> +               396000          1175000
>> +       >;
> 
> These operating points do not match the ones from imx6q.dtsi.
> 
Indeed, the voltage for 792000kHz is not the same. Thanks for pointing
that out.

> In order to avoid 1.2GHz operation we have
> imx6q_opp_check_speed_grading() inside arch/arm/mach-imx/mach-imx6q.c.
> This function checks if the mx6q is capable of running at 1.2GHz or
> not, depending on the fuse reading and then it will skip the 1.2GHz
> operating point if it detects it can't run at such frequency.
> 
> These operating points are defined at the SoC dtsi and we don't have
> any board dts that define them locally like this patch proposes, so I
> recommend we keep using the operating points from imx6q.dtsi.
> 
Well, without this patch the SoC runs at 1.2GHz so it seems like the
fuse indicates that it is possible. But with a fair amount of IPs
enabled and high load the board becomes unstable (display
flickering/blanks, ethernet package drops, ...). I guess CompuLab
allowed 1.2GHz at first and then realized that it is a bad idea (at
least for some boards).

Is there any way to influence the fuse (e.g. from the
firmware/bootloader) or do you have another proposal on how to fix this
issue?

Cheers,
Christopher
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dts: imx6q-cm-fx6: fix the operation points

[Fabio Estevam]

On Sun, Jun 12, 2016 at 11:05 AM, Christopher Spinrath
<christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> wrote:

> Well, without this patch the SoC runs at 1.2GHz so it seems like the
> fuse indicates that it is possible. But with a fair amount of IPs
> enabled and high load the board becomes unstable (display
> flickering/blanks, ethernet package drops, ...). I guess CompuLab
> allowed 1.2GHz at first and then realized that it is a bad idea (at
> least for some boards).
>
> Is there any way to influence the fuse (e.g. from the
> firmware/bootloader) or do you have another proposal on how to fix this
> issue?

Ok, understood. So the mx6q fuse indicates that 1.2GHz operation is
possible on , but the board itself does not behave nicely at this
frequency.

Maybe you could send a v2 of this patch that matches the operating
points form mx6qdl.dtsi and remove only the 1.2GHz entry and put the
explanation you gave us here in the dts and commit log.

Regards,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dts: imx6q-cm-fx6: fix the operation points

[Christopher Spinrath]

Hi Fabio,

On 06/12/2016 04:36 PM, Fabio Estevam wrote:
> On Sun, Jun 12, 2016 at 11:05 AM, Christopher Spinrath
> <christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> wrote:
> 
>> Well, without this patch the SoC runs at 1.2GHz so it seems like the
>> fuse indicates that it is possible. But with a fair amount of IPs
>> enabled and high load the board becomes unstable (display
>> flickering/blanks, ethernet package drops, ...). I guess CompuLab
>> allowed 1.2GHz at first and then realized that it is a bad idea (at
>> least for some boards).
>>
>> Is there any way to influence the fuse (e.g. from the
>> firmware/bootloader) or do you have another proposal on how to fix this
>> issue?
> 
> Ok, understood. So the mx6q fuse indicates that 1.2GHz operation is
> possible on , but the board itself does not behave nicely at this
> frequency.
> 
> Maybe you could send a v2 of this patch that matches the operating
> points form mx6qdl.dtsi and remove only the 1.2GHz entry and put the
> explanation you gave us here in the dts and commit log.
> 

Will do.

Thanks,
Christopher

> Regards,
> 
> Fabio Estevam
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html