* [PATCH v2 0/2] reset: Add ast2600 support
@ 2019-11-29 0:08 Joel Stanley
2019-11-29 0:08 ` [PATCH v2 1/2] dt-bindings: mfd: Add ast2600 to ASPEED LPC Joel Stanley
2019-11-29 0:08 ` [PATCH v2 2/2] reset: simple: Add AST2600 compatibility string Joel Stanley
0 siblings, 2 replies; 8+ messages in thread
From: Joel Stanley @ 2019-11-29 0:08 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Philipp Zabel
Cc: Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed
This series adds ast2600 support to the reset-simple driver, and updates
the device tree documentation for the LPC bindings.
v2 fixes a typo in the bindings that Andrew found.
Brad Bishop (1):
reset: simple: Add AST2600 compatibility string
Joel Stanley (1):
dt-bindings: mfd: Add ast2600 to ASPEED LPC
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 11 +++++++++--
drivers/reset/reset-simple.c | 1 +
2 files changed, 10 insertions(+), 2 deletions(-)
--
2.24.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 1/2] dt-bindings: mfd: Add ast2600 to ASPEED LPC
2019-11-29 0:08 [PATCH v2 0/2] reset: Add ast2600 support Joel Stanley
@ 2019-11-29 0:08 ` Joel Stanley
2019-12-01 23:29 ` Andrew Jeffery
2019-12-13 21:42 ` Rob Herring
2019-11-29 0:08 ` [PATCH v2 2/2] reset: simple: Add AST2600 compatibility string Joel Stanley
1 sibling, 2 replies; 8+ messages in thread
From: Joel Stanley @ 2019-11-29 0:08 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Philipp Zabel
Cc: Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed
The AST2600 has the same LPC layout as previous generation SoCs.
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
v2: Fix cut and paste error in reset bindings
---
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
index 86446074e206..a5d89aa9a3c1 100644
--- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
+++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
@@ -46,6 +46,7 @@ Required properties
- compatible: One of:
"aspeed,ast2400-lpc", "simple-mfd"
"aspeed,ast2500-lpc", "simple-mfd"
+ "aspeed,ast2600-lpc", "simple-mfd"
- reg: contains the physical address and length values of the Aspeed
LPC memory region.
@@ -64,6 +65,7 @@ BMC Node
- compatible: One of:
"aspeed,ast2400-lpc-bmc"
"aspeed,ast2500-lpc-bmc"
+ "aspeed,ast2600-lpc-bmc"
- reg: contains the physical address and length values of the
H8S/2168-compatible LPC controller memory region
@@ -128,6 +130,7 @@ Required properties:
- compatible: One of:
"aspeed,ast2400-lpc-ctrl";
"aspeed,ast2500-lpc-ctrl";
+ "aspeed,ast2600-lpc-ctrl";
- reg: contains offset/length values of the host interface controller
memory regions
@@ -168,6 +171,7 @@ Required properties:
- compatible: One of:
"aspeed,ast2400-lhc";
"aspeed,ast2500-lhc";
+ "aspeed,ast2600-lhc";
- reg: contains offset/length values of the LHC memory regions. In the
AST2400 and AST2500 there are two regions.
@@ -187,8 +191,11 @@ state of the LPC bus. Some systems may chose to modify this configuration.
Required properties:
- - compatible: "aspeed,ast2500-lpc-reset" or
- "aspeed,ast2400-lpc-reset"
+ - compatible: One of:
+ "aspeed,ast2400-reset";
+ "aspeed,ast2500-reset";
+ "aspeed,ast2600-reset";
+
- reg: offset and length of the IP in the LHC memory region
- #reset-controller indicates the number of reset cells expected
--
2.24.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] reset: simple: Add AST2600 compatibility string
2019-11-29 0:08 [PATCH v2 0/2] reset: Add ast2600 support Joel Stanley
2019-11-29 0:08 ` [PATCH v2 1/2] dt-bindings: mfd: Add ast2600 to ASPEED LPC Joel Stanley
@ 2019-11-29 0:08 ` Joel Stanley
2019-12-02 12:53 ` Philipp Zabel
1 sibling, 1 reply; 8+ messages in thread
From: Joel Stanley @ 2019-11-29 0:08 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Philipp Zabel
Cc: Brad Bishop, Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed
From: Brad Bishop <bradleyb@fuzziesquirrel.com>
The AST2600 SoC contains the same LPC register set as the AST2500.
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
drivers/reset/reset-simple.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/reset/reset-simple.c b/drivers/reset/reset-simple.c
index 067e7e7b34f1..795c9063fe7b 100644
--- a/drivers/reset/reset-simple.c
+++ b/drivers/reset/reset-simple.c
@@ -125,6 +125,7 @@ static const struct of_device_id reset_simple_dt_ids[] = {
.data = &reset_simple_active_low },
{ .compatible = "aspeed,ast2400-lpc-reset" },
{ .compatible = "aspeed,ast2500-lpc-reset" },
+ { .compatible = "aspeed,ast2600-lpc-reset" },
{ .compatible = "bitmain,bm1880-reset",
.data = &reset_simple_active_low },
{ .compatible = "snps,dw-high-reset" },
--
2.24.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: mfd: Add ast2600 to ASPEED LPC
2019-11-29 0:08 ` [PATCH v2 1/2] dt-bindings: mfd: Add ast2600 to ASPEED LPC Joel Stanley
@ 2019-12-01 23:29 ` Andrew Jeffery
2019-12-13 21:42 ` Rob Herring
1 sibling, 0 replies; 8+ messages in thread
From: Andrew Jeffery @ 2019-12-01 23:29 UTC (permalink / raw)
To: Joel Stanley, Lee Jones, Rob Herring, Philipp Zabel
Cc: devicetree, linux-arm-kernel, linux-aspeed
On Fri, 29 Nov 2019, at 10:38, Joel Stanley wrote:
> The AST2600 has the same LPC layout as previous generation SoCs.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] reset: simple: Add AST2600 compatibility string
2019-11-29 0:08 ` [PATCH v2 2/2] reset: simple: Add AST2600 compatibility string Joel Stanley
@ 2019-12-02 12:53 ` Philipp Zabel
2019-12-12 14:51 ` Brad Bishop
0 siblings, 1 reply; 8+ messages in thread
From: Philipp Zabel @ 2019-12-02 12:53 UTC (permalink / raw)
To: Joel Stanley, Lee Jones, Rob Herring
Cc: Brad Bishop, Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed
On Fri, 2019-11-29 at 10:38 +1030, Joel Stanley wrote:
> From: Brad Bishop <bradleyb@fuzziesquirrel.com>
>
> The AST2600 SoC contains the same LPC register set as the AST2500.
If the LPC register set is exactly the same, shouldn't AST2600 reuse the
AST2500 compatible, i.e.:
compatible = "aspeed,ast2600-lpc-reset", "aspeed,ast2500-lpc-reset";
?
>
> Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
> Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> drivers/reset/reset-simple.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/reset/reset-simple.c b/drivers/reset/reset-simple.c
> index 067e7e7b34f1..795c9063fe7b 100644
> --- a/drivers/reset/reset-simple.c
> +++ b/drivers/reset/reset-simple.c
> @@ -125,6 +125,7 @@ static const struct of_device_id reset_simple_dt_ids[] = {
> .data = &reset_simple_active_low },
> { .compatible = "aspeed,ast2400-lpc-reset" },
> { .compatible = "aspeed,ast2500-lpc-reset" },
> + { .compatible = "aspeed,ast2600-lpc-reset" },
> { .compatible = "bitmain,bm1880-reset",
> .data = &reset_simple_active_low },
> { .compatible = "snps,dw-high-reset" },
regards
Philipp
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] reset: simple: Add AST2600 compatibility string
2019-12-02 12:53 ` Philipp Zabel
@ 2019-12-12 14:51 ` Brad Bishop
2019-12-12 15:17 ` Philipp Zabel
0 siblings, 1 reply; 8+ messages in thread
From: Brad Bishop @ 2019-12-12 14:51 UTC (permalink / raw)
To: Philipp Zabel
Cc: Joel Stanley, Lee Jones, Rob Herring, Andrew Jeffery, devicetree,
linux-arm-kernel, linux-aspeed
Hi Philipp. Thanks for your time.
> On Dec 2, 2019, at 7:53 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
>
> On Fri, 2019-11-29 at 10:38 +1030, Joel Stanley wrote:
>> From: Brad Bishop <bradleyb@fuzziesquirrel.com>
>>
>> The AST2600 SoC contains the same LPC register set as the AST2500.
>
> If the LPC register set is exactly the same, shouldn't AST2600 reuse the
> AST2500 compatible, i.e.:
> compatible = "aspeed,ast2600-lpc-reset", "aspeed,ast2500-lpc-reset";
> ?
I’m not sure. I let what was already there be my guide - the ast2500 LPC registers are the same as the ast2400 as well and those got their own compatibles. Is there a guideline written down somewhere that backs your thinking up?
thanks - brad
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] reset: simple: Add AST2600 compatibility string
2019-12-12 14:51 ` Brad Bishop
@ 2019-12-12 15:17 ` Philipp Zabel
0 siblings, 0 replies; 8+ messages in thread
From: Philipp Zabel @ 2019-12-12 15:17 UTC (permalink / raw)
To: Brad Bishop
Cc: Joel Stanley, Lee Jones, Rob Herring, Andrew Jeffery, devicetree,
linux-arm-kernel, linux-aspeed
Hi Brad,
On Thu, 2019-12-12 at 09:51 -0500, Brad Bishop wrote:
> Hi Philipp. Thanks for your time.
>
> > On Dec 2, 2019, at 7:53 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> >
> > On Fri, 2019-11-29 at 10:38 +1030, Joel Stanley wrote:
> > > From: Brad Bishop <bradleyb@fuzziesquirrel.com>
> > >
> > > The AST2600 SoC contains the same LPC register set as the AST2500.
> >
> > If the LPC register set is exactly the same, shouldn't AST2600 reuse the
> > AST2500 compatible, i.e.:
> > compatible = "aspeed,ast2600-lpc-reset", "aspeed,ast2500-lpc-reset";
> > ?
>
> I’m not sure. I let what was already there be my guide - the ast2500
> LPC registers are the same as the ast2400 as well and those got their
> own compatibles. Is there a guideline written down somewhere that
> backs your thinking up?
I read section 2.3.1 "compatible" of the DeviceTree Specification [1] as
supporting that view. If all three LPC reset controllers are in fact
identical, I would argue that both ast2500 and ast2600 are compatible to
ast2400 and should be specified as:
compatible = "aspeed,ast2500-lpc-reset", "aspeed,ast2400-lpc-reset";
and:
compatible = "aspeed,ast2600-lpc-reset", "aspeed,ast2400-lpc-reset";
respectively.
[1] https://github.com/devicetree-org/devicetree-specification/releases/download/v0.2/devicetree-specification-v0.2.pdf
regards
Philipp
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: mfd: Add ast2600 to ASPEED LPC
2019-11-29 0:08 ` [PATCH v2 1/2] dt-bindings: mfd: Add ast2600 to ASPEED LPC Joel Stanley
2019-12-01 23:29 ` Andrew Jeffery
@ 2019-12-13 21:42 ` Rob Herring
1 sibling, 0 replies; 8+ messages in thread
From: Rob Herring @ 2019-12-13 21:42 UTC (permalink / raw)
To: Joel Stanley
Cc: Lee Jones, Philipp Zabel, Andrew Jeffery, devicetree,
linux-arm-kernel, linux-aspeed
On Fri, Nov 29, 2019 at 10:38:26AM +1030, Joel Stanley wrote:
> The AST2600 has the same LPC layout as previous generation SoCs.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> v2: Fix cut and paste error in reset bindings
> ---
> Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> index 86446074e206..a5d89aa9a3c1 100644
> --- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> @@ -46,6 +46,7 @@ Required properties
> - compatible: One of:
> "aspeed,ast2400-lpc", "simple-mfd"
> "aspeed,ast2500-lpc", "simple-mfd"
> + "aspeed,ast2600-lpc", "simple-mfd"
>
> - reg: contains the physical address and length values of the Aspeed
> LPC memory region.
> @@ -64,6 +65,7 @@ BMC Node
> - compatible: One of:
> "aspeed,ast2400-lpc-bmc"
> "aspeed,ast2500-lpc-bmc"
> + "aspeed,ast2600-lpc-bmc"
>
> - reg: contains the physical address and length values of the
> H8S/2168-compatible LPC controller memory region
> @@ -128,6 +130,7 @@ Required properties:
> - compatible: One of:
> "aspeed,ast2400-lpc-ctrl";
> "aspeed,ast2500-lpc-ctrl";
> + "aspeed,ast2600-lpc-ctrl";
>
> - reg: contains offset/length values of the host interface controller
> memory regions
> @@ -168,6 +171,7 @@ Required properties:
> - compatible: One of:
> "aspeed,ast2400-lhc";
> "aspeed,ast2500-lhc";
> + "aspeed,ast2600-lhc";
>
> - reg: contains offset/length values of the LHC memory regions. In the
> AST2400 and AST2500 there are two regions.
> @@ -187,8 +191,11 @@ state of the LPC bus. Some systems may chose to modify this configuration.
>
> Required properties:
>
> - - compatible: "aspeed,ast2500-lpc-reset" or
> - "aspeed,ast2400-lpc-reset"
> + - compatible: One of:
> + "aspeed,ast2400-reset";
> + "aspeed,ast2500-reset";
> + "aspeed,ast2600-reset";
Doesn't match what's in the driver.
Rob
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-12-13 21:43 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-29 0:08 [PATCH v2 0/2] reset: Add ast2600 support Joel Stanley
2019-11-29 0:08 ` [PATCH v2 1/2] dt-bindings: mfd: Add ast2600 to ASPEED LPC Joel Stanley
2019-12-01 23:29 ` Andrew Jeffery
2019-12-13 21:42 ` Rob Herring
2019-11-29 0:08 ` [PATCH v2 2/2] reset: simple: Add AST2600 compatibility string Joel Stanley
2019-12-02 12:53 ` Philipp Zabel
2019-12-12 14:51 ` Brad Bishop
2019-12-12 15:17 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).