* [PATCH v2 0/3] Misc fixes up for MT7623 mmc @ 2017-12-07 6:43 sean.wang 2017-12-07 6:43 ` [PATCH v2 1/3] mmc: dt-bindings: add mmc support to MT7623 SoC sean.wang ` (2 more replies) 0 siblings, 3 replies; 8+ messages in thread From: sean.wang @ 2017-12-07 6:43 UTC (permalink / raw) To: robh+dt, matthias.bgg, mark.rutland, devicetree, linux-mediatek Cc: linux-arm-kernel, linux-kernel, Sean Wang From: Sean Wang <sean.wang@mediatek.com> Changes since v1: - add tag from the feedback of v1 - enhance dt-binding documentation Just add some fixes up for the current MT7623 support Patch 1) complement the missing dt-bindings definitions Patch 2) pick up the proper falling back as patch 1 defines. Patch 3) SD-card detection issue caused by the wrong polarity is being fixed up Sean Wang (3): mmc: dt-bindings: add mmc support to MT7623 SoC arm: dts: mt7623: update mmc related nodes with the appropriate fallback arm: dts: mt7623: fix card detection issue on bananapi-r2 Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++ arch/arm/boot/dts/mt7623.dtsi | 4 ++-- arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) -- 2.7.4 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 1/3] mmc: dt-bindings: add mmc support to MT7623 SoC 2017-12-07 6:43 [PATCH v2 0/3] Misc fixes up for MT7623 mmc sean.wang @ 2017-12-07 6:43 ` sean.wang [not found] ` <4f06b509e1e3d4cf5578841cfcf7ec966afd2d48.1512628593.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> 2017-12-07 6:43 ` [PATCH v2 2/3] arm: dts: mt7623: update mmc related nodes with the appropriate fallback sean.wang 2017-12-07 6:43 ` [PATCH v2 3/3] arm: dts: mt7623: fix card detection issue on bananapi-r2 sean.wang 2 siblings, 1 reply; 8+ messages in thread From: sean.wang @ 2017-12-07 6:43 UTC (permalink / raw) To: robh+dt, matthias.bgg, mark.rutland, devicetree, linux-mediatek Cc: linux-arm-kernel, linux-kernel, Sean Wang From: Sean Wang <sean.wang@mediatek.com> Add the devicetree binding for MT7623 SoC using MT2701 as the fallback. Cc: devicetree@vger.kernel.org Signed-off-by: Sean Wang <sean.wang@mediatek.com> Acked-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt index 72d2a73..9b80176 100644 --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt @@ -12,6 +12,8 @@ Required properties: "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173 "mediatek,mt2701-mmc": for mmc host ip compatible with mt2701 "mediatek,mt2712-mmc": for mmc host ip compatible with mt2712 + "mediatek,mt7623-mmc", "mediatek,mt2701-mmc": for MT7623 SoC + - reg: physical base address of the controller and length - interrupts: Should contain MSDC interrupt number - clocks: Should contain phandle for the clock feeding the MMC controller -- 2.7.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
[parent not found: <4f06b509e1e3d4cf5578841cfcf7ec966afd2d48.1512628593.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>]
* Re: [PATCH v2 1/3] mmc: dt-bindings: add mmc support to MT7623 SoC [not found] ` <4f06b509e1e3d4cf5578841cfcf7ec966afd2d48.1512628593.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> @ 2017-12-14 11:16 ` Matthias Brugger 2017-12-14 14:20 ` Sean Wang [not found] ` <86e53802-9bb4-35eb-66e1-f9a401e31863-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 0 siblings, 2 replies; 8+ messages in thread From: Matthias Brugger @ 2017-12-14 11:16 UTC (permalink / raw) To: sean.wang-NuS5LvNUpcJWk0Htik3J/w, Ulf Hansson, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA Hi Ulf, On 12/07/2017 07:43 AM, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote: > From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> > > Add the devicetree binding for MT7623 SoC using MT2701 as the fallback. > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> > Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > --- > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > index 72d2a73..9b80176 100644 > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > @@ -12,6 +12,8 @@ Required properties: > "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173 > "mediatek,mt2701-mmc": for mmc host ip compatible with mt2701 > "mediatek,mt2712-mmc": for mmc host ip compatible with mt2712 > + "mediatek,mt7623-mmc", "mediatek,mt2701-mmc": for MT7623 SoC > + > - reg: physical base address of the controller and length > - interrupts: Should contain MSDC interrupt number > - clocks: Should contain phandle for the clock feeding the MMC controller > Are you fine to take this patch through your branch, or shall I take it through mine? @Sean it seems you forgot to send this patch to Ulf as well. In the future please take care to send the patch to all relevant people and mailinglist. Thanks, Matthias -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/3] mmc: dt-bindings: add mmc support to MT7623 SoC 2017-12-14 11:16 ` Matthias Brugger @ 2017-12-14 14:20 ` Sean Wang [not found] ` <86e53802-9bb4-35eb-66e1-f9a401e31863-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 1 sibling, 0 replies; 8+ messages in thread From: Sean Wang @ 2017-12-14 14:20 UTC (permalink / raw) To: Matthias Brugger Cc: Ulf Hansson, devicetree, linux-mediatek, linux-arm-kernel, linux-kernel On Thu, 2017-12-14 at 12:16 +0100, Matthias Brugger wrote: > Hi Ulf, > > On 12/07/2017 07:43 AM, sean.wang@mediatek.com wrote: > > From: Sean Wang <sean.wang@mediatek.com> > > > > Add the devicetree binding for MT7623 SoC using MT2701 as the fallback. > > > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Sean Wang <sean.wang@mediatek.com> > > Acked-by: Rob Herring <robh@kernel.org> > > --- > > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > index 72d2a73..9b80176 100644 > > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > @@ -12,6 +12,8 @@ Required properties: > > "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173 > > "mediatek,mt2701-mmc": for mmc host ip compatible with mt2701 > > "mediatek,mt2712-mmc": for mmc host ip compatible with mt2712 > > + "mediatek,mt7623-mmc", "mediatek,mt2701-mmc": for MT7623 SoC > > + > > - reg: physical base address of the controller and length > > - interrupts: Should contain MSDC interrupt number > > - clocks: Should contain phandle for the clock feeding the MMC controller > > > > Are you fine to take this patch through your branch, or shall I take it through > mine? > > @Sean it seems you forgot to send this patch to Ulf as well. In the future > please take care to send the patch to all relevant people and mailinglist. > Okay. I'll be. really sorry for the inconvenience > Thanks, > Matthias > ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <86e53802-9bb4-35eb-66e1-f9a401e31863-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH v2 1/3] mmc: dt-bindings: add mmc support to MT7623 SoC [not found] ` <86e53802-9bb4-35eb-66e1-f9a401e31863-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2017-12-15 7:11 ` Ulf Hansson 0 siblings, 0 replies; 8+ messages in thread From: Ulf Hansson @ 2017-12-15 7:11 UTC (permalink / raw) To: Matthias Brugger Cc: sean.wang-NuS5LvNUpcJWk0Htik3J/w, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA On 14 December 2017 at 12:16, Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > Hi Ulf, > > On 12/07/2017 07:43 AM, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote: >> From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> >> >> Add the devicetree binding for MT7623 SoC using MT2701 as the fallback. >> >> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> >> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> >> --- >> Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt >> index 72d2a73..9b80176 100644 >> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt >> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt >> @@ -12,6 +12,8 @@ Required properties: >> "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173 >> "mediatek,mt2701-mmc": for mmc host ip compatible with mt2701 >> "mediatek,mt2712-mmc": for mmc host ip compatible with mt2712 >> + "mediatek,mt7623-mmc", "mediatek,mt2701-mmc": for MT7623 SoC >> + >> - reg: physical base address of the controller and length >> - interrupts: Should contain MSDC interrupt number >> - clocks: Should contain phandle for the clock feeding the MMC controller >> > > Are you fine to take this patch through your branch, or shall I take it through > mine? I have pick it up, thanks! > > @Sean it seems you forgot to send this patch to Ulf as well. In the future > please take care to send the patch to all relevant people and mailinglist. Yeah, thanks for looping me in this time! Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 2/3] arm: dts: mt7623: update mmc related nodes with the appropriate fallback 2017-12-07 6:43 [PATCH v2 0/3] Misc fixes up for MT7623 mmc sean.wang 2017-12-07 6:43 ` [PATCH v2 1/3] mmc: dt-bindings: add mmc support to MT7623 SoC sean.wang @ 2017-12-07 6:43 ` sean.wang 2017-12-07 6:43 ` [PATCH v2 3/3] arm: dts: mt7623: fix card detection issue on bananapi-r2 sean.wang 2 siblings, 0 replies; 8+ messages in thread From: sean.wang @ 2017-12-07 6:43 UTC (permalink / raw) To: robh+dt, matthias.bgg, mark.rutland, devicetree, linux-mediatek Cc: linux-arm-kernel, linux-kernel, Sean Wang From: Sean Wang <sean.wang@mediatek.com> The current mmc related nodes should be falling back to MT2701 as the dt-binding defines and which has more appropriate setup for MT7623. Signed-off-by: Sean Wang <sean.wang@mediatek.com> --- arch/arm/boot/dts/mt7623.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi index 0640fb7..343d3b1 100644 --- a/arch/arm/boot/dts/mt7623.dtsi +++ b/arch/arm/boot/dts/mt7623.dtsi @@ -641,7 +641,7 @@ mmc0: mmc@11230000 { compatible = "mediatek,mt7623-mmc", - "mediatek,mt8135-mmc"; + "mediatek,mt2701-mmc"; reg = <0 0x11230000 0 0x1000>; interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_LOW>; clocks = <&pericfg CLK_PERI_MSDC30_0>, @@ -652,7 +652,7 @@ mmc1: mmc@11240000 { compatible = "mediatek,mt7623-mmc", - "mediatek,mt8135-mmc"; + "mediatek,mt2701-mmc"; reg = <0 0x11240000 0 0x1000>; interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_LOW>; clocks = <&pericfg CLK_PERI_MSDC30_1>, -- 2.7.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 3/3] arm: dts: mt7623: fix card detection issue on bananapi-r2 2017-12-07 6:43 [PATCH v2 0/3] Misc fixes up for MT7623 mmc sean.wang 2017-12-07 6:43 ` [PATCH v2 1/3] mmc: dt-bindings: add mmc support to MT7623 SoC sean.wang 2017-12-07 6:43 ` [PATCH v2 2/3] arm: dts: mt7623: update mmc related nodes with the appropriate fallback sean.wang @ 2017-12-07 6:43 ` sean.wang [not found] ` <e71b755467ce9a1f8bf78e2b6cd2e1b63e8338cd.1512628593.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> 2 siblings, 1 reply; 8+ messages in thread From: sean.wang @ 2017-12-07 6:43 UTC (permalink / raw) To: robh+dt, matthias.bgg, mark.rutland, devicetree, linux-mediatek Cc: linux-arm-kernel, linux-kernel, Sean Wang, stable From: Sean Wang <sean.wang@mediatek.com> Fix that bananapi-r2 booting from SD-card would fail since incorrect polarity is applied to the previous setup with GPIO_ACTIVE_HIGH. Cc: stable@vger.kernel.org Fixes: 0eed8d097612 ("arm: dts: mt7623: Add SD-card and EMMC to bananapi-r2") Signed-off-by: Sean Wang <sean.wang@mediatek.com> Tested-by: Matthias Brugger <matthias.bgg@gmail.com> --- arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts index 688a863..7bf5aa2 100644 --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts @@ -204,7 +204,7 @@ bus-width = <4>; max-frequency = <50000000>; cap-sd-highspeed; - cd-gpios = <&pio 261 0>; + cd-gpios = <&pio 261 GPIO_ACTIVE_LOW>; vmmc-supply = <&mt6323_vmch_reg>; vqmmc-supply = <&mt6323_vio18_reg>; }; -- 2.7.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
[parent not found: <e71b755467ce9a1f8bf78e2b6cd2e1b63e8338cd.1512628593.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>]
* Re: [PATCH v2 3/3] arm: dts: mt7623: fix card detection issue on bananapi-r2 [not found] ` <e71b755467ce9a1f8bf78e2b6cd2e1b63e8338cd.1512628593.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> @ 2017-12-14 11:17 ` Matthias Brugger 0 siblings, 0 replies; 8+ messages in thread From: Matthias Brugger @ 2017-12-14 11:17 UTC (permalink / raw) To: sean.wang-NuS5LvNUpcJWk0Htik3J/w, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, stable-u79uwXL29TY76Z2rM5mHXA On 12/07/2017 07:43 AM, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote: > From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> > > Fix that bananapi-r2 booting from SD-card would fail since incorrect > polarity is applied to the previous setup with GPIO_ACTIVE_HIGH. > > Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Fixes: 0eed8d097612 ("arm: dts: mt7623: Add SD-card and EMMC to bananapi-r2") > Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> > Tested-by: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > index 688a863..7bf5aa2 100644 > --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > @@ -204,7 +204,7 @@ > bus-width = <4>; > max-frequency = <50000000>; > cap-sd-highspeed; > - cd-gpios = <&pio 261 0>; > + cd-gpios = <&pio 261 GPIO_ACTIVE_LOW>; > vmmc-supply = <&mt6323_vmch_reg>; > vqmmc-supply = <&mt6323_vio18_reg>; > }; > 2 and 3 pushed to v4.15-next/dts32 Thanks! -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-12-15 7:11 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-12-07 6:43 [PATCH v2 0/3] Misc fixes up for MT7623 mmc sean.wang 2017-12-07 6:43 ` [PATCH v2 1/3] mmc: dt-bindings: add mmc support to MT7623 SoC sean.wang [not found] ` <4f06b509e1e3d4cf5578841cfcf7ec966afd2d48.1512628593.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> 2017-12-14 11:16 ` Matthias Brugger 2017-12-14 14:20 ` Sean Wang [not found] ` <86e53802-9bb4-35eb-66e1-f9a401e31863-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-12-15 7:11 ` Ulf Hansson 2017-12-07 6:43 ` [PATCH v2 2/3] arm: dts: mt7623: update mmc related nodes with the appropriate fallback sean.wang 2017-12-07 6:43 ` [PATCH v2 3/3] arm: dts: mt7623: fix card detection issue on bananapi-r2 sean.wang [not found] ` <e71b755467ce9a1f8bf78e2b6cd2e1b63e8338cd.1512628593.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> 2017-12-14 11:17 ` Matthias Brugger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).