* [PATCH 1/5] ARM: dts: imx: e60k02: correct led node name
2021-09-23 20:12 [PATCH 0/5] ARM: dts: imx6sl / imx6sll: dtbs_check errors Andreas Kemnade
@ 2021-09-23 20:12 ` Andreas Kemnade
2021-09-24 8:16 ` Krzysztof Kozlowski
2021-09-23 20:12 ` [PATCH 2/5] ARM: dts: imx6sl: fixup of operating points Andreas Kemnade
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Andreas Kemnade @ 2021-09-23 20:12 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, kernel, festevam, linux-imx,
devicetree, linux-kernel, linux-arm-kernel, Krzysztof Kozlowski
Cc: Andreas Kemnade
Only led-X or led are allowed according to bindings definition.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/boot/dts/e60k02.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/e60k02.dtsi b/arch/arm/boot/dts/e60k02.dtsi
index cfb239d5186a..1a49f15f2df2 100644
--- a/arch/arm/boot/dts/e60k02.dtsi
+++ b/arch/arm/boot/dts/e60k02.dtsi
@@ -41,7 +41,7 @@ cover {
leds: leds {
compatible = "gpio-leds";
- on {
+ led {
label = "e60k02:white:on";
gpios = <&gpio5 7 GPIO_ACTIVE_LOW>;
linux,default-trigger = "timer";
--
2.30.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 1/5] ARM: dts: imx: e60k02: correct led node name
2021-09-23 20:12 ` [PATCH 1/5] ARM: dts: imx: e60k02: correct led node name Andreas Kemnade
@ 2021-09-24 8:16 ` Krzysztof Kozlowski
0 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-24 8:16 UTC (permalink / raw)
To: Andreas Kemnade, robh+dt, shawnguo, s.hauer, kernel, festevam,
linux-imx, devicetree, linux-kernel, linux-arm-kernel
On 23/09/2021 22:12, Andreas Kemnade wrote:
> Only led-X or led are allowed according to bindings definition.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> arch/arm/boot/dts/e60k02.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 2/5] ARM: dts: imx6sl: fixup of operating points
2021-09-23 20:12 [PATCH 0/5] ARM: dts: imx6sl / imx6sll: dtbs_check errors Andreas Kemnade
2021-09-23 20:12 ` [PATCH 1/5] ARM: dts: imx: e60k02: correct led node name Andreas Kemnade
@ 2021-09-23 20:12 ` Andreas Kemnade
2021-09-24 8:17 ` Krzysztof Kozlowski
2021-09-23 20:12 ` [PATCH 3/5] ARM: dts: imx6sll: " Andreas Kemnade
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Andreas Kemnade @ 2021-09-23 20:12 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, kernel, festevam, linux-imx,
devicetree, linux-kernel, linux-arm-kernel, Krzysztof Kozlowski
Cc: Andreas Kemnade
Make operating point definitions comply with binding
specifications.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/boot/dts/imx6sl.dtsi | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
index 997b96c1c47b..c7d907c5c352 100644
--- a/arch/arm/boot/dts/imx6sl.dtsi
+++ b/arch/arm/boot/dts/imx6sl.dtsi
@@ -55,18 +55,16 @@ cpu@0 {
device_type = "cpu";
reg = <0x0>;
next-level-cache = <&L2>;
- operating-points = <
+ operating-points =
/* kHz uV */
- 996000 1275000
- 792000 1175000
- 396000 975000
- >;
- fsl,soc-operating-points = <
+ <996000 1275000>,
+ <792000 1175000>,
+ <396000 975000>;
+ fsl,soc-operating-points =
/* ARM kHz SOC-PU uV */
- 996000 1225000
- 792000 1175000
- 396000 1175000
- >;
+ <996000 1225000>,
+ <792000 1175000>,
+ <396000 1175000>;
clock-latency = <61036>; /* two CLK32 periods */
#cooling-cells = <2>;
clocks = <&clks IMX6SL_CLK_ARM>, <&clks IMX6SL_CLK_PLL2_PFD2>,
--
2.30.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 2/5] ARM: dts: imx6sl: fixup of operating points
2021-09-23 20:12 ` [PATCH 2/5] ARM: dts: imx6sl: fixup of operating points Andreas Kemnade
@ 2021-09-24 8:17 ` Krzysztof Kozlowski
0 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-24 8:17 UTC (permalink / raw)
To: Andreas Kemnade, robh+dt, shawnguo, s.hauer, kernel, festevam,
linux-imx, devicetree, linux-kernel, linux-arm-kernel
On 23/09/2021 22:12, Andreas Kemnade wrote:
> Make operating point definitions comply with binding
> specifications.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> arch/arm/boot/dts/imx6sl.dtsi | 18 ++++++++----------
> 1 file changed, 8 insertions(+), 10 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 3/5] ARM: dts: imx6sll: fixup of operating points
2021-09-23 20:12 [PATCH 0/5] ARM: dts: imx6sl / imx6sll: dtbs_check errors Andreas Kemnade
2021-09-23 20:12 ` [PATCH 1/5] ARM: dts: imx: e60k02: correct led node name Andreas Kemnade
2021-09-23 20:12 ` [PATCH 2/5] ARM: dts: imx6sl: fixup of operating points Andreas Kemnade
@ 2021-09-23 20:12 ` Andreas Kemnade
2021-09-24 8:18 ` Krzysztof Kozlowski
2021-09-23 20:12 ` [PATCH 4/5] ARM: dts: imx6sl: fix mmc compatibles Andreas Kemnade
2021-09-23 20:12 ` [PATCH 5/5] ARM: dts: imx6sll: " Andreas Kemnade
4 siblings, 1 reply; 11+ messages in thread
From: Andreas Kemnade @ 2021-09-23 20:12 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, kernel, festevam, linux-imx,
devicetree, linux-kernel, linux-arm-kernel, Krzysztof Kozlowski
Cc: Andreas Kemnade
Make operating point definitions comply with binding
specifications.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/boot/dts/imx6sll.dtsi | 22 ++++++++++------------
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts/imx6sll.dtsi
index 04f8d637a501..0f148f498374 100644
--- a/arch/arm/boot/dts/imx6sll.dtsi
+++ b/arch/arm/boot/dts/imx6sll.dtsi
@@ -51,20 +51,18 @@ cpu0: cpu@0 {
device_type = "cpu";
reg = <0>;
next-level-cache = <&L2>;
- operating-points = <
+ operating-points =
/* kHz uV */
- 996000 1275000
- 792000 1175000
- 396000 1075000
- 198000 975000
- >;
- fsl,soc-operating-points = <
+ <996000 1275000>,
+ <792000 1175000>,
+ <396000 1075000>,
+ <198000 975000>;
+ fsl,soc-operating-points =
/* ARM kHz SOC-PU uV */
- 996000 1175000
- 792000 1175000
- 396000 1175000
- 198000 1175000
- >;
+ <996000 1175000>,
+ <792000 1175000>,
+ <396000 1175000>,
+ <198000 1175000>;
clock-latency = <61036>; /* two CLK32 periods */
#cooling-cells = <2>;
clocks = <&clks IMX6SLL_CLK_ARM>,
--
2.30.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 3/5] ARM: dts: imx6sll: fixup of operating points
2021-09-23 20:12 ` [PATCH 3/5] ARM: dts: imx6sll: " Andreas Kemnade
@ 2021-09-24 8:18 ` Krzysztof Kozlowski
0 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-24 8:18 UTC (permalink / raw)
To: Andreas Kemnade, robh+dt, shawnguo, s.hauer, kernel, festevam,
linux-imx, devicetree, linux-kernel, linux-arm-kernel
On 23/09/2021 22:12, Andreas Kemnade wrote:
> Make operating point definitions comply with binding
> specifications.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> arch/arm/boot/dts/imx6sll.dtsi | 22 ++++++++++------------
> 1 file changed, 10 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts/imx6sll.dtsi
> index 04f8d637a501..0f148f498374 100644
> --- a/arch/arm/boot/dts/imx6sll.dtsi
> +++ b/arch/arm/boot/dts/imx6sll.dtsi
> @@ -51,20 +51,18 @@ cpu0: cpu@0 {
> device_type = "cpu";
> reg = <0>;
> next-level-cache = <&L2>;
> - operating-points = <
> + operating-points =
> /* kHz uV */
> - 996000 1275000
> - 792000 1175000
> - 396000 1075000
> - 198000 975000
> - >;
> - fsl,soc-operating-points = <
> + <996000 1275000>,
> + <792000 1175000>,
> + <396000 1075000>,
> + <198000 975000>;
Please align this line, so I guess double space.
With the change:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 4/5] ARM: dts: imx6sl: fix mmc compatibles
2021-09-23 20:12 [PATCH 0/5] ARM: dts: imx6sl / imx6sll: dtbs_check errors Andreas Kemnade
` (2 preceding siblings ...)
2021-09-23 20:12 ` [PATCH 3/5] ARM: dts: imx6sll: " Andreas Kemnade
@ 2021-09-23 20:12 ` Andreas Kemnade
2021-09-24 8:19 ` Krzysztof Kozlowski
2021-09-23 20:12 ` [PATCH 5/5] ARM: dts: imx6sll: " Andreas Kemnade
4 siblings, 1 reply; 11+ messages in thread
From: Andreas Kemnade @ 2021-09-23 20:12 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, kernel, festevam, linux-imx,
devicetree, linux-kernel, linux-arm-kernel, Krzysztof Kozlowski
Cc: Andreas Kemnade
Binding specification only allows one compatible here.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/boot/dts/imx6sl.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
index c7d907c5c352..887d2a80a335 100644
--- a/arch/arm/boot/dts/imx6sl.dtsi
+++ b/arch/arm/boot/dts/imx6sl.dtsi
@@ -856,7 +856,7 @@ fec: ethernet@2188000 {
};
usdhc1: mmc@2190000 {
- compatible = "fsl,imx6sl-usdhc", "fsl,imx6q-usdhc";
+ compatible = "fsl,imx6sl-usdhc";
reg = <0x02190000 0x4000>;
interrupts = <0 22 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6SL_CLK_USDHC1>,
@@ -868,7 +868,7 @@ usdhc1: mmc@2190000 {
};
usdhc2: mmc@2194000 {
- compatible = "fsl,imx6sl-usdhc", "fsl,imx6q-usdhc";
+ compatible = "fsl,imx6sl-usdhc";
reg = <0x02194000 0x4000>;
interrupts = <0 23 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6SL_CLK_USDHC2>,
@@ -880,7 +880,7 @@ usdhc2: mmc@2194000 {
};
usdhc3: mmc@2198000 {
- compatible = "fsl,imx6sl-usdhc", "fsl,imx6q-usdhc";
+ compatible = "fsl,imx6sl-usdhc";
reg = <0x02198000 0x4000>;
interrupts = <0 24 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6SL_CLK_USDHC3>,
@@ -892,7 +892,7 @@ usdhc3: mmc@2198000 {
};
usdhc4: mmc@219c000 {
- compatible = "fsl,imx6sl-usdhc", "fsl,imx6q-usdhc";
+ compatible = "fsl,imx6sl-usdhc";
reg = <0x0219c000 0x4000>;
interrupts = <0 25 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6SL_CLK_USDHC4>,
--
2.30.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 4/5] ARM: dts: imx6sl: fix mmc compatibles
2021-09-23 20:12 ` [PATCH 4/5] ARM: dts: imx6sl: fix mmc compatibles Andreas Kemnade
@ 2021-09-24 8:19 ` Krzysztof Kozlowski
0 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-24 8:19 UTC (permalink / raw)
To: Andreas Kemnade, robh+dt, shawnguo, s.hauer, kernel, festevam,
linux-imx, devicetree, linux-kernel, linux-arm-kernel
On 23/09/2021 22:12, Andreas Kemnade wrote:
> Binding specification only allows one compatible here.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> arch/arm/boot/dts/imx6sl.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 5/5] ARM: dts: imx6sll: fix mmc compatibles
2021-09-23 20:12 [PATCH 0/5] ARM: dts: imx6sl / imx6sll: dtbs_check errors Andreas Kemnade
` (3 preceding siblings ...)
2021-09-23 20:12 ` [PATCH 4/5] ARM: dts: imx6sl: fix mmc compatibles Andreas Kemnade
@ 2021-09-23 20:12 ` Andreas Kemnade
2021-09-24 8:20 ` Krzysztof Kozlowski
4 siblings, 1 reply; 11+ messages in thread
From: Andreas Kemnade @ 2021-09-23 20:12 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, kernel, festevam, linux-imx,
devicetree, linux-kernel, linux-arm-kernel, Krzysztof Kozlowski
Cc: Andreas Kemnade
Binding specification only allows one compatible here.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/boot/dts/imx6sll.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts/imx6sll.dtsi
index 0f148f498374..36f546274135 100644
--- a/arch/arm/boot/dts/imx6sll.dtsi
+++ b/arch/arm/boot/dts/imx6sll.dtsi
@@ -709,7 +709,7 @@ usbmisc: usbmisc@2184800 {
};
usdhc1: mmc@2190000 {
- compatible = "fsl,imx6sll-usdhc", "fsl,imx6sx-usdhc";
+ compatible = "fsl,imx6sll-usdhc";
reg = <0x02190000 0x4000>;
interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6SLL_CLK_USDHC1>,
@@ -723,7 +723,7 @@ usdhc1: mmc@2190000 {
};
usdhc2: mmc@2194000 {
- compatible = "fsl,imx6sll-usdhc", "fsl,imx6sx-usdhc";
+ compatible = "fsl,imx6sll-usdhc";
reg = <0x02194000 0x4000>;
interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6SLL_CLK_USDHC2>,
@@ -737,7 +737,7 @@ usdhc2: mmc@2194000 {
};
usdhc3: mmc@2198000 {
- compatible = "fsl,imx6sll-usdhc", "fsl,imx6sx-usdhc";
+ compatible = "fsl,imx6sll-usdhc";
reg = <0x02198000 0x4000>;
interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6SLL_CLK_USDHC3>,
--
2.30.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 5/5] ARM: dts: imx6sll: fix mmc compatibles
2021-09-23 20:12 ` [PATCH 5/5] ARM: dts: imx6sll: " Andreas Kemnade
@ 2021-09-24 8:20 ` Krzysztof Kozlowski
0 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-24 8:20 UTC (permalink / raw)
To: Andreas Kemnade, robh+dt, shawnguo, s.hauer, kernel, festevam,
linux-imx, devicetree, linux-kernel, linux-arm-kernel
On 23/09/2021 22:12, Andreas Kemnade wrote:
> Binding specification only allows one compatible here.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> arch/arm/boot/dts/imx6sll.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread