devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] arm64: qcom: sc7280: Move USB2 controller nodes from common dtsi to SKU1
@ 2021-12-02  5:17 Sandeep Maheswaram
  2021-12-02 15:46 ` Matthias Kaehlcke
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Sandeep Maheswaram @ 2021-12-02  5:17 UTC (permalink / raw)
  To: Rob Herring, Andy Gross, Bjorn Andersson, Stephen Boyd,
	Doug Anderson, Matthias Kaehlcke
  Cc: devicetree, linux-arm-msm, linux-usb, linux-kernel,
	quic_pkondeti, quic_ppratap, Sandeep Maheswaram

Move USB2 controller and phy nodes from common dtsi file as it is
required only for SKU1 board and change the mode to host mode as
it will be used in host mode for SKU1.

Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
---
v2:
Squashed the two patches in v1 and changed the commit message.

 arch/arm64/boot/dts/qcom/sc7280-idp.dts  | 16 ++++++++++++++++
 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 16 ----------------
 2 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
index 9b991ba..ffd483d 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
@@ -80,3 +80,19 @@
 		qcom,pre-scaling = <1 1>;
 	};
 };
+
+&usb_2 {
+	status = "okay";
+};
+
+&usb_2_dwc3 {
+	dr_mode = "host";
+};
+
+&usb_2_hsphy {
+	status = "okay";
+
+	vdda-pll-supply = <&vreg_l10c_0p8>;
+	vdda33-supply = <&vreg_l2b_3p0>;
+	vdda18-supply = <&vreg_l1c_1p8>;
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
index d623d71..c54ad62 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
@@ -398,22 +398,6 @@
 	vdda-pll-supply = <&vreg_l1b_0p8>;
 };
 
-&usb_2 {
-	status = "okay";
-};
-
-&usb_2_dwc3 {
-	dr_mode = "peripheral";
-};
-
-&usb_2_hsphy {
-	status = "okay";
-
-	vdda-pll-supply = <&vreg_l10c_0p8>;
-	vdda33-supply = <&vreg_l2b_3p0>;
-	vdda18-supply = <&vreg_l1c_1p8>;
-};
-
 &uart7 {
 	status = "okay";
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] arm64: qcom: sc7280: Move USB2 controller nodes from common dtsi to SKU1
  2021-12-02  5:17 [PATCH v2] arm64: qcom: sc7280: Move USB2 controller nodes from common dtsi to SKU1 Sandeep Maheswaram
@ 2021-12-02 15:46 ` Matthias Kaehlcke
  2021-12-02 22:52 ` Stephen Boyd
  2022-01-31 18:24 ` (subset) " Bjorn Andersson
  2 siblings, 0 replies; 7+ messages in thread
From: Matthias Kaehlcke @ 2021-12-02 15:46 UTC (permalink / raw)
  To: Sandeep Maheswaram
  Cc: Rob Herring, Andy Gross, Bjorn Andersson, Stephen Boyd,
	Doug Anderson, devicetree, linux-arm-msm, linux-usb,
	linux-kernel, quic_pkondeti, quic_ppratap

On Thu, Dec 02, 2021 at 10:47:28AM +0530, Sandeep Maheswaram wrote:
> Move USB2 controller and phy nodes from common dtsi file as it is
> required only for SKU1 board and change the mode to host mode as
> it will be used in host mode for SKU1.
> 
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>

Reviewed-by: Matthias Kaehlcke <mka@chromium.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] arm64: qcom: sc7280: Move USB2 controller nodes from common dtsi to SKU1
  2021-12-02  5:17 [PATCH v2] arm64: qcom: sc7280: Move USB2 controller nodes from common dtsi to SKU1 Sandeep Maheswaram
  2021-12-02 15:46 ` Matthias Kaehlcke
@ 2021-12-02 22:52 ` Stephen Boyd
  2021-12-15  5:48   ` Sandeep Maheswaram
  2022-01-31 18:24 ` (subset) " Bjorn Andersson
  2 siblings, 1 reply; 7+ messages in thread
From: Stephen Boyd @ 2021-12-02 22:52 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Doug Anderson, Matthias Kaehlcke,
	Rob Herring, Sandeep Maheswaram
  Cc: devicetree, linux-arm-msm, linux-usb, linux-kernel,
	quic_pkondeti, quic_ppratap

Quoting Sandeep Maheswaram (2021-12-01 21:17:28)
> Move USB2 controller and phy nodes from common dtsi file as it is
> required only for SKU1 board and change the mode to host mode as
> it will be used in host mode for SKU1.
>
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] arm64: qcom: sc7280: Move USB2 controller nodes from common dtsi to SKU1
  2021-12-02 22:52 ` Stephen Boyd
@ 2021-12-15  5:48   ` Sandeep Maheswaram
  2022-01-10  4:56     ` Sandeep Maheswaram
  0 siblings, 1 reply; 7+ messages in thread
From: Sandeep Maheswaram @ 2021-12-15  5:48 UTC (permalink / raw)
  To: Stephen Boyd, Andy Gross, Bjorn Andersson, Doug Anderson,
	Matthias Kaehlcke, Rob Herring
  Cc: devicetree, linux-arm-msm, linux-usb, linux-kernel,
	quic_pkondeti, quic_ppratap

Hi Bjorn,

On 12/3/2021 4:22 AM, Stephen Boyd wrote:
> Quoting Sandeep Maheswaram (2021-12-01 21:17:28)
>> Move USB2 controller and phy nodes from common dtsi file as it is
>> required only for SKU1 board and change the mode to host mode as
>> it will be used in host mode for SKU1.
>>
>> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
>> ---
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Can you merge this change in qcom tree?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] arm64: qcom: sc7280: Move USB2 controller nodes from common dtsi to SKU1
  2021-12-15  5:48   ` Sandeep Maheswaram
@ 2022-01-10  4:56     ` Sandeep Maheswaram
  2022-01-10 19:10       ` Bjorn Andersson
  0 siblings, 1 reply; 7+ messages in thread
From: Sandeep Maheswaram @ 2022-01-10  4:56 UTC (permalink / raw)
  To: Stephen Boyd, Andy Gross, Bjorn Andersson, Doug Anderson,
	Matthias Kaehlcke, Rob Herring
  Cc: devicetree, linux-arm-msm, linux-usb, linux-kernel,
	quic_pkondeti, quic_ppratap

Hi Bjorn,

On 12/15/2021 11:18 AM, Sandeep Maheswaram wrote:
> Hi Bjorn,
>
> On 12/3/2021 4:22 AM, Stephen Boyd wrote:
>> Quoting Sandeep Maheswaram (2021-12-01 21:17:28)
>>> Move USB2 controller and phy nodes from common dtsi file as it is
>>> required only for SKU1 board and change the mode to host mode as
>>> it will be used in host mode for SKU1.
>>>
>>> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
>>> ---
>> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> Can you merge this change in qcom tree?

Is this patch merged in qcom tree ? If not can you please do so.

Regards

Sandeep



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] arm64: qcom: sc7280: Move USB2 controller nodes from common dtsi to SKU1
  2022-01-10  4:56     ` Sandeep Maheswaram
@ 2022-01-10 19:10       ` Bjorn Andersson
  0 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2022-01-10 19:10 UTC (permalink / raw)
  To: Sandeep Maheswaram
  Cc: Stephen Boyd, Andy Gross, Doug Anderson, Matthias Kaehlcke,
	Rob Herring, devicetree, linux-arm-msm, linux-usb, linux-kernel,
	quic_pkondeti, quic_ppratap

On Sun 09 Jan 20:56 PST 2022, Sandeep Maheswaram wrote:

> Hi Bjorn,
> 
> On 12/15/2021 11:18 AM, Sandeep Maheswaram wrote:
> > Hi Bjorn,
> > 
> > On 12/3/2021 4:22 AM, Stephen Boyd wrote:
> > > Quoting Sandeep Maheswaram (2021-12-01 21:17:28)
> > > > Move USB2 controller and phy nodes from common dtsi file as it is
> > > > required only for SKU1 board and change the mode to host mode as
> > > > it will be used in host mode for SKU1.
> > > > 
> > > > Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> > > > ---
> > > Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> > Can you merge this change in qcom tree?
> 
> Is this patch merged in qcom tree ? If not can you please do so.
> 

Sorry, I seem to have missed this in the patch list. Will pick it up for
v5.18.

Thanks,
Bjorn

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: (subset) [PATCH v2] arm64: qcom: sc7280: Move USB2 controller nodes from common dtsi to SKU1
  2021-12-02  5:17 [PATCH v2] arm64: qcom: sc7280: Move USB2 controller nodes from common dtsi to SKU1 Sandeep Maheswaram
  2021-12-02 15:46 ` Matthias Kaehlcke
  2021-12-02 22:52 ` Stephen Boyd
@ 2022-01-31 18:24 ` Bjorn Andersson
  2 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2022-01-31 18:24 UTC (permalink / raw)
  To: Rob Herring, Sandeep Maheswaram, Andy Gross, Stephen Boyd,
	Matthias Kaehlcke, Doug Anderson
  Cc: devicetree, linux-usb, linux-arm-msm, quic_ppratap,
	quic_pkondeti, linux-kernel

On Thu, 2 Dec 2021 10:47:28 +0530, Sandeep Maheswaram wrote:
> Move USB2 controller and phy nodes from common dtsi file as it is
> required only for SKU1 board and change the mode to host mode as
> it will be used in host mode for SKU1.
> 
> 

Applied, thanks!

[1/1] arm64: qcom: sc7280: Move USB2 controller nodes from common dtsi to SKU1
      commit: 1b968998a3cbd346e7b01a5b41f4c88b979ae7d5

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-01-31 18:24 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-02  5:17 [PATCH v2] arm64: qcom: sc7280: Move USB2 controller nodes from common dtsi to SKU1 Sandeep Maheswaram
2021-12-02 15:46 ` Matthias Kaehlcke
2021-12-02 22:52 ` Stephen Boyd
2021-12-15  5:48   ` Sandeep Maheswaram
2022-01-10  4:56     ` Sandeep Maheswaram
2022-01-10 19:10       ` Bjorn Andersson
2022-01-31 18:24 ` (subset) " Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).