From: Michael Walle <michael@walle.cc>
To: Leo Li <leoyang.li@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-can@vger.kernel.org,
Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Joakim Zhang <qiangqing.zhang@nxp.com>
Subject: Re: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes
Date: Thu, 24 Sep 2020 13:31:00 +0200 [thread overview]
Message-ID: <e9347e4c2e070ee9e8aa7a8007d89f02@walle.cc> (raw)
In-Reply-To: <VE1PR04MB6687AC23E100D138FEDB012A8F390@VE1PR04MB6687.eurprd04.prod.outlook.com>
Am 2020-09-24 02:35, schrieb Leo Li:
>> -----Original Message-----
>> From: Michael Walle <michael@walle.cc>
>> Sent: Wednesday, September 23, 2020 4:57 AM
>> To: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
>> linux-
>> kernel@vger.kernel.org; linux-can@vger.kernel.org
>> Cc: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; Rob
>> Herring <robh+dt@kernel.org>; Marc Kleine-Budde <mkl@pengutronix.de>;
>> Joakim Zhang <qiangqing.zhang@nxp.com>; Michael Walle
>> <michael@walle.cc>
>> Subject: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes
>>
>> The LS1028A has two FlexCAN controller. These are compatible with the
>> ones
>> from the LX2160A. Add the nodes.
>>
>> The first controller was tested on the Kontron sl28 board.
>>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 18
>> ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> index 0efeb8fa773e..807ee921ec12 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> @@ -386,6 +386,24 @@
>> status = "disabled";
>> };
>>
>> + can0: can@2180000 {
>> + compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-
>> flexcan";
>
> The explicit compatible strings cannot be found in the binding, but
> matched by the "fsl,<processor>-flexcan" pattern in the binding. Is
> this considered to be acceptable now?
What is the consequence if it is not acceptable? replacing the pattern
with individual compatible strings?
-michael
next prev parent reply other threads:[~2020-09-24 11:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 9:57 [PATCH 0/2] arm64: dts: add FlexCAN support to LS1028A and sl28 Michael Walle
2020-09-23 9:57 ` [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes Michael Walle
2020-09-24 0:35 ` Leo Li
2020-09-24 11:31 ` Michael Walle [this message]
2020-09-24 15:53 ` Leo Li
2020-09-25 9:31 ` Michael Walle
2020-09-25 9:34 ` Marc Kleine-Budde
2020-09-25 11:35 ` Michael Walle
2020-09-23 9:57 ` [PATCH 2/2] arm64: dts: freescale: sl28: add CAN node Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9347e4c2e070ee9e8aa7a8007d89f02@walle.cc \
--to=michael@walle.cc \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=qiangqing.zhang@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).