From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: <vkoul@kernel.org>, <nm@ti.com>, <ssantosh@kernel.org>,
<dan.j.williams@intel.com>, <dmaengine@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<grygorii.strashko@ti.com>, <lokeshvutla@ti.com>,
<t-kristo@ti.com>, <tony@atomide.com>, <j-keerthy@ti.com>
Subject: [PATCH v4 08/15] dt-bindings: dma: ti: Add document for K3 UDMA
Date: Tue, 5 Nov 2019 12:08:36 +0200 [thread overview]
Message-ID: <fc1ea525-54f1-ff1a-7e1c-61b54f5be862@ti.com> (raw)
In-Reply-To: <20191105021900.GA17829@bogus>
On 05/11/2019 4.19, Rob Herring wrote:
> On Fri, Nov 01, 2019 at 10:41:28AM +0200, Peter Ujfalusi wrote:
>> New binding document for
>> Texas Instruments K3 NAVSS Unified DMA – Peripheral Root Complex (UDMA-P).
>>
>> UDMA-P is introduced as part of the K3 architecture and can be found in
>> AM654 and j721e.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> ---
>> Rob,
>>
>> can you give me some hint on how to fix these two warnings from dt_binding_check:
>>
>> DTC Documentation/devicetree/bindings/dma/ti/k3-udma.example.dt.yaml
>> Documentation/devicetree/bindings/dma/ti/k3-udma.example.dts:23.13-72: Warning (ranges_format): /example-0/interconnect@30800000:ranges: "ranges" property has invalid length (24 bytes) (parent #address-cells == 1, child #address-cells == 2, #size-cells == 2)
>> CHECK Documentation/devicetree/bindings/dma/ti/k3-udma.example.dt.yaml
>
> The default #address-cells is 1 for examples. So you need to
> either override it or change ranges parent address size.
wrapping the cbass_main_navss inside:
cbass_main {
#address-cells = <2>;
#size-cells = <2>;
...
};
fixes it.
>>
>> Documentation/devicetree/bindings/dma/ti/k3-udma.example.dt.yaml: interconnect@30800000: $nodename:0: 'interconnect@30800000' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
>
> Use 'bus' for the node name of 'simple-bus'.
I took the navss node from the upstream dts (I'm going to fix it there
as well).
It has simple-bus for the navss, which is not quite right as NAVSS is
not a bus, but a big subsystem with multiple components (UDMAP, ringacc,
INTA, INTR, timers, etc).
What about to change the binding doc to simple-mfd like this
cbass_main_navss: navss@30800000 {
compatible = "simple-mfd";
#address-cells = <2>;
#size-cells = <2>;
...
};
and fix up the DT when I got to the point when I can send the patches to
enable DMA for am654 and j721e?
>>
>> .../devicetree/bindings/dma/ti/k3-udma.yaml | 190 ++++++++++++++++++
>> 1 file changed, 190 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/dma/ti/k3-udma.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/dma/ti/k3-udma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-udma.yaml
>> new file mode 100644
>> index 000000000000..e00fe3b2364e
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/dma/ti/k3-udma.yaml
>> @@ -0,0 +1,190 @@
>> +# SPDX-License-Identifier: GPL-2.0
>
> Dual license new bindings:
>
> # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
OK.
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/dma/ti/k3-udma.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Texas Instruments K3 NAVSS Unified DMA Device Tree Bindings
>> +
>> +maintainers:
>> + - Peter Ujfalusi <peter.ujfalusi@ti.com>
>> +
>> +description: |
>> + The UDMA-P is intended to perform similar (but significantly upgraded)
>> + functions as the packet-oriented DMA used on previous SoC devices. The UDMA-P
>> + module supports the transmission and reception of various packet types.
>> + The UDMA-P is architected to facilitate the segmentation and reassembly of
>> + SoC DMA data structure compliant packets to/from smaller data blocks that are
>> + natively compatible with the specific requirements of each connected
>> + peripheral.
>> + Multiple Tx and Rx channels are provided within the DMA which allow multiple
>> + segmentation or reassembly operations to be ongoing. The DMA controller
>> + maintains state information for each of the channels which allows packet
>> + segmentation and reassembly operations to be time division multiplexed between
>> + channels in order to share the underlying DMA hardware. An external DMA
>> + scheduler is used to control the ordering and rate at which this multiplexing
>> + occurs for Transmit operations. The ordering and rate of Receive operations
>> + is indirectly controlled by the order in which blocks are pushed into the DMA
>> + on the Rx PSI-L interface.
>> +
>> + The UDMA-P also supports acting as both a UTC and UDMA-C for its internal
>> + channels. Channels in the UDMA-P can be configured to be either Packet-Based
>> + or Third-Party channels on a channel by channel basis.
>> +
>> + All transfers within NAVSS is done between PSI-L source and destination
>> + threads.
>> + The peripherals serviced by UDMA can be PSI-L native (sa2ul, cpsw, etc) or
>> + legacy, non PSI-L native peripherals. In the later case a special, small PDMA
>> + is tasked to act as a bridge between the PSI-L fabric and the legacy
>> + peripheral.
>> +
>> + PDMAs can be configured via UDMAP peer registers to match with the
>> + configuration of the legacy peripheral.
>> +
>> +allOf:
>> + - $ref: "../dma-controller.yaml#"
>> +
>> +properties:
>> + "#dma-cells":
>> + const: 1
>> + description: |
>> + The cell is the PSI-L thread ID of the remote (to UDMAP) end.
>> + Valid ranges for thread ID depends on the data movement direction:
>> + for source thread IDs (rx): 0 - 0x7fff
>> + for destination thread IDs (tx): 0x8000 - 0xffff
>> +
>> + PLease refer to the device documentation for the PSI-L thread map and also
>> + the PSI-L peripheral chapter for the correct thread ID.
>> +
>> + compatible:
>> + oneOf:
>> + - const: ti,am654-navss-main-udmap
>> + - const: ti,am654-navss-mcu-udmap
>> + - const: ti,j721e-navss-main-udmap
>> + - const: ti,j721e-navss-mcu-udmap
>
> enum works better than oneOf+const. Better error messages.
Like this:
compatible:
oneOf:
- description: for AM654
items:
- enum:
- ti,am654-navss-main-udmap
- ti,am654-navss-mcu-udmap
- description: for J721E
items:
- enum:
- ti,j721e-navss-main-udmap
- ti,j721e-navss-mcu-udmap
>
>> +
>> + reg:
>> + maxItems: 3
>> +
>> + reg-names:
>> + items:
>> + - const: gcfg
>> + - const: rchanrt
>> + - const: tchanrt
>> +
>> + msi-parent: true
>> +
>> + ti,sci:
>> + description: |
>
> Doesn't need to be a literal block (can drop the '|').
OK
>
>> + phandle to TI-SCI compatible System controller node
>> + maxItems: 1
>
> Drop this, not an array.
>
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/phandle
>> +
>> + ti,sci-dev-id:
>> + description: |
>> + TI-SCI device id of UDMAP
>> + maxItems: 1
>
> Drop this.
>
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/uint32
>> +
>> + ti,ringacc:
>> + description: |
>> + phandle to the ring accelerator node
>> + maxItems: 1
>
> Drop this.
>
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/phandle
>> +
>> + ti,sci-rm-range-tchan:
>> + description: |
>> + Array of UDMA tchan resource subtypes for resource allocation for this
>> + host
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/uint32-array
>> + items:
>> + minItems: 1
>> + # Should be enough
>> + maxItems: 255
>
> These should not be under 'items'. Drop 'items'.
>
> Any constraints on the values of the array elements?
The subtype is usually smaller than 30 for the current K3 device
line-up, but I would not set an upper limit, it all depends on system
firmware for the given family member.
I'll drop the items for the rm-ranges
>
>> +
>> + ti,sci-rm-range-rchan:
>> + description: |
>> + Array of UDMA rchan resource subtypes for resource allocation for this
>> + host
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/uint32-array
>> + items:
>> + minItems: 1
>> + # Should be enough
>> + maxItems: 255
>
> Same here.
>
>> +
>> + ti,sci-rm-range-rflow:
>> + description: |
>> + Array of UDMA rflow resource subtypes for resource allocation for this
>> + host
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/uint32-array
>> + items:
>> + minItems: 1
>> + # Should be enough
>> + maxItems: 255
>
> And here.
>
>> +
>> +required:
>> + - compatible
>> + - "#dma-cells"
>> + - reg
>> + - reg-names
>> + - msi-parent
>> + - ti,sci
>> + - ti,sci-dev-id
>> + - ti,ringacc
>> + - ti,sci-rm-range-tchan
>> + - ti,sci-rm-range-rchan
>> + - ti,sci-rm-range-rflow
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2019-11-05 10:07 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 8:41 [PATCH v4 00/15] dmaengine/soc: Add Texas Instruments UDMA support Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 01/15] bindings: soc: ti: add documentation for k3 ringacc Peter Ujfalusi
2019-11-11 4:07 ` Vinod Koul
2019-11-11 7:24 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 02/15] soc: ti: k3: add navss ringacc driver Peter Ujfalusi
2019-11-11 4:21 ` Vinod Koul
2019-11-11 7:39 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 03/15] dmaengine: doc: Add sections for per descriptor metadata support Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 04/15] dmaengine: Add metadata_ops for dma_async_tx_descriptor Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 05/15] dmaengine: Add support for reporting DMA cached data amount Peter Ujfalusi
2019-11-11 4:39 ` Vinod Koul
2019-11-11 8:00 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 06/15] dmaengine: ti: Add cppi5 header for K3 NAVSS/UDMA Peter Ujfalusi
2019-11-05 7:40 ` Tero Kristo
2019-11-01 8:41 ` [PATCH v4 07/15] dmaengine: ti: k3 PSI-L remote endpoint configuration Peter Ujfalusi
2019-11-05 7:49 ` Tero Kristo
2019-11-05 8:13 ` Peter Ujfalusi
2019-11-05 10:00 ` Grygorii Strashko
2019-11-05 10:27 ` Peter Ujfalusi
2019-11-05 11:25 ` Grygorii Strashko
2019-11-11 4:47 ` Vinod Koul
2019-11-11 8:47 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 08/15] dt-bindings: dma: ti: Add document for K3 UDMA Peter Ujfalusi
2019-11-05 2:19 ` Rob Herring
2019-11-05 10:08 ` Peter Ujfalusi [this message]
2019-11-14 17:53 ` Rob Herring
2019-11-15 9:45 ` Peter Ujfalusi
2019-11-26 8:29 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 09/15] dmaengine: ti: New driver for K3 UDMA - split#1: defines, structs, io func Peter Ujfalusi
2019-11-11 5:28 ` Vinod Koul
2019-11-11 8:33 ` Peter Ujfalusi
2019-11-11 9:00 ` Vinod Koul
2019-11-11 9:12 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 10/15] dmaengine: ti: New driver for K3 UDMA - split#2: probe/remove, xlate and filter_fn Peter Ujfalusi
2019-11-11 5:33 ` Vinod Koul
2019-11-11 9:16 ` Peter Ujfalusi
2019-11-12 5:34 ` Vinod Koul
2019-11-12 7:22 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 11/15] dmaengine: ti: New driver for K3 UDMA - split#3: alloc/free chan_resources Peter Ujfalusi
2019-11-11 6:06 ` Vinod Koul
2019-11-11 9:40 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 12/15] dmaengine: ti: New driver for K3 UDMA - split#4: dma_device callbacks 1 Peter Ujfalusi
2019-11-11 6:09 ` Vinod Koul
2019-11-11 10:29 ` Peter Ujfalusi
2019-11-12 5:36 ` Vinod Koul
2019-11-12 7:24 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 13/15] dmaengine: ti: New driver for K3 UDMA - split#5: dma_device callbacks 2 Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 14/15] dmaengine: ti: New driver for K3 UDMA - split#6: Kconfig and Makefile Peter Ujfalusi
2019-11-11 6:11 ` Vinod Koul
2019-11-11 10:30 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 15/15] dmaengine: ti: k3-udma: Add glue layer for non DMAengine users Peter Ujfalusi
2019-11-11 6:12 ` Vinod Koul
2019-11-11 10:31 ` Peter Ujfalusi
2019-11-12 5:37 ` Vinod Koul
2019-11-12 7:25 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc1ea525-54f1-ff1a-7e1c-61b54f5be862@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).