From: Palmer Dabbelt <palmer@dabbelt.com>
To: zong.li@sifive.com
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
Paul Walmsley <paul.walmsley@sifive.com>,
aou@eecs.berkeley.edu, greentime.hu@sifive.com,
conor.dooley@microchip.com, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
zong.li@sifive.com
Subject: Re: [PATCH 1/3] dt-bindings: sifive-ccache: rename SiFive L2 cache to composible cache
Date: Thu, 06 Oct 2022 19:58:05 -0700 (PDT) [thread overview]
Message-ID: <mhng-050016e5-0f50-4366-b4bd-98b4b36a56bb@palmer-ri-x1c9> (raw)
In-Reply-To: <20220829062202.3287-2-zong.li@sifive.com>
On Sun, 28 Aug 2022 23:22:00 PDT (-0700), zong.li@sifive.com wrote:
> Since composible cache may be L3 cache if private L2 cache exists, it
> should use its original name composible cache to prevent confusion.
>
> Signed-off-by: Greentime Hu <greentime.hu@sifive.com>
> Signed-off-by: Zong Li <zong.li@sifive.com>
> ---
> .../riscv/{sifive-l2-cache.yaml => sifive-ccache.yaml} | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
> rename Documentation/devicetree/bindings/riscv/{sifive-l2-cache.yaml => sifive-ccache.yaml} (92%)
>
> diff --git a/Documentation/devicetree/bindings/riscv/sifive-l2-cache.yaml b/Documentation/devicetree/bindings/riscv/sifive-ccache.yaml
> similarity index 92%
> rename from Documentation/devicetree/bindings/riscv/sifive-l2-cache.yaml
> rename to Documentation/devicetree/bindings/riscv/sifive-ccache.yaml
> index 69cdab18d629..1a64a5384e36 100644
> --- a/Documentation/devicetree/bindings/riscv/sifive-l2-cache.yaml
> +++ b/Documentation/devicetree/bindings/riscv/sifive-ccache.yaml
> @@ -12,8 +12,8 @@ maintainers:
> - Paul Walmsley <paul.walmsley@sifive.com>
>
> description:
> - The SiFive Level 2 Cache Controller is used to provide access to fast copies
> - of memory for masters in a Core Complex. The Level 2 Cache Controller also
> + The SiFive Composable Cache Controller is used to provide access to fast copies
> + of memory for masters in a Core Complex. The Composable Cache Controller also
> acts as directory-based coherency manager.
> All the properties in ePAPR/DeviceTree specification applies for this platform.
>
> @@ -27,6 +27,7 @@ select:
> enum:
> - sifive,fu540-c000-ccache
> - sifive,fu740-c000-ccache
> + - sifive,ccache0
Looks like Rob's bot had comments and I don't see a v2. Sorry if I'm
missing something.
Also: I'd guess that we only had the SOC-specific mappings on purpose.
It's kind of a grey area and I'm OK either way, but I'd definately
prefer the DT folks to get a chance to review these. My guess is that
they're not looking due to the bot comments, but sorry again if I've
missed it.
> required:
> - compatible
> @@ -37,6 +38,7 @@ properties:
> - enum:
> - sifive,fu540-c000-ccache
> - sifive,fu740-c000-ccache
> + - sifive,ccache0
> - const: cache
>
> cache-block-size:
next prev parent reply other threads:[~2022-10-07 2:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 6:21 [PATCH 0/3] Rename sifive L2 cache to sifive CCACHE Zong Li
2022-08-29 6:22 ` [PATCH 1/3] dt-bindings: sifive-ccache: rename SiFive L2 cache to composible cache Zong Li
2022-08-29 6:45 ` Conor.Dooley
2022-08-29 7:38 ` Zong Li
2022-08-29 18:42 ` Rob Herring
2022-08-30 2:57 ` Zong Li
2022-10-07 2:58 ` Palmer Dabbelt [this message]
2022-10-07 3:51 ` Zong Li
2022-08-29 6:22 ` [PATCH 2/3] soc: sifive: l2 cache: Rename " Zong Li
2022-08-29 7:05 ` Conor.Dooley
2022-08-29 8:40 ` Zong Li
2022-08-30 8:41 ` Conor.Dooley
2022-08-31 5:31 ` Zong Li
2022-08-30 8:18 ` Ben Dooks
2022-08-29 6:22 ` [PATCH 3/3] EDAC/sifive: use sifive_ccache instead of sifive_l2 Zong Li
2022-10-07 2:58 ` Palmer Dabbelt
2022-08-30 7:59 ` [PATCH 0/3] Rename sifive L2 cache to sifive CCACHE Ben Dooks
2022-08-31 8:23 ` Zong Li
2022-08-30 12:51 ` [RESEND PATCH] dt-bindings: sifive-ccache: fix cache level for l3 cache Ben Dooks
2022-08-30 12:56 ` Conor.Dooley
2022-08-30 12:58 ` Ben Dooks
2022-08-30 13:49 ` Conor.Dooley
2022-08-30 16:49 ` Ben Dooks
2022-08-30 17:08 ` Conor.Dooley
2022-08-31 5:17 ` Zong Li
2022-08-31 6:25 ` Conor.Dooley
2022-09-02 19:36 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-050016e5-0f50-4366-b4bd-98b4b36a56bb@palmer-ri-x1c9 \
--to=palmer@dabbelt.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=greentime.hu@sifive.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).