[PATCH] docs: Fix empty parallelism argument

[PATCH] docs: Fix empty parallelism argument

[Kees Cook]

When there was no parallelism (no top-level -j arg and a pre-1.7
sphinx-build), the argument passed would be empty ("") instead of just
being missing, which would (understandably) badly confuse sphinx-build.
Fix this by removing the quotes.

Reported-by: Rafael J. Wysocki <rafael@kernel.org>
Fixes: 51e46c7a4007 ("docs, parallelism: Rearrange how jobserver reservations are made")
Signed-off-by: Kees Cook <keescook@chromium.org>
---
 Documentation/sphinx/parallel-wrapper.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/sphinx/parallel-wrapper.sh b/Documentation/sphinx/parallel-wrapper.sh
index 7daf5133bdd3..e54c44ce117d 100644
--- a/Documentation/sphinx/parallel-wrapper.sh
+++ b/Documentation/sphinx/parallel-wrapper.sh
@@ -30,4 +30,4 @@ if [ -n "$parallel" ] ; then
 	parallel="-j$parallel"
 fi
 
-exec "$sphinx" "$parallel" "$@"
+exec "$sphinx" $parallel "$@"
-- 
2.20.1


-- 
Kees Cook

Re: [PATCH] docs: Fix empty parallelism argument

[Jonathan Corbet]

On Fri, 21 Feb 2020 16:02:39 -0800
Kees Cook <keescook@chromium.org> wrote:

> When there was no parallelism (no top-level -j arg and a pre-1.7
> sphinx-build), the argument passed would be empty ("") instead of just
> being missing, which would (understandably) badly confuse sphinx-build.
> Fix this by removing the quotes.
> 
> Reported-by: Rafael J. Wysocki <rafael@kernel.org>
> Fixes: 51e46c7a4007 ("docs, parallelism: Rearrange how jobserver reservations are made")
> Signed-off-by: Kees Cook <keescook@chromium.org>

Applied, thanks for fixing this.

jon