* [PATCH v1 1/8] docs: watchdog: codify ident.options as superset of possible status flags [not found] <20200611191750.28096-1-a.fatoum@pengutronix.de> @ 2020-06-11 19:17 ` Ahmad Fatoum 2020-06-30 20:49 ` Guenter Roeck 0 siblings, 1 reply; 2+ messages in thread From: Ahmad Fatoum @ 2020-06-11 19:17 UTC (permalink / raw) To: Wim Van Sebroeck, Guenter Roeck Cc: linux-watchdog, kernel, Ahmad Fatoum, Jonathan Corbet, linux-doc, linux-kernel The FIXME comment has been in-tree since the very first git commit. The described behavior has been since relied on by some userspace, e.g. the util-linux wdctl command and has been ignored by some kernelspace, like the f71808e_wdt driver. The functionality is useful to have to be able to differentiate between a driver that doesn't support WDIOF_CARDRESET and one that does, but hasn't had a watchdog reset, thus drop the FIXME to encourage drivers adopting this convention. Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> --- Documentation/watchdog/watchdog-api.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/watchdog/watchdog-api.rst b/Documentation/watchdog/watchdog-api.rst index c6c1e9fa9f73..800dcd7586f2 100644 --- a/Documentation/watchdog/watchdog-api.rst +++ b/Documentation/watchdog/watchdog-api.rst @@ -168,7 +168,7 @@ the fields returned in the ident struct are: the options field can have the following bits set, and describes what kind of information that the GET_STATUS and GET_BOOT_STATUS ioctls can -return. [FIXME -- Is this correct?] +return. ================ ========================= WDIOF_OVERHEAT Reset due to CPU overheat -- 2.27.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/8] docs: watchdog: codify ident.options as superset of possible status flags 2020-06-11 19:17 ` [PATCH v1 1/8] docs: watchdog: codify ident.options as superset of possible status flags Ahmad Fatoum @ 2020-06-30 20:49 ` Guenter Roeck 0 siblings, 0 replies; 2+ messages in thread From: Guenter Roeck @ 2020-06-30 20:49 UTC (permalink / raw) To: Ahmad Fatoum Cc: Wim Van Sebroeck, linux-watchdog, kernel, Jonathan Corbet, linux-doc, linux-kernel On Thu, Jun 11, 2020 at 09:17:42PM +0200, Ahmad Fatoum wrote: > The FIXME comment has been in-tree since the very first git commit. > The described behavior has been since relied on by some userspace, e.g. > the util-linux wdctl command and has been ignored by some kernelspace, > like the f71808e_wdt driver. > > The functionality is useful to have to be able to differentiate between a > driver that doesn't support WDIOF_CARDRESET and one that does, but hasn't > had a watchdog reset, thus drop the FIXME to encourage drivers adopting > this convention. > > Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > Documentation/watchdog/watchdog-api.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/watchdog/watchdog-api.rst b/Documentation/watchdog/watchdog-api.rst > index c6c1e9fa9f73..800dcd7586f2 100644 > --- a/Documentation/watchdog/watchdog-api.rst > +++ b/Documentation/watchdog/watchdog-api.rst > @@ -168,7 +168,7 @@ the fields returned in the ident struct are: > > the options field can have the following bits set, and describes what > kind of information that the GET_STATUS and GET_BOOT_STATUS ioctls can > -return. [FIXME -- Is this correct?] > +return. > > ================ ========================= > WDIOF_OVERHEAT Reset due to CPU overheat ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-30 20:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200611191750.28096-1-a.fatoum@pengutronix.de>
2020-06-11 19:17 ` [PATCH v1 1/8] docs: watchdog: codify ident.options as superset of possible status flags Ahmad Fatoum
2020-06-30 20:49 ` Guenter Roeck
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).