linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org
Subject: Re: [PATCH] documentation-file-ref-check: Make git check work for multiple working directories
Date: Thu, 3 Jun 2021 08:34:28 +0200	[thread overview]
Message-ID: <20210603083428.1b205131@coco.lan> (raw)
In-Reply-To: <20210603012806.331132-1-robh@kernel.org>

Em Wed,  2 Jun 2021 20:28:06 -0500
Rob Herring <robh@kernel.org> escreveu:

> With multiple git working directories, '.git' may also be a text file
> linking to the actual git tree instead of a directory.

Good catch! Never tested inside a git worktree, as I use a separate git
for docs patches due to a different [format] settings (due to a
different c/c list).

> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Tested-by: Mauro Carvalho Chehab <mchehab@kernel.org>

> ---
>  scripts/documentation-file-ref-check | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/documentation-file-ref-check b/scripts/documentation-file-ref-check
> index c71832b2312b..7187ea5e5149 100755
> --- a/scripts/documentation-file-ref-check
> +++ b/scripts/documentation-file-ref-check
> @@ -24,7 +24,7 @@ my $help = 0;
>  my $fix = 0;
>  my $warn = 0;
>  
> -if (! -d ".git") {
> +if (! -e ".git") {
>  	printf "Warning: can't check if file exists, as this is not a git tree\n";
>  	exit 0;
>  }



Thanks,
Mauro

  reply	other threads:[~2021-06-03  6:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03  1:28 [PATCH] documentation-file-ref-check: Make git check work for multiple working directories Rob Herring
2021-06-03  6:34 ` Mauro Carvalho Chehab [this message]
2021-06-04 17:21 ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210603083428.1b205131@coco.lan \
    --to=mchehab@kernel.org \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).