From: Hou Tao <houtao@huaweicloud.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>, linux-block@vger.kernel.org
Cc: Bart Van Assche <bvanassche@acm.org>, Jan Kara <jack@suse.cz>,
Jens Axboe <axboe@kernel.dk>,
cgroups@vger.kernel.org, Tejun Heo <tj@kernel.org>,
Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
houtao1@huawei.com
Subject: Re: [PATCH] blk-ioprio: Introduce promote-to-rt policy
Date: Thu, 2 Feb 2023 18:50:07 +0800 [thread overview]
Message-ID: <336ed542-6b73-0f69-a4ee-4119e73ddb1d@huaweicloud.com> (raw)
In-Reply-To: <Y9or5PkdXj/D94fR@debian.me>
Hi,
On 2/1/2023 5:07 PM, Bagas Sanjaya wrote:
> On Wed, Feb 01, 2023 at 12:52:27PM +0800, Hou Tao wrote:
>> The following numerical values are associated with the I/O priority policies:
>>
>> -+-------------+---+
>> -| no-change | 0 |
>> -+-------------+---+
>> -| none-to-rt | 1 |
>> -+-------------+---+
>> -| rt-to-be | 2 |
>> -+-------------+---+
>> -| all-to-idle | 3 |
>> -+-------------+---+
>> +
>> ++---------------+---------+-----+
>> +| policy | inst | num |
>> ++---------------+---------+-----+
>> +| no-change | demote | 0 |
>> ++---------------+---------+-----+
>> +| none-to-rt | demote | 1 |
>> ++---------------+---------+-----+
>> +| rt-to-be | demote | 2 |
>> ++---------------+---------+-----+
>> +| idle | demote | 3 |
>> ++---------------+---------+-----+
>> +| promote-to-rt | promote | 1 |
>> ++---------------+---------+-----+
>>
> The first row should have been header row:
>
> ---- >8 ----
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index e0b9f73ef62a9e..55f9b579716564 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -2048,7 +2048,7 @@ The following numerical values are associated with the I/O priority policies:
>
> +---------------+---------+-----+
> | policy | inst | num |
> -+---------------+---------+-----+
> ++===============+=========+=====+
> | no-change | demote | 0 |
> +---------------+---------+-----+
> | none-to-rt | demote | 1 |
>
>> @@ -2064,9 +2074,13 @@ The numerical value that corresponds to each I/O priority class is as follows:
>>
>> The algorithm to set the I/O priority class for a request is as follows:
>>
>> -- Translate the I/O priority class policy into a number.
>> -- Change the request I/O priority class into the maximum of the I/O priority
>> - class policy number and the numerical I/O priority class.
>> +-- Translate the I/O priority class policy into an instruction and a number
>> +-- If the instruction is demotion, change the request I/O priority class
>> +- into the maximum of the I/O priority class policy number and the numerical
>> +- I/O priority class.
>> +-- If the instruction is promotion, change the request I/O priority class
>> +- into the minimum of the I/O priority class policy number and the numerical
>> +- I/O priority class.
>>
> Remove the excessive bullet list marker or the list above become paragraph
> instead:
>
> ---- >8 ----
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 55f9b579716564..c3f16386c47bdf 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -2074,12 +2074,12 @@ The numerical value that corresponds to each I/O priority class is as follows:
>
> The algorithm to set the I/O priority class for a request is as follows:
>
> --- Translate the I/O priority class policy into an instruction and a number
> --- If the instruction is demotion, change the request I/O priority class
> -- into the maximum of the I/O priority class policy number and the numerical
> -- I/O priority class.
> --- If the instruction is promotion, change the request I/O priority class
> -- into the minimum of the I/O priority class policy number and the numerical
> +- Translate the I/O priority class policy into an instruction-number pair.
> +- If the instruction is demotion, change the request I/O priority class
> + into the maximum of the I/O priority class policy number and the numerical
> + I/O priority class.
> +- If the instruction is promotion, change the request I/O priority class
> + into the minimum of the I/O priority class policy number and the numerical
> - I/O priority class.
>
> PID
>
> Thanks.
Thanks for your comments. Will fix in v2.
>
next prev parent reply other threads:[~2023-02-02 11:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 4:52 [PATCH] blk-ioprio: Introduce promote-to-rt policy Hou Tao
2023-02-01 9:07 ` Bagas Sanjaya
2023-02-02 10:50 ` Hou Tao [this message]
2023-02-01 17:33 ` Bart Van Assche
2023-02-02 11:09 ` Hou Tao
2023-02-02 18:05 ` Bart Van Assche
2023-02-03 1:48 ` Hou Tao
2023-02-03 19:45 ` Bart Van Assche
2023-02-05 7:04 ` Hou Tao
2023-02-08 13:43 ` Jan Kara
2023-02-08 17:53 ` Bart Van Assche
2023-02-09 8:56 ` Jan Kara
2023-02-09 19:09 ` Bart Van Assche
2023-02-10 10:12 ` Jan Kara
2023-02-13 12:51 ` Hou Tao
2023-02-13 17:10 ` Bart Van Assche
2023-02-14 8:52 ` Jan Kara
2023-02-03 19:51 ` Bart Van Assche
2023-02-05 7:17 ` Hou Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=336ed542-6b73-0f69-a4ee-4119e73ddb1d@huaweicloud.com \
--to=houtao@huaweicloud.com \
--cc=axboe@kernel.dk \
--cc=bagasdotme@gmail.com \
--cc=bvanassche@acm.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=hannes@cmpxchg.org \
--cc=houtao1@huawei.com \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).