From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Beata Michalska <beata.michalska@arm.com>
Cc: Valentin Schneider <valentin.schneider@arm.com>,
linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, corbet@lwn.net,
rdunlap@infradead.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v5 2/3] sched/topology: Rework CPU capacity asymmetry detection
Date: Wed, 2 Jun 2021 19:17:12 +0200 [thread overview]
Message-ID: <4f43a9a8-b64e-bb47-b3c1-f51165f40249@arm.com> (raw)
In-Reply-To: <20210527170729.GA20994@e120325.cambridge.arm.com>
On 27/05/2021 19:07, Beata Michalska wrote:
> On Thu, May 27, 2021 at 05:08:42PM +0200, Dietmar Eggemann wrote:
>> On 26/05/2021 23:40, Beata Michalska wrote:
>>> On Wed, May 26, 2021 at 08:17:41PM +0200, Dietmar Eggemann wrote:
>>>> On 26/05/2021 14:51, Beata Michalska wrote:
>>>>> On Wed, May 26, 2021 at 01:15:46PM +0100, Beata Michalska wrote:
>>>>>> On Wed, May 26, 2021 at 11:52:25AM +0200, Dietmar Eggemann wrote:
>>>>>>> On 25/05/2021 12:29, Beata Michalska wrote:
>>>>>>>> On Tue, May 25, 2021 at 10:53:07AM +0100, Valentin Schneider wrote:
>>>>>>>>> On 24/05/21 23:55, Beata Michalska wrote:
>>>>>>>>>> On Mon, May 24, 2021 at 07:01:04PM +0100, Valentin Schneider wrote:
>>>>>>>>>>> On 24/05/21 11:16, Beata Michalska wrote:
[...]
>>> We could possibly add a warning (like in EAS) if the asymmetry is detected
>>> for SMT which would give some indication that there is smth ... wrong ?
>>
>> Maybe, in case you find an easy way to detect this.
>>
>> But the issue already exists today. Not with the topology mentioned
>> above but in case we slightly change it to:
>>
>> cpus = { ([446 1024] [871 1024] [446 1024] ) ([1024 1024]) }
>> ^^^^
>> so that we have a 1024 CPU in the lowest sd for each CPU, we would get
>> SD_ASYM_CPUCAPACITY on SMT.
> The asymmetry capacity flags are being set on a sched domain level, so
> we could use the SD_SHARE_CPUCAPACITY|SD_SHARE_PKG_RESOURCES (cpu_smt_flags)
> flags to determine if having asymmetry is valid or not ? If this is enough
> this could be handled by the classify function?
Or maybe something directly in sd_init(), like the WARN_ONCE() which triggers
if somebody wants to sneak in a ~topology flag via a
sched_domain_topology_level table?
IMHO checking `SD_SHARE_CPUCAPACITY | SD_ASYM_CPUCAPACITY` will be sufficient
here.
diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index 62d412013df8..77b73abbb9a4 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -1561,6 +1561,11 @@ sd_init(struct sched_domain_topology_level *tl,
sd_id = cpumask_first(sched_domain_span(sd));
sd->flags |= asym_cpu_capacity_classify(sd, cpu_map);
+
+ WARN_ONCE((sd->flags & (SD_SHARE_CPUCAPACITY | SD_ASYM_CPUCAPACITY)) ==
+ (SD_SHARE_CPUCAPACITY | SD_ASYM_CPUCAPACITY),
+ "CPU capacity asymmetry not supported on SMT\n");
+
/*
* Convert topological properties into behaviour.
*/
In case we can agree on something simple here I guess you can incorporate it into v7.
next prev parent reply other threads:[~2021-06-02 17:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 10:16 [PATCH v5 0/3] Rework CPU capacity asymmetry detection Beata Michalska
2021-05-24 10:16 ` [PATCH v5 1/3] sched/core: Introduce SD_ASYM_CPUCAPACITY_FULL sched_domain flag Beata Michalska
2021-05-24 10:16 ` [PATCH v5 2/3] sched/topology: Rework CPU capacity asymmetry detection Beata Michalska
2021-05-24 18:01 ` Valentin Schneider
2021-05-24 22:55 ` Beata Michalska
2021-05-24 23:19 ` Beata Michalska
2021-05-25 9:53 ` Valentin Schneider
2021-05-25 10:29 ` Beata Michalska
2021-05-26 9:52 ` Dietmar Eggemann
2021-05-26 12:15 ` Beata Michalska
2021-05-26 12:51 ` Beata Michalska
2021-05-26 18:17 ` Dietmar Eggemann
2021-05-26 21:40 ` Beata Michalska
2021-05-27 15:08 ` Dietmar Eggemann
2021-05-27 17:07 ` Beata Michalska
2021-06-02 17:17 ` Dietmar Eggemann [this message]
2021-06-02 19:48 ` Beata Michalska
2021-06-03 9:09 ` Dietmar Eggemann
2021-06-03 9:24 ` Beata Michalska
2021-05-26 18:17 ` Dietmar Eggemann
2021-05-26 21:43 ` Beata Michalska
2021-05-27 7:03 ` Peter Zijlstra
2021-05-27 12:22 ` Dietmar Eggemann
2021-05-27 12:32 ` Beata Michalska
2021-05-25 8:25 ` Dietmar Eggemann
2021-05-25 9:30 ` Beata Michalska
2021-05-25 11:59 ` Dietmar Eggemann
2021-05-25 14:04 ` Beata Michalska
2021-05-24 10:16 ` [PATCH v5 3/3] sched/doc: Update the CPU capacity asymmetry bits Beata Michalska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f43a9a8-b64e-bb47-b3c1-f51165f40249@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=beata.michalska@arm.com \
--cc=corbet@lwn.net \
--cc=juri.lelli@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).