* [RFC PATCH] ceph: fix description of some mount options
@ 2020-02-11 15:31 xiubli
2020-02-11 16:48 ` Jeff Layton
0 siblings, 1 reply; 3+ messages in thread
From: xiubli @ 2020-02-11 15:31 UTC (permalink / raw)
To: jlayton, idryomov
Cc: sage, zyan, pdonnell, ceph-devel, linux-doc, corbet, Xiubo Li
From: Xiubo Li <xiubli@redhat.com>
Based on the latest code, the default value for wsize/rsize is
64MB and the default value for the mount_timeout is 60 seconds.
Signed-off-by: Xiubo Li <xiubli@redhat.com>
---
Checked the history of the code, I am a little confused about the
default values for wsize/rsize, there never been 16MB as the default,
and for the mount_timeout, never seen 30 as default.
So did I miss something important about this ?
Documentation/filesystems/ceph.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/filesystems/ceph.txt b/Documentation/filesystems/ceph.txt
index b19b6a03f91c..92ffc9b3b018 100644
--- a/Documentation/filesystems/ceph.txt
+++ b/Documentation/filesystems/ceph.txt
@@ -103,17 +103,17 @@ Mount Options
address its connection to the monitor originates from.
wsize=X
- Specify the maximum write size in bytes. Default: 16 MB.
+ Specify the maximum write size in bytes. Default: 64 MB.
rsize=X
- Specify the maximum read size in bytes. Default: 16 MB.
+ Specify the maximum read size in bytes. Default: 64 MB.
rasize=X
Specify the maximum readahead size in bytes. Default: 8 MB.
mount_timeout=X
Specify the timeout value for mount (in seconds), in the case
- of a non-responsive Ceph file system. The default is 30
+ of a non-responsive Ceph file system. The default is 60
seconds.
caps_max=X
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] ceph: fix description of some mount options
2020-02-11 15:31 [RFC PATCH] ceph: fix description of some mount options xiubli
@ 2020-02-11 16:48 ` Jeff Layton
2020-02-12 10:59 ` Xiubo Li
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Layton @ 2020-02-11 16:48 UTC (permalink / raw)
To: xiubli, idryomov; +Cc: sage, zyan, pdonnell, ceph-devel, linux-doc, corbet
On Tue, 2020-02-11 at 10:31 -0500, xiubli@redhat.com wrote:
> From: Xiubo Li <xiubli@redhat.com>
>
> Based on the latest code, the default value for wsize/rsize is
> 64MB and the default value for the mount_timeout is 60 seconds.
>
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> ---
>
> Checked the history of the code, I am a little confused about the
> default values for wsize/rsize, there never been 16MB as the default,
> and for the mount_timeout, never seen 30 as default.
>
> So did I miss something important about this ?
>
It looks like the default rsize/wsize were 16M prior to 94e6992bb560b.
It then went to 32 and then 64 a little while afterward. I don't see
where the mount_timeout was ever 30s though.
Merged into testing branch since this seems obviously correct.
>
> Documentation/filesystems/ceph.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/filesystems/ceph.txt b/Documentation/filesystems/ceph.txt
> index b19b6a03f91c..92ffc9b3b018 100644
> --- a/Documentation/filesystems/ceph.txt
> +++ b/Documentation/filesystems/ceph.txt
> @@ -103,17 +103,17 @@ Mount Options
> address its connection to the monitor originates from.
>
> wsize=X
> - Specify the maximum write size in bytes. Default: 16 MB.
> + Specify the maximum write size in bytes. Default: 64 MB.
>
> rsize=X
> - Specify the maximum read size in bytes. Default: 16 MB.
> + Specify the maximum read size in bytes. Default: 64 MB.
>
> rasize=X
> Specify the maximum readahead size in bytes. Default: 8 MB.
>
> mount_timeout=X
> Specify the timeout value for mount (in seconds), in the case
> - of a non-responsive Ceph file system. The default is 30
> + of a non-responsive Ceph file system. The default is 60
> seconds.
>
> caps_max=X
--
Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] ceph: fix description of some mount options
2020-02-11 16:48 ` Jeff Layton
@ 2020-02-12 10:59 ` Xiubo Li
0 siblings, 0 replies; 3+ messages in thread
From: Xiubo Li @ 2020-02-12 10:59 UTC (permalink / raw)
To: Jeff Layton, idryomov; +Cc: sage, zyan, pdonnell, ceph-devel, linux-doc, corbet
On 2020/2/12 0:48, Jeff Layton wrote:
> On Tue, 2020-02-11 at 10:31 -0500, xiubli@redhat.com wrote:
>> From: Xiubo Li <xiubli@redhat.com>
>>
>> Based on the latest code, the default value for wsize/rsize is
>> 64MB and the default value for the mount_timeout is 60 seconds.
>>
>> Signed-off-by: Xiubo Li <xiubli@redhat.com>
>> ---
>>
>> Checked the history of the code, I am a little confused about the
>> default values for wsize/rsize, there never been 16MB as the default,
>> and for the mount_timeout, never seen 30 as default.
>>
>> So did I miss something important about this ?
>>
> It looks like the default rsize/wsize were 16M prior to 94e6992bb560b.
> It then went to 32 and then 64 a little while afterward.
Yeah, it is.
Thanks,
BRs
> I don't see
> where the mount_timeout was ever 30s though.
>
> Merged into testing branch since this seems obviously correct.
>
>> Documentation/filesystems/ceph.txt | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/filesystems/ceph.txt b/Documentation/filesystems/ceph.txt
>> index b19b6a03f91c..92ffc9b3b018 100644
>> --- a/Documentation/filesystems/ceph.txt
>> +++ b/Documentation/filesystems/ceph.txt
>> @@ -103,17 +103,17 @@ Mount Options
>> address its connection to the monitor originates from.
>>
>> wsize=X
>> - Specify the maximum write size in bytes. Default: 16 MB.
>> + Specify the maximum write size in bytes. Default: 64 MB.
>>
>> rsize=X
>> - Specify the maximum read size in bytes. Default: 16 MB.
>> + Specify the maximum read size in bytes. Default: 64 MB.
>>
>> rasize=X
>> Specify the maximum readahead size in bytes. Default: 8 MB.
>>
>> mount_timeout=X
>> Specify the timeout value for mount (in seconds), in the case
>> - of a non-responsive Ceph file system. The default is 30
>> + of a non-responsive Ceph file system. The default is 60
>> seconds.
>>
>> caps_max=X
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-12 10:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-11 15:31 [RFC PATCH] ceph: fix description of some mount options xiubli
2020-02-11 16:48 ` Jeff Layton
2020-02-12 10:59 ` Xiubo Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).