* [PATCH bpf-next] bpf: Document the pahole release info related to libbpf in bpf_devel_QA.rst
@ 2021-04-23 1:23 Tiezhu Yang
2021-04-23 4:12 ` Yonghong Song
0 siblings, 1 reply; 4+ messages in thread
From: Tiezhu Yang @ 2021-04-23 1:23 UTC (permalink / raw)
To: Jonathan Corbet, Alexei Starovoitov, Daniel Borkmann,
Andrii Nakryiko, Martin KaFai Lau, Song Liu, Yonghong Song,
John Fastabend, KP Singh
Cc: Arnaldo Carvalho de Melo, linux-doc, netdev, bpf, linux-kernel,
Xuefeng Li
pahole starts to use libbpf definitions and APIs since v1.13 after the
commit 21507cd3e97b ("pahole: add libbpf as submodule under lib/bpf").
It works well with the git repository because the libbpf submodule will
use "git submodule update --init --recursive" to update.
Unfortunately, the default github release source code does not contain
libbpf submodule source code and this will cause build issues, the tarball
from https://git.kernel.org/pub/scm/devel/pahole/pahole.git/ is same with
github, you can get the source tarball with corresponding libbpf submodule
codes from
https://fedorapeople.org/~acme/dwarves
This change documents the above issues to give more information so that
we can get the tarball from the right place, early discussion is here:
https://lore.kernel.org/bpf/2de4aad5-fa9e-1c39-3c92-9bb9229d0966@loongson.cn/
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
Documentation/bpf/bpf_devel_QA.rst | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/Documentation/bpf/bpf_devel_QA.rst b/Documentation/bpf/bpf_devel_QA.rst
index d05e67e..253496a 100644
--- a/Documentation/bpf/bpf_devel_QA.rst
+++ b/Documentation/bpf/bpf_devel_QA.rst
@@ -449,6 +449,19 @@ from source at
https://github.com/acmel/dwarves
+pahole starts to use libbpf definitions and APIs since v1.13 after the
+commit 21507cd3e97b ("pahole: add libbpf as submodule under lib/bpf").
+It works well with the git repository because the libbpf submodule will
+use "git submodule update --init --recursive" to update.
+
+Unfortunately, the default github release source code does not contain
+libbpf submodule source code and this will cause build issues, the tarball
+from https://git.kernel.org/pub/scm/devel/pahole/pahole.git/ is same with
+github, you can get the source tarball with corresponding libbpf submodule
+codes from
+
+https://fedorapeople.org/~acme/dwarves
+
Some distros have pahole version 1.16 packaged already, e.g.
Fedora, Gentoo.
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH bpf-next] bpf: Document the pahole release info related to libbpf in bpf_devel_QA.rst
2021-04-23 1:23 [PATCH bpf-next] bpf: Document the pahole release info related to libbpf in bpf_devel_QA.rst Tiezhu Yang
@ 2021-04-23 4:12 ` Yonghong Song
2021-04-23 18:20 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 4+ messages in thread
From: Yonghong Song @ 2021-04-23 4:12 UTC (permalink / raw)
To: Tiezhu Yang, Jonathan Corbet, Alexei Starovoitov,
Daniel Borkmann, Andrii Nakryiko, Martin KaFai Lau, Song Liu,
John Fastabend, KP Singh, Arnaldo Carvalho de Melo
Cc: linux-doc, netdev, bpf, linux-kernel, Xuefeng Li
On 4/22/21 6:23 PM, Tiezhu Yang wrote:
> pahole starts to use libbpf definitions and APIs since v1.13 after the
> commit 21507cd3e97b ("pahole: add libbpf as submodule under lib/bpf").
> It works well with the git repository because the libbpf submodule will
> use "git submodule update --init --recursive" to update.
>
> Unfortunately, the default github release source code does not contain
> libbpf submodule source code and this will cause build issues, the tarball
> from https://git.kernel.org/pub/scm/devel/pahole/pahole.git/ is same with
> github, you can get the source tarball with corresponding libbpf submodule
> codes from
>
> https://fedorapeople.org/~acme/dwarves
>
> This change documents the above issues to give more information so that
> we can get the tarball from the right place, early discussion is here:
>
> https://lore.kernel.org/bpf/2de4aad5-fa9e-1c39-3c92-9bb9229d0966@loongson.cn/
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> Documentation/bpf/bpf_devel_QA.rst | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/bpf/bpf_devel_QA.rst b/Documentation/bpf/bpf_devel_QA.rst
> index d05e67e..253496a 100644
> --- a/Documentation/bpf/bpf_devel_QA.rst
> +++ b/Documentation/bpf/bpf_devel_QA.rst
> @@ -449,6 +449,19 @@ from source at
>
> https://github.com/acmel/dwarves
>
> +pahole starts to use libbpf definitions and APIs since v1.13 after the
> +commit 21507cd3e97b ("pahole: add libbpf as submodule under lib/bpf").
> +It works well with the git repository because the libbpf submodule will
> +use "git submodule update --init --recursive" to update.
> +
> +Unfortunately, the default github release source code does not contain
> +libbpf submodule source code and this will cause build issues, the tarball
> +from https://git.kernel.org/pub/scm/devel/pahole/pahole.git/ is same with
> +github, you can get the source tarball with corresponding libbpf submodule
> +codes from
> +
> +https://fedorapeople.org/~acme/dwarves
> +
Arnaldo, could you take a look at this patch? Thanks!
> Some distros have pahole version 1.16 packaged already, e.g.
> Fedora, Gentoo.
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH bpf-next] bpf: Document the pahole release info related to libbpf in bpf_devel_QA.rst
2021-04-23 4:12 ` Yonghong Song
@ 2021-04-23 18:20 ` Arnaldo Carvalho de Melo
2021-04-24 0:12 ` Alexei Starovoitov
0 siblings, 1 reply; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-04-23 18:20 UTC (permalink / raw)
To: Yonghong Song
Cc: Tiezhu Yang, Jonathan Corbet, Alexei Starovoitov,
Daniel Borkmann, Andrii Nakryiko, Martin KaFai Lau, Song Liu,
John Fastabend, KP Singh, Arnaldo Carvalho de Melo, linux-doc,
netdev, bpf, linux-kernel, Xuefeng Li
Em Thu, Apr 22, 2021 at 09:12:19PM -0700, Yonghong Song escreveu:
>
>
> On 4/22/21 6:23 PM, Tiezhu Yang wrote:
> > pahole starts to use libbpf definitions and APIs since v1.13 after the
> > commit 21507cd3e97b ("pahole: add libbpf as submodule under lib/bpf").
> > It works well with the git repository because the libbpf submodule will
> > use "git submodule update --init --recursive" to update.
> >
> > Unfortunately, the default github release source code does not contain
> > libbpf submodule source code and this will cause build issues, the tarball
> > from https://git.kernel.org/pub/scm/devel/pahole/pahole.git/ is same with
> > github, you can get the source tarball with corresponding libbpf submodule
> > codes from
> >
> > https://fedorapeople.org/~acme/dwarves
> >
> > This change documents the above issues to give more information so that
> > we can get the tarball from the right place, early discussion is here:
> >
> > https://lore.kernel.org/bpf/2de4aad5-fa9e-1c39-3c92-9bb9229d0966@loongson.cn/
> >
> > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> > ---
> > Documentation/bpf/bpf_devel_QA.rst | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/Documentation/bpf/bpf_devel_QA.rst b/Documentation/bpf/bpf_devel_QA.rst
> > index d05e67e..253496a 100644
> > --- a/Documentation/bpf/bpf_devel_QA.rst
> > +++ b/Documentation/bpf/bpf_devel_QA.rst
> > @@ -449,6 +449,19 @@ from source at
> > https://github.com/acmel/dwarves
> > +pahole starts to use libbpf definitions and APIs since v1.13 after the
> > +commit 21507cd3e97b ("pahole: add libbpf as submodule under lib/bpf").
> > +It works well with the git repository because the libbpf submodule will
> > +use "git submodule update --init --recursive" to update.
> > +
> > +Unfortunately, the default github release source code does not contain
> > +libbpf submodule source code and this will cause build issues, the tarball
> > +from https://git.kernel.org/pub/scm/devel/pahole/pahole.git/ is same with
> > +github, you can get the source tarball with corresponding libbpf submodule
> > +codes from
> > +
> > +https://fedorapeople.org/~acme/dwarves
> > +
>
> Arnaldo, could you take a look at this patch? Thanks!
Sure, he documented it as I expected from a previous interaction about
this. Would be good to add a paragraph stating how to grab libbpf and
graft it even on a tarball not containing it tho.
Bonus points if the cmake files gets changed in a way that this gets
notified to the user in the error message.
But these suggestions can come in another patch, for this I can give my:
Reviewed-by: Arnaldo Carvalho de Melo <acme@redhat.com>
- Arnaldo
> > Some distros have pahole version 1.16 packaged already, e.g.
> > Fedora, Gentoo.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH bpf-next] bpf: Document the pahole release info related to libbpf in bpf_devel_QA.rst
2021-04-23 18:20 ` Arnaldo Carvalho de Melo
@ 2021-04-24 0:12 ` Alexei Starovoitov
0 siblings, 0 replies; 4+ messages in thread
From: Alexei Starovoitov @ 2021-04-24 0:12 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Yonghong Song, Tiezhu Yang, Jonathan Corbet, Alexei Starovoitov,
Daniel Borkmann, Andrii Nakryiko, Martin KaFai Lau, Song Liu,
John Fastabend, KP Singh, Arnaldo Carvalho de Melo,
open list:DOCUMENTATION, Network Development, bpf, LKML,
Xuefeng Li
On Fri, Apr 23, 2021 at 11:20 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Thu, Apr 22, 2021 at 09:12:19PM -0700, Yonghong Song escreveu:
> >
> >
> > On 4/22/21 6:23 PM, Tiezhu Yang wrote:
> > > pahole starts to use libbpf definitions and APIs since v1.13 after the
> > > commit 21507cd3e97b ("pahole: add libbpf as submodule under lib/bpf").
> > > It works well with the git repository because the libbpf submodule will
> > > use "git submodule update --init --recursive" to update.
> > >
> > > Unfortunately, the default github release source code does not contain
> > > libbpf submodule source code and this will cause build issues, the tarball
> > > from https://git.kernel.org/pub/scm/devel/pahole/pahole.git/ is same with
> > > github, you can get the source tarball with corresponding libbpf submodule
> > > codes from
> > >
> > > https://fedorapeople.org/~acme/dwarves
> > >
> > > This change documents the above issues to give more information so that
> > > we can get the tarball from the right place, early discussion is here:
> > >
> > > https://lore.kernel.org/bpf/2de4aad5-fa9e-1c39-3c92-9bb9229d0966@loongson.cn/
> > >
> > > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> > > ---
> > > Documentation/bpf/bpf_devel_QA.rst | 13 +++++++++++++
> > > 1 file changed, 13 insertions(+)
> > >
> > > diff --git a/Documentation/bpf/bpf_devel_QA.rst b/Documentation/bpf/bpf_devel_QA.rst
> > > index d05e67e..253496a 100644
> > > --- a/Documentation/bpf/bpf_devel_QA.rst
> > > +++ b/Documentation/bpf/bpf_devel_QA.rst
> > > @@ -449,6 +449,19 @@ from source at
> > > https://github.com/acmel/dwarves
> > > +pahole starts to use libbpf definitions and APIs since v1.13 after the
> > > +commit 21507cd3e97b ("pahole: add libbpf as submodule under lib/bpf").
> > > +It works well with the git repository because the libbpf submodule will
> > > +use "git submodule update --init --recursive" to update.
> > > +
> > > +Unfortunately, the default github release source code does not contain
> > > +libbpf submodule source code and this will cause build issues, the tarball
> > > +from https://git.kernel.org/pub/scm/devel/pahole/pahole.git/ is same with
> > > +github, you can get the source tarball with corresponding libbpf submodule
> > > +codes from
> > > +
> > > +https://fedorapeople.org/~acme/dwarves
> > > +
> >
> > Arnaldo, could you take a look at this patch? Thanks!
>
> Sure, he documented it as I expected from a previous interaction about
> this. Would be good to add a paragraph stating how to grab libbpf and
> graft it even on a tarball not containing it tho.
>
> Bonus points if the cmake files gets changed in a way that this gets
> notified to the user in the error message.
>
> But these suggestions can come in another patch, for this I can give my:
>
> Reviewed-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Applied. Thanks everyone.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-24 0:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-23 1:23 [PATCH bpf-next] bpf: Document the pahole release info related to libbpf in bpf_devel_QA.rst Tiezhu Yang
2021-04-23 4:12 ` Yonghong Song
2021-04-23 18:20 ` Arnaldo Carvalho de Melo
2021-04-24 0:12 ` Alexei Starovoitov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).