From: Donald Hunter <donald.hunter@gmail.com>
To: Vegard Nossum <vegard.nossum@oracle.com>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Akira Yokosawa <akiyks@gmail.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Randy Dunlap <rdunlap@infradead.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] docs: drop the version constraints for sphinx and dependencies
Date: Mon, 18 Mar 2024 17:10:40 +0000 [thread overview]
Message-ID: <CAD4GDZzjc6=-Gzw23tRgCDE7=AxsenXqpD+qnh6gj1+MYYU2fA@mail.gmail.com> (raw)
In-Reply-To: <41f28393-0211-4448-8add-ad3c55d02210@oracle.com>
On Mon, 18 Mar 2024 at 16:54, Vegard Nossum <vegard.nossum@oracle.com> wrote:
>
> > % time make htmldocs
> > ...
> > real 9m0.533s
> > user 15m38.397s
> > sys 1m0.907s
>
> Was this running 'make cleandocs' (or otherwise removing the output
> directory) in between? Sphinx is known to be slower if you already have
Yes, times were after 'make cleandocs'.
> an output directory with existing-but-obsolete data, I believe this is
> the case even when switching from one Sphinx version to another. Akira
> also wrote about the 7.x performance:
>
> https://lore.kernel.org/linux-doc/6e4b66fe-dbb3-4149-ac7e-8ae333d6fc9d@gmail.com/
Having looked at the Sphinx code, it doesn't surprise me that
incremental builds can have worse performance. There's probably going
to be some speedups to be found when we go looking for them.
> > I have an experimental fix that uses a dict for lookups. With the fix, I
> > consistently get times in the sub 5 minute range:
>
> Fantastic!
>
> There is a github issue for the C++ domain but I believe it's the same
> issue for both C and C++ domains:
>
> https://github.com/sphinx-doc/sphinx/issues/10966
Ahh, I looked for an issue for the C domain but did not see one. I
didn't think to check for issues with the C++ domain, even though the
code for the C domain has been copied from there.
next prev parent reply other threads:[~2024-03-18 17:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 14:18 [PATCH v2] docs: drop the version constraints for sphinx and dependencies Lukas Bulwahn
2024-03-03 15:17 ` Jonathan Corbet
2024-03-18 16:44 ` Donald Hunter
2024-03-18 16:54 ` Vegard Nossum
2024-03-18 17:10 ` Donald Hunter [this message]
2024-03-19 17:59 ` Donald Hunter
2024-03-21 16:56 ` Donald Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD4GDZzjc6=-Gzw23tRgCDE7=AxsenXqpD+qnh6gj1+MYYU2fA@mail.gmail.com' \
--to=donald.hunter@gmail.com \
--cc=akiyks@gmail.com \
--cc=corbet@lwn.net \
--cc=jani.nikula@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=mchehab@kernel.org \
--cc=rdunlap@infradead.org \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).