* [RESEND PATCH v5 0/2] add support for PON GEN3 device
@ 2022-09-09 20:42 Anjelique Melendez
2022-09-09 20:42 ` [RESEND PATCH v5 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible "qcom,pmk8350-pon" Anjelique Melendez
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Anjelique Melendez @ 2022-09-09 20:42 UTC (permalink / raw)
To: corbet, sre, robh+dt, agross, andersson
Cc: krzysztof.kozlowski+dt, vkoul, linux-doc, linux-pm, devicetree,
linux-arm-msm, linux-kernel, quic_collinsd, Anjelique Melendez
Resent with fixed path for dt-bindings.
Changes from v4:
- Updated commit message for patch 1/2
Changes from v3:
- Addressed Krysztof's comments on patch 1/2
- Added missing minItems/maxItems
- Merged if statments with same constraints together
- Removed description from "reg-names"
Changes from v2:
- Added new "qcom,pmk8350-pon" compatible string as per Krysztof's
advice
- Updated dt logic to use comptaible strings to decide constraints
as per Krysztof's comment
- Added new patch (v3 2/2) to support new compatible string
Changes from v1:
- Updated path which was missing Documentation/devicetree prefix
- Updated CC list
New patch series to separate this patch from applied patches.
Comments from original patch can be found
https://lore.kernel.org/linux-arm-msm/27515993-18f3-8891-4835-9b6a8d7f86b0@quicinc.com/
David Collins (1):
dt-bindings: power: reset: qcom-pon: Add new compatible
"qcom,pmk8350-pon"
Anjelique Melendez (1):
power: reset: qcom-pon: add support for qcom,pmk8350-pon compatible string
Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 50 +++++++++++++++++++++++++++---
drivers/power/reset/qcom-pon.c | 1 +
2 file changed, 47 insertions(+), 4 deletions(-)
--
2.35.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [RESEND PATCH v5 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible "qcom,pmk8350-pon"
2022-09-09 20:42 [RESEND PATCH v5 0/2] add support for PON GEN3 device Anjelique Melendez
@ 2022-09-09 20:42 ` Anjelique Melendez
2022-09-10 7:57 ` Krzysztof Kozlowski
2022-09-12 4:33 ` Vinod Koul
2022-09-09 20:42 ` [RESEND PATCH v5 2/2] power: reset: qcom-pon: add support for qcom,pmk8350-pon compatible string Anjelique Melendez
2022-09-11 12:18 ` [RESEND PATCH v5 0/2] add support for PON GEN3 device Sebastian Reichel
2 siblings, 2 replies; 8+ messages in thread
From: Anjelique Melendez @ 2022-09-09 20:42 UTC (permalink / raw)
To: corbet, sre, robh+dt, agross, andersson
Cc: krzysztof.kozlowski+dt, vkoul, linux-doc, linux-pm, devicetree,
linux-arm-msm, linux-kernel, quic_collinsd, Anjelique Melendez
From: David Collins <quic_collinsd@quicinc.com>
Add a new compatible string "qcom,pmk8350-pon" for GEN3 PMIC PON
peripherals and update "reg" property.
Also, Add an optional "reg-names" property to differentiate between
GEN1/GEN2 and GEN3 peripherals. GEN1/GEN2 peripherals only need one
register address to be specified (e.g. "pon") whereas GEN3 peripherals
can have two register addresses specified ("hlos", "pbs").
Signed-off-by: David Collins <quic_collinsd@quicinc.com>
Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com>
---
Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 50 +++++++++++++++++++++++++++---
1 file changed, 46 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
index 353f155d..d7b6b875 100644
--- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
+++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
@@ -15,18 +15,27 @@ description: |
This DT node has pwrkey and resin as sub nodes.
-allOf:
- - $ref: reboot-mode.yaml#
-
properties:
compatible:
enum:
- qcom,pm8916-pon
- qcom,pms405-pon
- qcom,pm8998-pon
+ - qcom,pmk8350-pon
reg:
- maxItems: 1
+ description: |
+ Specifies the SPMI base address for the PON (power-on) peripheral. For
+ PMICs that have the PON peripheral (GEN3) split into PON_HLOS and PON_PBS
+ (e.g. PMK8350), this can hold addresses of both PON_HLOS and PON_PBS
+ peripherals. In that case, the PON_PBS address needs to be specified to
+ facilitate software debouncing on some PMIC.
+ minItems: 1
+ maxItems: 2
+
+ reg-names:
+ minItems: 1
+ maxItems: 2
pwrkey:
type: object
@@ -42,6 +51,39 @@ required:
unevaluatedProperties: false
+allOf:
+ - $ref: reboot-mode.yaml#
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,pm8916-pon
+ - qcom,pms405-pon
+ - qcom,pm8998-pon
+ then:
+ properties:
+ reg:
+ maxItems: 1
+ reg-names:
+ items:
+ - const: pon
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: qcom,pmk8350-pon
+ then:
+ properties:
+ reg:
+ minItems: 1
+ maxItems: 2
+ reg-names:
+ minItems: 1
+ items:
+ - const: hlos
+ - const: pbs
+
examples:
- |
#include <dt-bindings/interrupt-controller/irq.h>
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [RESEND PATCH v5 2/2] power: reset: qcom-pon: add support for qcom,pmk8350-pon compatible string
2022-09-09 20:42 [RESEND PATCH v5 0/2] add support for PON GEN3 device Anjelique Melendez
2022-09-09 20:42 ` [RESEND PATCH v5 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible "qcom,pmk8350-pon" Anjelique Melendez
@ 2022-09-09 20:42 ` Anjelique Melendez
2022-09-10 7:57 ` Krzysztof Kozlowski
2022-09-12 4:33 ` Vinod Koul
2022-09-11 12:18 ` [RESEND PATCH v5 0/2] add support for PON GEN3 device Sebastian Reichel
2 siblings, 2 replies; 8+ messages in thread
From: Anjelique Melendez @ 2022-09-09 20:42 UTC (permalink / raw)
To: corbet, sre, robh+dt, agross, andersson
Cc: krzysztof.kozlowski+dt, vkoul, linux-doc, linux-pm, devicetree,
linux-arm-msm, linux-kernel, quic_collinsd, Anjelique Melendez
Add support for the new "qcom,pmk8350-pon" comptaible string.
Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com>
---
drivers/power/reset/qcom-pon.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c
index 4a688741a88a..16bc01738be9 100644
--- a/drivers/power/reset/qcom-pon.c
+++ b/drivers/power/reset/qcom-pon.c
@@ -82,6 +82,7 @@ static const struct of_device_id pm8916_pon_id_table[] = {
{ .compatible = "qcom,pm8916-pon", .data = (void *)GEN1_REASON_SHIFT },
{ .compatible = "qcom,pms405-pon", .data = (void *)GEN1_REASON_SHIFT },
{ .compatible = "qcom,pm8998-pon", .data = (void *)GEN2_REASON_SHIFT },
+ { .compatible = "qcom,pmk8350-pon", .data = (void *)GEN2_REASON_SHIFT },
{ }
};
MODULE_DEVICE_TABLE(of, pm8916_pon_id_table);
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [RESEND PATCH v5 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible "qcom,pmk8350-pon"
2022-09-09 20:42 ` [RESEND PATCH v5 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible "qcom,pmk8350-pon" Anjelique Melendez
@ 2022-09-10 7:57 ` Krzysztof Kozlowski
2022-09-12 4:33 ` Vinod Koul
1 sibling, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-10 7:57 UTC (permalink / raw)
To: Anjelique Melendez, corbet, sre, robh+dt, agross, andersson
Cc: krzysztof.kozlowski+dt, vkoul, linux-doc, linux-pm, devicetree,
linux-arm-msm, linux-kernel, quic_collinsd
On 09/09/2022 22:42, Anjelique Melendez wrote:
> From: David Collins <quic_collinsd@quicinc.com>
>
> Add a new compatible string "qcom,pmk8350-pon" for GEN3 PMIC PON
> peripherals and update "reg" property.
> Also, Add an optional "reg-names" property to differentiate between
> GEN1/GEN2 and GEN3 peripherals. GEN1/GEN2 peripherals only need one
> register address to be specified (e.g. "pon") whereas GEN3 peripherals
> can have two register addresses specified ("hlos", "pbs").
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RESEND PATCH v5 2/2] power: reset: qcom-pon: add support for qcom,pmk8350-pon compatible string
2022-09-09 20:42 ` [RESEND PATCH v5 2/2] power: reset: qcom-pon: add support for qcom,pmk8350-pon compatible string Anjelique Melendez
@ 2022-09-10 7:57 ` Krzysztof Kozlowski
2022-09-12 4:33 ` Vinod Koul
1 sibling, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-10 7:57 UTC (permalink / raw)
To: Anjelique Melendez, corbet, sre, robh+dt, agross, andersson
Cc: krzysztof.kozlowski+dt, vkoul, linux-doc, linux-pm, devicetree,
linux-arm-msm, linux-kernel, quic_collinsd
On 09/09/2022 22:42, Anjelique Melendez wrote:
> Add support for the new "qcom,pmk8350-pon" comptaible string.
>
> Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RESEND PATCH v5 0/2] add support for PON GEN3 device
2022-09-09 20:42 [RESEND PATCH v5 0/2] add support for PON GEN3 device Anjelique Melendez
2022-09-09 20:42 ` [RESEND PATCH v5 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible "qcom,pmk8350-pon" Anjelique Melendez
2022-09-09 20:42 ` [RESEND PATCH v5 2/2] power: reset: qcom-pon: add support for qcom,pmk8350-pon compatible string Anjelique Melendez
@ 2022-09-11 12:18 ` Sebastian Reichel
2 siblings, 0 replies; 8+ messages in thread
From: Sebastian Reichel @ 2022-09-11 12:18 UTC (permalink / raw)
To: Anjelique Melendez
Cc: corbet, robh+dt, agross, andersson, krzysztof.kozlowski+dt,
vkoul, linux-doc, linux-pm, devicetree, linux-arm-msm,
linux-kernel, quic_collinsd
[-- Attachment #1: Type: text/plain, Size: 1487 bytes --]
Hi,
On Fri, Sep 09, 2022 at 01:42:07PM -0700, Anjelique Melendez wrote:
> Resent with fixed path for dt-bindings.
>
> Changes from v4:
> - Updated commit message for patch 1/2
>
> Changes from v3:
> - Addressed Krysztof's comments on patch 1/2
> - Added missing minItems/maxItems
> - Merged if statments with same constraints together
> - Removed description from "reg-names"
>
> Changes from v2:
> - Added new "qcom,pmk8350-pon" compatible string as per Krysztof's
> advice
> - Updated dt logic to use comptaible strings to decide constraints
> as per Krysztof's comment
> - Added new patch (v3 2/2) to support new compatible string
>
> Changes from v1:
> - Updated path which was missing Documentation/devicetree prefix
> - Updated CC list
>
> New patch series to separate this patch from applied patches.
> Comments from original patch can be found
> https://lore.kernel.org/linux-arm-msm/27515993-18f3-8891-4835-9b6a8d7f86b0@quicinc.com/
>
> David Collins (1):
> dt-bindings: power: reset: qcom-pon: Add new compatible
> "qcom,pmk8350-pon"
>
> Anjelique Melendez (1):
> power: reset: qcom-pon: add support for qcom,pmk8350-pon compatible string
>
> Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 50 +++++++++++++++++++++++++++---
> drivers/power/reset/qcom-pon.c | 1 +
> 2 file changed, 47 insertions(+), 4 deletions(-)
Thanks, I queued both patches.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RESEND PATCH v5 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible "qcom,pmk8350-pon"
2022-09-09 20:42 ` [RESEND PATCH v5 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible "qcom,pmk8350-pon" Anjelique Melendez
2022-09-10 7:57 ` Krzysztof Kozlowski
@ 2022-09-12 4:33 ` Vinod Koul
1 sibling, 0 replies; 8+ messages in thread
From: Vinod Koul @ 2022-09-12 4:33 UTC (permalink / raw)
To: Anjelique Melendez
Cc: corbet, sre, robh+dt, agross, andersson, krzysztof.kozlowski+dt,
linux-doc, linux-pm, devicetree, linux-arm-msm, linux-kernel,
quic_collinsd
On 09-09-22, 13:42, Anjelique Melendez wrote:
> From: David Collins <quic_collinsd@quicinc.com>
>
> Add a new compatible string "qcom,pmk8350-pon" for GEN3 PMIC PON
> peripherals and update "reg" property.
> Also, Add an optional "reg-names" property to differentiate between
> GEN1/GEN2 and GEN3 peripherals. GEN1/GEN2 peripherals only need one
> register address to be specified (e.g. "pon") whereas GEN3 peripherals
> can have two register addresses specified ("hlos", "pbs").
Reviewed-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RESEND PATCH v5 2/2] power: reset: qcom-pon: add support for qcom,pmk8350-pon compatible string
2022-09-09 20:42 ` [RESEND PATCH v5 2/2] power: reset: qcom-pon: add support for qcom,pmk8350-pon compatible string Anjelique Melendez
2022-09-10 7:57 ` Krzysztof Kozlowski
@ 2022-09-12 4:33 ` Vinod Koul
1 sibling, 0 replies; 8+ messages in thread
From: Vinod Koul @ 2022-09-12 4:33 UTC (permalink / raw)
To: Anjelique Melendez
Cc: corbet, sre, robh+dt, agross, andersson, krzysztof.kozlowski+dt,
linux-doc, linux-pm, devicetree, linux-arm-msm, linux-kernel,
quic_collinsd
On 09-09-22, 13:42, Anjelique Melendez wrote:
> Add support for the new "qcom,pmk8350-pon" comptaible string.
Reviewed-by: Vinod Koul <vkoul@kernel.org>
>
> Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com>
> ---
> drivers/power/reset/qcom-pon.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c
> index 4a688741a88a..16bc01738be9 100644
> --- a/drivers/power/reset/qcom-pon.c
> +++ b/drivers/power/reset/qcom-pon.c
> @@ -82,6 +82,7 @@ static const struct of_device_id pm8916_pon_id_table[] = {
> { .compatible = "qcom,pm8916-pon", .data = (void *)GEN1_REASON_SHIFT },
> { .compatible = "qcom,pms405-pon", .data = (void *)GEN1_REASON_SHIFT },
> { .compatible = "qcom,pm8998-pon", .data = (void *)GEN2_REASON_SHIFT },
> + { .compatible = "qcom,pmk8350-pon", .data = (void *)GEN2_REASON_SHIFT },
> { }
> };
> MODULE_DEVICE_TABLE(of, pm8916_pon_id_table);
> --
> 2.35.1
--
~Vinod
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-09-12 10:28 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-09 20:42 [RESEND PATCH v5 0/2] add support for PON GEN3 device Anjelique Melendez
2022-09-09 20:42 ` [RESEND PATCH v5 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible "qcom,pmk8350-pon" Anjelique Melendez
2022-09-10 7:57 ` Krzysztof Kozlowski
2022-09-12 4:33 ` Vinod Koul
2022-09-09 20:42 ` [RESEND PATCH v5 2/2] power: reset: qcom-pon: add support for qcom,pmk8350-pon compatible string Anjelique Melendez
2022-09-10 7:57 ` Krzysztof Kozlowski
2022-09-12 4:33 ` Vinod Koul
2022-09-11 12:18 ` [RESEND PATCH v5 0/2] add support for PON GEN3 device Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).