linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Remove link to nonexistent rocket driver docs
@ 2021-05-11 13:49 Desmond Cheong Zhi Xi
  2021-05-11 17:03 ` Jonathan Corbet
  0 siblings, 1 reply; 3+ messages in thread
From: Desmond Cheong Zhi Xi @ 2021-05-11 13:49 UTC (permalink / raw)
  To: gregkh, jirislaby, corbet
  Cc: Desmond Cheong Zhi Xi, linux-doc, linux-kernel, skhan,
	linux-kernel-mentees

Fixes: 3b00b6af7a5b ("tty: rocket, remove the driver")
The rocket driver and documentation were removed in this commit, but
the corresponding entry in index.rst was not removed.

Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
---
 Documentation/driver-api/serial/index.rst | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/driver-api/serial/index.rst b/Documentation/driver-api/serial/index.rst
index 21351b8c95a4..8f7d7af3b90b 100644
--- a/Documentation/driver-api/serial/index.rst
+++ b/Documentation/driver-api/serial/index.rst
@@ -19,7 +19,6 @@ Serial drivers
 
     moxa-smartio
     n_gsm
-    rocket
     serial-iso7816
     serial-rs485
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Remove link to nonexistent rocket driver docs
  2021-05-11 13:49 [PATCH] Remove link to nonexistent rocket driver docs Desmond Cheong Zhi Xi
@ 2021-05-11 17:03 ` Jonathan Corbet
  2021-05-11 23:51   ` Desmond Cheong
  0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Corbet @ 2021-05-11 17:03 UTC (permalink / raw)
  To: Desmond Cheong Zhi Xi, gregkh, jirislaby
  Cc: Desmond Cheong Zhi Xi, linux-doc, linux-kernel, skhan,
	linux-kernel-mentees

Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com> writes:

> Fixes: 3b00b6af7a5b ("tty: rocket, remove the driver")
> The rocket driver and documentation were removed in this commit, but
> the corresponding entry in index.rst was not removed.
>
> Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>

Please note: the "Fixes" tag should be down at the end with your
signoff. 

>  Documentation/driver-api/serial/index.rst | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/driver-api/serial/index.rst b/Documentation/driver-api/serial/index.rst
> index 21351b8c95a4..8f7d7af3b90b 100644
> --- a/Documentation/driver-api/serial/index.rst
> +++ b/Documentation/driver-api/serial/index.rst
> @@ -19,7 +19,6 @@ Serial drivers
>  
>      moxa-smartio
>      n_gsm
> -    rocket
>      serial-iso7816
>      serial-rs485

Otherwise this looks like a good fix.  I've applied it (with Fixes in
the right place), thanks.

jon

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Remove link to nonexistent rocket driver docs
  2021-05-11 17:03 ` Jonathan Corbet
@ 2021-05-11 23:51   ` Desmond Cheong
  0 siblings, 0 replies; 3+ messages in thread
From: Desmond Cheong @ 2021-05-11 23:51 UTC (permalink / raw)
  To: Jonathan Corbet, gregkh, jirislaby
  Cc: linux-doc, linux-kernel, skhan, linux-kernel-mentees

On 11/5/21 1:03 pm, Jonathan Corbet wrote:
> Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com> writes:
> 
>> Fixes: 3b00b6af7a5b ("tty: rocket, remove the driver")
>> The rocket driver and documentation were removed in this commit, but
>> the corresponding entry in index.rst was not removed.
>>
>> Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
> 
> Please note: the "Fixes" tag should be down at the end with your
> signoff.
> 
>>   Documentation/driver-api/serial/index.rst | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/Documentation/driver-api/serial/index.rst b/Documentation/driver-api/serial/index.rst
>> index 21351b8c95a4..8f7d7af3b90b 100644
>> --- a/Documentation/driver-api/serial/index.rst
>> +++ b/Documentation/driver-api/serial/index.rst
>> @@ -19,7 +19,6 @@ Serial drivers
>>   
>>       moxa-smartio
>>       n_gsm
>> -    rocket
>>       serial-iso7816
>>       serial-rs485
> 
> Otherwise this looks like a good fix.  I've applied it (with Fixes in
> the right place), thanks.
> 
> jon
> 

Thanks for the feedback and the amendment, Jon. I will take note in the 
future.

Best wishes,
Desmond


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-11 23:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11 13:49 [PATCH] Remove link to nonexistent rocket driver docs Desmond Cheong Zhi Xi
2021-05-11 17:03 ` Jonathan Corbet
2021-05-11 23:51   ` Desmond Cheong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).