From: Jason Yan <yanaijie@huawei.com>
To: Robert Richter <rrichter@marvell.com>
Cc: <khuong@os.amperecomputing.com>, <bp@alien8.de>,
<mchehab@kernel.org>, <tony.luck@intel.com>,
<james.morse@arm.com>, <linux-edac@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] EDAC, xgene: remove set but not used 'address'
Date: Thu, 9 Apr 2020 17:15:52 +0800 [thread overview]
Message-ID: <1185c697-026d-74c9-3f67-e95bebdc4c00@huawei.com> (raw)
In-Reply-To: <20200409091016.d3uohmt2o3zwhmro@rric.localdomain>
在 2020/4/9 17:10, Robert Richter 写道:
> On 09.04.20 16:52:37, Jason Yan wrote:
>> Fix the following gcc warning:
>>
>> drivers/edac/xgene_edac.c:1486:7: warning: variable ‘address’ set but
>> not used [-Wunused-but-set-variable]
>> u32 address;
>> ^~~~~~~
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Jason Yan <yanaijie@huawei.com>
>> ---
>> drivers/edac/xgene_edac.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c
>> index e4a1032ba0b5..e5e0fbdeca29 100644
>> --- a/drivers/edac/xgene_edac.c
>> +++ b/drivers/edac/xgene_edac.c
>> @@ -1483,13 +1483,11 @@ static void xgene_edac_rb_report(struct edac_device_ctl_info *edac_dev)
>> return;
>> if (reg & STICKYERR_MASK) {
>> bool write;
>> - u32 address;
>>
>> dev_err(edac_dev->dev, "IOB bus access error(s)\n");
>> if (regmap_read(ctx->edac->rb_map, RBEIR, ®))
>> return;
>> write = reg & WRITE_ACCESS_MASK ? 1 : 0;
>> - address = RBERRADDR_RD(reg);
>
> Please also remove that unused macro.
>
OK, thanks.
Jason
> Thanks,
>
> -Robert
>
>> if (reg & AGENT_OFFLINE_ERR_MASK)
>> dev_err(edac_dev->dev,
>> "IOB bus %s access to offline agent error\n",
>> --
>> 2.17.2
>>
>
next prev parent reply other threads:[~2020-04-09 9:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 8:52 [PATCH] EDAC, xgene: remove set but not used 'address' Jason Yan
2020-04-09 9:10 ` Robert Richter
2020-04-09 9:15 ` Jason Yan [this message]
2020-04-09 9:19 Jason Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185c697-026d-74c9-3f67-e95bebdc4c00@huawei.com \
--to=yanaijie@huawei.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=khuong@os.amperecomputing.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rrichter@marvell.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).