* [PATCH -next 022/491] X86 MCE INFRASTRUCTURE: Use fallthrough; [not found] <cover.1583896344.git.joe@perches.com> @ 2020-03-11 4:51 ` Joe Perches 2020-03-11 17:14 ` Borislav Petkov 0 siblings, 1 reply; 2+ messages in thread From: Joe Perches @ 2020-03-11 4:51 UTC (permalink / raw) To: Tony Luck, Borislav Petkov Cc: Thomas Gleixner, H. Peter Anvin, x86, linux-edac, linux-kernel Convert the various uses of fallthrough comments to fallthrough; Done via script Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ Signed-off-by: Joe Perches <joe@perches.com> --- arch/x86/kernel/cpu/mce/inject.c | 2 +- arch/x86/kernel/cpu/mce/intel.c | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/inject.c b/arch/x86/kernel/cpu/mce/inject.c index 3413b41..b5e3bab 100644 --- a/arch/x86/kernel/cpu/mce/inject.c +++ b/arch/x86/kernel/cpu/mce/inject.c @@ -199,7 +199,7 @@ static int raise_local(void) * calling irq_enter, but the necessary * machinery isn't exported currently. */ - /*FALL THROUGH*/ + fallthrough; case MCJ_CTX_PROCESS: raise_exception(m, NULL); break; diff --git a/arch/x86/kernel/cpu/mce/intel.c b/arch/x86/kernel/cpu/mce/intel.c index d8f9230..5be647 100644 --- a/arch/x86/kernel/cpu/mce/intel.c +++ b/arch/x86/kernel/cpu/mce/intel.c @@ -192,9 +192,7 @@ unsigned long cmci_intel_adjust_timer(unsigned long interval) __this_cpu_write(cmci_storm_state, CMCI_STORM_SUBSIDED); if (!atomic_sub_return(1, &cmci_storm_on_cpus)) pr_notice("CMCI storm subsided: switching to interrupt mode\n"); - - /* FALLTHROUGH */ - + fallthrough; case CMCI_STORM_SUBSIDED: /* * We wait for all CPUs to go back to SUBSIDED state. When that -- 2.24.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next 022/491] X86 MCE INFRASTRUCTURE: Use fallthrough; 2020-03-11 4:51 ` [PATCH -next 022/491] X86 MCE INFRASTRUCTURE: Use fallthrough; Joe Perches @ 2020-03-11 17:14 ` Borislav Petkov 0 siblings, 0 replies; 2+ messages in thread From: Borislav Petkov @ 2020-03-11 17:14 UTC (permalink / raw) To: Joe Perches Cc: Tony Luck, Thomas Gleixner, H. Peter Anvin, x86, linux-edac, linux-kernel On Tue, Mar 10, 2020 at 09:51:36PM -0700, Joe Perches wrote: > Subject: Re: [PATCH -next 022/491] X86 MCE INFRASTRUCTURE: Use fallthrough; Make that subject prefix "x86/mce: ..." > Convert the various uses of fallthrough comments to fallthrough; > > Done via script > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ > > Signed-off-by: Joe Perches <joe@perches.com> > --- > arch/x86/kernel/cpu/mce/inject.c | 2 +- > arch/x86/kernel/cpu/mce/intel.c | 4 +--- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/kernel/cpu/mce/inject.c b/arch/x86/kernel/cpu/mce/inject.c > index 3413b41..b5e3bab 100644 > --- a/arch/x86/kernel/cpu/mce/inject.c > +++ b/arch/x86/kernel/cpu/mce/inject.c > @@ -199,7 +199,7 @@ static int raise_local(void) > * calling irq_enter, but the necessary > * machinery isn't exported currently. > */ > - /*FALL THROUGH*/ > + fallthrough; > case MCJ_CTX_PROCESS: > raise_exception(m, NULL); > break; > diff --git a/arch/x86/kernel/cpu/mce/intel.c b/arch/x86/kernel/cpu/mce/intel.c > index d8f9230..5be647 100644 > --- a/arch/x86/kernel/cpu/mce/intel.c > +++ b/arch/x86/kernel/cpu/mce/intel.c > @@ -192,9 +192,7 @@ unsigned long cmci_intel_adjust_timer(unsigned long interval) > __this_cpu_write(cmci_storm_state, CMCI_STORM_SUBSIDED); > if (!atomic_sub_return(1, &cmci_storm_on_cpus)) > pr_notice("CMCI storm subsided: switching to interrupt mode\n"); > - > - /* FALLTHROUGH */ > - > + fallthrough; > case CMCI_STORM_SUBSIDED: > /* > * We wait for all CPUs to go back to SUBSIDED state. When that > -- With that: Acked-by: Borislav Petkov <bp@suse.de> -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-11 17:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1583896344.git.joe@perches.com>
2020-03-11 4:51 ` [PATCH -next 022/491] X86 MCE INFRASTRUCTURE: Use fallthrough; Joe Perches
2020-03-11 17:14 ` Borislav Petkov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).