* EDAC: i82443bxgx: Fix invalid memory type assignment
@ 2018-08-15 15:57 Borislav Petkov
0 siblings, 0 replies; 4+ messages in thread
From: Borislav Petkov @ 2018-08-15 15:57 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Tim Small, Mauro Carvalho Chehab, linux-edac, linux-kernel
On Fri, Aug 10, 2018 at 04:15:20PM +0200, Takashi Iwai wrote:
> The i82443bxgx_edac driver assigns an invalid negative value when an
> unknown DRAM type is detected. Drop the unnecessary '-' that brings
> misbehavior.
>
> Fixes: 5a2c675c8919 ("drivers/edac: new i82443bxgz MC driver")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
> drivers/edac/i82443bxgx_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/i82443bxgx_edac.c b/drivers/edac/i82443bxgx_edac.c
> index a2ca929e2168..1638f288fa47 100644
> --- a/drivers/edac/i82443bxgx_edac.c
> +++ b/drivers/edac/i82443bxgx_edac.c
> @@ -273,7 +273,7 @@ static int i82443bxgx_edacmc_probe1(struct pci_dev *pdev, int dev_idx)
> break;
> default:
> edac_dbg(0, "Unknown/reserved DRAM type value in DRAMC register!\n");
> - mtype = -MEM_UNKNOWN;
> + mtype = MEM_UNKNOWN;
> }
>
> if ((mtype == MEM_SDR) || (mtype == MEM_RDR))
> --
Is this something you caught by inspection or you really have hw that
loads that driver...
Wikipedia says 440BX chipset is pentium II and III which, if so, would
drop its priority considerably. CC:stable would be not needed either, TBH.
Thx.
^ permalink raw reply [flat|nested] 4+ messages in thread
* EDAC: i82443bxgx: Fix invalid memory type assignment
@ 2018-08-15 16:12 Borislav Petkov
0 siblings, 0 replies; 4+ messages in thread
From: Borislav Petkov @ 2018-08-15 16:12 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Tim Small, Mauro Carvalho Chehab, linux-edac, linux-kernel
On Wed, Aug 15, 2018 at 06:01:27PM +0200, Takashi Iwai wrote:
> I just followed the old percept: read the source, Luke.
You're a wise jedi :)
> OK, feel free to drop that.
Nah, I can take it - I'll just drop the CC:stable thing.
Thx.
^ permalink raw reply [flat|nested] 4+ messages in thread
* EDAC: i82443bxgx: Fix invalid memory type assignment
@ 2018-08-15 16:01 Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2018-08-15 16:01 UTC (permalink / raw)
To: Borislav Petkov
Cc: Tim Small, Mauro Carvalho Chehab, linux-edac, linux-kernel
On Wed, 15 Aug 2018 17:57:52 +0200,
Borislav Petkov wrote:
>
> On Fri, Aug 10, 2018 at 04:15:20PM +0200, Takashi Iwai wrote:
> > The i82443bxgx_edac driver assigns an invalid negative value when an
> > unknown DRAM type is detected. Drop the unnecessary '-' that brings
> > misbehavior.
> >
> > Fixes: 5a2c675c8919 ("drivers/edac: new i82443bxgz MC driver")
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > ---
> > drivers/edac/i82443bxgx_edac.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/edac/i82443bxgx_edac.c b/drivers/edac/i82443bxgx_edac.c
> > index a2ca929e2168..1638f288fa47 100644
> > --- a/drivers/edac/i82443bxgx_edac.c
> > +++ b/drivers/edac/i82443bxgx_edac.c
> > @@ -273,7 +273,7 @@ static int i82443bxgx_edacmc_probe1(struct pci_dev *pdev, int dev_idx)
> > break;
> > default:
> > edac_dbg(0, "Unknown/reserved DRAM type value in DRAMC register!\n");
> > - mtype = -MEM_UNKNOWN;
> > + mtype = MEM_UNKNOWN;
> > }
> >
> > if ((mtype == MEM_SDR) || (mtype == MEM_RDR))
> > --
>
> Is this something you caught by inspection or you really have hw that
> loads that driver...
I just followed the old percept: read the source, Luke.
> Wikipedia says 440BX chipset is pentium II and III which, if so, would
> drop its priority considerably. CC:stable would be not needed either, TBH.
OK, feel free to drop that.
thanks,
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* EDAC: i82443bxgx: Fix invalid memory type assignment
@ 2018-08-10 14:15 Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2018-08-10 14:15 UTC (permalink / raw)
To: Borislav Petkov
Cc: Tim Small, Mauro Carvalho Chehab, linux-edac, linux-kernel
The i82443bxgx_edac driver assigns an invalid negative value when an
unknown DRAM type is detected. Drop the unnecessary '-' that brings
misbehavior.
Fixes: 5a2c675c8919 ("drivers/edac: new i82443bxgz MC driver")
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
drivers/edac/i82443bxgx_edac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/i82443bxgx_edac.c b/drivers/edac/i82443bxgx_edac.c
index a2ca929e2168..1638f288fa47 100644
--- a/drivers/edac/i82443bxgx_edac.c
+++ b/drivers/edac/i82443bxgx_edac.c
@@ -273,7 +273,7 @@ static int i82443bxgx_edacmc_probe1(struct pci_dev *pdev, int dev_idx)
break;
default:
edac_dbg(0, "Unknown/reserved DRAM type value in DRAMC register!\n");
- mtype = -MEM_UNKNOWN;
+ mtype = MEM_UNKNOWN;
}
if ((mtype == MEM_SDR) || (mtype == MEM_RDR))
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-15 16:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-15 15:57 EDAC: i82443bxgx: Fix invalid memory type assignment Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2018-08-15 16:12 Borislav Petkov
2018-08-15 16:01 Takashi Iwai
2018-08-10 14:15 Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).