From: Borislav Petkov <bp@alien8.de>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-edac@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2 1/2] ras: fix an off-by-one error in __find_elem()
Date: Sun, 21 Apr 2019 10:27:07 +0200 [thread overview]
Message-ID: <20190421082707.GA6048@zn.tnic> (raw)
Message-ID: <20190421082707.SN6Dr5ktbcN6jdCe66GNA30jEHMlHi_P-EKKJTKX9XY@z> (raw)
In-Reply-To: <CAM_iQpWedOfJLSG1zzaEqRY05GO2jnODWT8mQVAiWSsk3umQUA@mail.gmail.com>
On Sat, Apr 20, 2019 at 12:15:26PM -0700, Cong Wang wrote:
> Yes, one is V1 and the other is V2. Is it hard to understand V2 is to
> replace V1?
Well, looking at these two very different fixes, it made me think that
you don't really know what you're doing. So I went and did the Knuth's
version just so that I can analyze and understand the issue myself.
The final result ended up needing *both* the index fix *and* removed the
trailing noodling code after the loop which looked fishy at best and I
wanted it gone anyway.
So in the end:
1. your first fix was correct but incomplete
2. your second was replaced by a better version of the whole thing
So the final result is a lot cleaner and straight-forward. And it is
only 29 lines and I don't see a problem with it going to stable.
And I as author and maintainer of this code have very much the
prerogative to decide which way to go, TYVM. No matter how much you
passive-aggressively bitch. Thanks to your last mail, I won't have to
make this choice anymore.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-04-21 8:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 21:33 [v2,1/2] ras: fix an off-by-one error in __find_elem() Cong Wang
2019-04-16 21:33 ` [PATCH v2 1/2] " Cong Wang
2019-04-16 21:33 ` [v2,2/2] ras: close the race condition with timer Cong Wang
2019-04-16 21:33 ` [PATCH v2 2/2] " Cong Wang
2019-06-08 15:28 ` [tip:ras/urgent] RAS/CEC: Convert the timer callback to a workqueue tip-bot for Cong Wang
2019-04-16 21:46 ` [v2,1/2] ras: fix an off-by-one error in __find_elem() Borislav Petkov
2019-04-16 21:46 ` [PATCH v2 1/2] " Borislav Petkov
2019-04-16 23:16 ` [v2,1/2] " Cong Wang
2019-04-16 23:16 ` [PATCH v2 1/2] " Cong Wang
2019-04-20 11:34 ` [v2,1/2] " Borislav Petkov
2019-04-20 11:34 ` [PATCH v2 1/2] " Borislav Petkov
2019-04-20 18:25 ` [v2,1/2] " Cong Wang
2019-04-20 18:25 ` [PATCH v2 1/2] " Cong Wang
2019-04-20 19:04 ` [v2,1/2] " Borislav Petkov
2019-04-20 19:04 ` [PATCH v2 1/2] " Borislav Petkov
2019-04-20 19:15 ` [v2,1/2] " Cong Wang
2019-04-20 19:15 ` [PATCH v2 1/2] " Cong Wang
2019-04-21 8:27 ` Borislav Petkov [this message]
2019-04-21 8:27 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190421082707.GA6048@zn.tnic \
--to=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).