From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: "Hawa, Hanna" <hhhawa@amazon.com>
Cc: <robh+dt@kernel.org>, <mark.rutland@arm.com>, <bp@alien8.de>,
<mchehab@kernel.org>, <james.morse@arm.com>,
<davem@davemloft.net>, <gregkh@linuxfoundation.org>,
<linus.walleij@linaro.org>, <nicolas.ferre@microchip.com>,
<paulmck@linux.ibm.com>, <dwmw@amazon.co.uk>, <benh@amazon.com>,
<ronenk@amazon.com>, <talel@amazon.com>, <jonnyc@amazon.com>,
<hanochu@amazon.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-edac@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] edac: Add support for Amazon's Annapurna Labs L1 EDAC
Date: Tue, 9 Jul 2019 13:30:56 +0100 [thread overview]
Message-ID: <20190709133056.00001c57@huawei.com> (raw)
In-Reply-To: <45e9ac35-9ffc-8f5f-cbdb-f85453227363@amazon.com>
On Tue, 9 Jul 2019 14:01:03 +0300
"Hawa, Hanna" <hhhawa@amazon.com> wrote:
> On 7/9/2019 12:32 PM, Jonathan Cameron wrote:
> >> Signed-off-by: Hanna Hawa<hhhawa@amazon.com>
> > A quick drive by review as I was feeling curious.
> >
> > Just a couple of trivial queries and observation on the fact it
> > might be useful to add a few devm managed functions to cut down
> > on edac driver boilerplate.
> >
> > Thanks,
> >
> > Jonathan
> >
> >> +#define ARM_CA57_CPUMERRSR_VALID GENMASK(31, 31)
> > For a single bit it's common to use BIT(31) rather than GENMASK to make
> > it explicit.
>
> Will fix.
>
> >
> >
> >> + edac_dev->mod_name = dev_name(dev);
> > I'd admit I'm not that familiar with edac, but seems odd that a
> > module name field would have the dev_name.
>
> Will fix when I got more inputs.
>
> >
> >> + edac_device_free_ctl_info(edac_dev);
> > More a passing observation than a suggestion for this driver, but if there was
> > ever a place where it looked like a couple of devm_ allocation functions would
> > be useful, this is it;)
> >
> > edac_dev = devm_device_alloc_ctrl_info(dev, ...)
> > ...
> > devm_edac_device_add_device(dev, ...)
>
> I agree.
> I can implement the devm_* functions in separate patches as this is not
> related to my patches (and not to delay this patches).
>
Great.
Jonathan
> >
> >
next prev parent reply other threads:[~2019-07-09 12:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-07 11:57 [PATCH v2 0/4] Add support for Amazon's Annapurna Labs EDAC for L1/L2 Hanna Hawa
2019-07-07 11:57 ` [PATCH v2 1/4] dt-bindings: EDAC: Add Amazon's Annapurna Labs L1 EDAC Hanna Hawa
2019-07-07 11:57 ` [PATCH v2 2/4] edac: Add support for " Hanna Hawa
2019-07-09 9:32 ` Jonathan Cameron
2019-07-09 11:01 ` Hawa, Hanna
2019-07-09 12:30 ` Jonathan Cameron [this message]
2019-07-09 17:59 ` Joe Perches
2019-07-07 11:57 ` [PATCH v2 3/4] dt-bindings: EDAC: Add Amazon's Annapurna Labs L2 EDAC Hanna Hawa
2019-07-07 11:57 ` [PATCH v2 4/4] edac: Add support for " Hanna Hawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709133056.00001c57@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=benh@amazon.com \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=james.morse@arm.com \
--cc=jonnyc@amazon.com \
--cc=linus.walleij@linaro.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=paulmck@linux.ibm.com \
--cc=robh+dt@kernel.org \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).