From: Borislav Petkov <bp@alien8.de>
To: Isaac Vaughn <isaac.vaughn@Knights.ucf.edu>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
James Morse <james.morse@arm.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add PCI device IDs for family 17h, model 70h
Date: Sat, 7 Sep 2019 07:59:17 +0200 [thread overview]
Message-ID: <20190907055917.GA10446@zn.tnic> (raw)
In-Reply-To: <20190906192131.8ced0ca112146f32d82b6cae@knights.ucf.edu>
On Fri, Sep 06, 2019 at 11:21:38PM +0000, Isaac Vaughn wrote:
> Add the new Family 17h Model 70h PCI IDs (device 18h functions 0 and 6)
> to the AMD64 EDAC module.
>
> Cc: Borislav Petkov <bp@alien8.de> (maintainer:EDAC-AMD64)
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> (supporter:EDAC-CORE)
> Cc: James Morse <james.morse@arm.com> (reviewer:EDAC-CORE)
> Cc: linux-edac@vger.kernel.org (open list:EDAC-AMD64)
> Cc: linux-kernel@vger.kernel.org (open list)
> Signed-off-by: Isaac Vaughn <isaac.vaughn@knights.ucf.edu>
> ---
> drivers/edac/amd64_edac.c | 13 +++++++++++++
> drivers/edac/amd64_edac.h | 3 +++
> 2 files changed, 16 insertions(+)
>
> diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
> index 873437be86d9..a35c97f9100a 100644
> --- a/drivers/edac/amd64_edac.c
> +++ b/drivers/edac/amd64_edac.c
> @@ -2253,6 +2253,15 @@ static struct amd64_family_type family_types[] = {
> .dbam_to_cs = f17_base_addr_to_cs_size,
> }
> },
> + [F17_M70H_CPUS] = {
> + .ctl_name = "F17h_M70h",
> + .f0_id = PCI_DEVICE_ID_AMD_17H_M70H_DF_F0,
> + .f6_id = PCI_DEVICE_ID_AMD_17H_M70H_DF_F6,
> + .ops = {
> + .early_channel_count = f17_early_channel_count,
> + .dbam_to_cs = f17_base_addr_to_cs_size,
You still have f17_base_addr_to_cs_size here. If you'd built it against
the branch I pointed you at:
https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git/log/?h=edac-for-next
it would have failed.
Anyway, I fixed it up and applied it.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2019-09-07 5:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 23:21 [PATCH] Add PCI device IDs for family 17h, model 70h Isaac Vaughn
2019-09-07 5:59 ` Borislav Petkov [this message]
2019-09-07 12:09 ` Isaac Vaughn
-- strict thread matches above, loose matches on Subject: below --
2019-09-04 21:13 [PATCH] amd64_edac - Add Family 17h Model 70h PCI IDs Isaac Vaughn
2019-09-04 21:53 ` Borislav Petkov
2019-09-05 1:21 ` Isaac Vaughn
2019-09-05 7:09 ` Borislav Petkov
2019-09-05 13:17 ` Isaac Vaughn
2019-09-05 13:54 ` Borislav Petkov
2019-09-06 1:01 ` [PATCH] Add PCI device IDs for family 17h, model 70h Isaac Vaughn
2019-09-06 1:41 ` Ghannam, Yazen
2019-09-06 1:56 ` Isaac Vaughn
2019-09-06 9:12 ` Borislav Petkov
[not found] ` <20190906075729.9e2faf7147da62fc26006833@knights.ucf.edu>
2019-09-06 12:14 ` Borislav Petkov
2019-09-06 13:02 ` Guenter Roeck
2019-09-06 13:09 ` Boris Petkov
[not found] ` <B08C8E54-43FA-4E29-8D7D-5F9C4AF20CCF@Knights.ucf.edu>
2019-09-06 14:50 ` Borislav Petkov
2019-09-06 23:27 ` Isaac Vaughn
2019-09-06 16:11 ` Guenter Roeck
2019-09-06 16:22 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190907055917.GA10446@zn.tnic \
--to=bp@alien8.de \
--cc=isaac.vaughn@Knights.ucf.edu \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).