From: Borislav Petkov <bp@alien8.de>
To: Xiaochun Lee <lixiaochun.2888@163.com>
Cc: tony.luck@intel.com, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, x86@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, Xiaochun Lee <lixc17@lenovo.com>
Subject: Re: [PATCH] x86/mce: add a switch of CONFIG_X86_MCELOG_LEGACY
Date: Wed, 11 Sep 2019 17:40:37 +0200 [thread overview]
Message-ID: <20190911154037.GB27910@zn.tnic> (raw)
In-Reply-To: <1568215730-11471-1-git-send-email-lixiaochun.2888@163.com>
On Wed, Sep 11, 2019 at 11:28:50PM +0800, Xiaochun Lee wrote:
> From: Xiaochun Lee <lixc17@lenovo.com>
>
> Add CONFIG_X86_MCELOG_LEGACY to control the
> behavior of several functions be compiled.
... because?
Your commit messages structure should look something like this:
Problem is A.
It happens because of B.
Fix it by doing C.
(Potentially do D).
For more detailed info, see
Documentation/process/submitting-patches.rst, Section "2) Describe your
changes".
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2019-09-11 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 15:28 [PATCH] x86/mce: add a switch of CONFIG_X86_MCELOG_LEGACY Xiaochun Lee
2019-09-11 15:40 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190911154037.GB27910@zn.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixc17@lenovo.com \
--cc=lixiaochun.2888@163.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).