From: Robert Richter <rrichter@marvell.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Hanna Hawa <hhhawa@amazon.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"james.morse@arm.com" <james.morse@arm.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dwmw@amazon.co.uk" <dwmw@amazon.co.uk>,
"benh@amazon.com" <benh@amazon.com>,
"ronenk@amazon.com" <ronenk@amazon.com>,
"talel@amazon.com" <talel@amazon.com>,
"jonnyc@amazon.com" <jonnyc@amazon.com>,
"hanochu@amazon.com" <hanochu@amazon.com>
Subject: Re: [PATCH v4 1/2] edac: Add an API for edac device to report for multiple errors
Date: Tue, 1 Oct 2019 06:56:58 +0000 [thread overview]
Message-ID: <20191001065649.a6454bh4ncgdpigf@rric.localdomain> (raw)
In-Reply-To: <20190930145046.GH29694@zn.tnic>
On 30.09.19 16:50:46, Borislav Petkov wrote:
> ----------------------------------------------------------------------
> On Mon, Sep 23, 2019 at 08:17:40PM +0100, Hanna Hawa wrote:
> > +void edac_device_handle_ce(struct edac_device_ctl_info *edac_dev,
> > + int inst_nr, int block_nr, const char *msg)
> > +{
> > + __edac_device_handle_ce(edac_dev, 1, inst_nr, block_nr, msg);
> > +}
> > +EXPORT_SYMBOL_GPL(edac_device_handle_ce);
>
> Eww, I don't like that: exporting the function *and* the __ counterpart.
> The user will get confused and that is unnecessary.
It is *not* the counterpart. The __* version already has the
additional count argument in. There are 2 patches:
1) introduce new function __edac_device_handle_ce/ue() including the
*_count() inline functions, but keep the old symbols (note the
count=1 parameter).
2) remove old symbol edac_device_handle_ce/ue() and replace it with an
inline function to use the counterpart symbol too.
The first patch only adds functionality but keeps the abi. Thus it
makes a backport easier. The 2nd switches completely to the new
function.
-Robert
next prev parent reply other threads:[~2019-10-01 6:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 19:17 [PATCH v4 0/2] Add an API for edac device, for mulriple errors Hanna Hawa
2019-09-23 19:17 ` [PATCH v4 1/2] edac: Add an API for edac device to report for multiple errors Hanna Hawa
2019-09-30 14:50 ` Borislav Petkov
2019-10-01 6:56 ` Robert Richter [this message]
2019-10-01 8:32 ` Borislav Petkov
2019-10-01 9:47 ` Robert Richter
2019-10-01 10:25 ` Borislav Petkov
2019-10-01 10:53 ` Robert Richter
2019-10-02 9:25 ` Hawa, Hanna
2019-10-04 16:57 ` [PATCH -v2] EDAC/device: Rework error logging API Borislav Petkov
2019-09-23 19:17 ` [PATCH v4 2/2] edac: move edac_device_handle_*() API functions to header Hanna Hawa
2019-09-24 6:33 ` [PATCH v4 0/2] Add an API for edac device, for mulriple errors Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001065649.a6454bh4ncgdpigf@rric.localdomain \
--to=rrichter@marvell.com \
--cc=benh@amazon.com \
--cc=bp@alien8.de \
--cc=dwmw@amazon.co.uk \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=james.morse@arm.com \
--cc=jonnyc@amazon.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).