Linux-EDAC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] x86/mce/amd: fix -Wmissing-prototypes warnings
@ 2019-10-23  7:57 Yi Wang
  2019-10-23  8:07 ` Borislav Petkov
  0 siblings, 1 reply; 2+ messages in thread
From: Yi Wang @ 2019-10-23  7:57 UTC (permalink / raw)
  To: tony.luck
  Cc: bp, tglx, mingo, hpa, x86, linux-edac, linux-kernel, xue.zhihong,
	wang.yi59, up2wing, wang.liang82

We get two warnings when build kernel W=1:
arch/x86/kernel/cpu/mce/amd.c:586:6: warning: no previous prototype for ‘disable_err_thresholding’ [-Wmissing-prototypes]

Make the function static to fix this.

Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
---
 arch/x86/kernel/cpu/mce/amd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c
index 6ea7fdc..5167bd2 100644
--- a/arch/x86/kernel/cpu/mce/amd.c
+++ b/arch/x86/kernel/cpu/mce/amd.c
@@ -583,7 +583,7 @@ bool amd_filter_mce(struct mce *m)
  * - Prevent possible spurious interrupts from the IF bank on Family 0x17
  *   Models 0x10-0x2F due to Erratum #1114.
  */
-void disable_err_thresholding(struct cpuinfo_x86 *c, unsigned int bank)
+static void disable_err_thresholding(struct cpuinfo_x86 *c, unsigned int bank)
 {
 	int i, num_msrs;
 	u64 hwcr;
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] x86/mce/amd: fix -Wmissing-prototypes warnings
  2019-10-23  7:57 [PATCH] x86/mce/amd: fix -Wmissing-prototypes warnings Yi Wang
@ 2019-10-23  8:07 ` Borislav Petkov
  0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2019-10-23  8:07 UTC (permalink / raw)
  To: Yi Wang
  Cc: tony.luck, tglx, mingo, hpa, x86, linux-edac, linux-kernel,
	xue.zhihong, up2wing, wang.liang82

On Wed, Oct 23, 2019 at 03:57:17PM +0800, Yi Wang wrote:
> We get two warnings when build kernel W=1:
> arch/x86/kernel/cpu/mce/amd.c:586:6: warning: no previous prototype for ‘disable_err_thresholding’ [-Wmissing-prototypes]
> 
> Make the function static to fix this.
> 
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> ---
>  arch/x86/kernel/cpu/mce/amd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c
> index 6ea7fdc..5167bd2 100644
> --- a/arch/x86/kernel/cpu/mce/amd.c
> +++ b/arch/x86/kernel/cpu/mce/amd.c
> @@ -583,7 +583,7 @@ bool amd_filter_mce(struct mce *m)
>   * - Prevent possible spurious interrupts from the IF bank on Family 0x17
>   *   Models 0x10-0x2F due to Erratum #1114.
>   */
> -void disable_err_thresholding(struct cpuinfo_x86 *c, unsigned int bank)
> +static void disable_err_thresholding(struct cpuinfo_x86 *c, unsigned int bank)
>  {
>  	int i, num_msrs;
>  	u64 hwcr;
> --

https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=ras/core&id=47cd84e98f512eac5aad988f08baff432aea35ba

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-23  7:57 [PATCH] x86/mce/amd: fix -Wmissing-prototypes warnings Yi Wang
2019-10-23  8:07 ` Borislav Petkov

Linux-EDAC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-edac/0 linux-edac/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-edac linux-edac/ https://lore.kernel.org/linux-edac \
		linux-edac@vger.kernel.org
	public-inbox-index linux-edac

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-edac


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git