* [PATCH V2] EDAC: remove set but not used variable 'ecc_loc'
@ 2019-12-16 11:01 yu kuai
2019-12-16 12:01 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 2+ messages in thread
From: yu kuai @ 2019-12-16 11:01 UTC (permalink / raw)
To: bp, mchehab, tony.luck, james.morse, rrichter
Cc: yukuai3, yi.zhang, zhengbin13, linux-edac, linux-kernel
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/edac/i5100_edac.c: In function ‘i5100_read_log’:
drivers/edac/i5100_edac.c:489:11: warning: variable ‘ecc_loc’
set but not used [-Wunused-but-set-variable]
It is never used, and so can be removed.
Signed-off-by: yu kuai <yukuai3@huawei.com>
---
changes in V2
-remove the definition of the function i5100_redmemb_ecc_locator()
drivers/edac/i5100_edac.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/edac/i5100_edac.c b/drivers/edac/i5100_edac.c
index 0ddc41e47a96..191aa7c19ded 100644
--- a/drivers/edac/i5100_edac.c
+++ b/drivers/edac/i5100_edac.c
@@ -259,11 +259,6 @@ static inline u32 i5100_nrecmemb_ras(u32 a)
return a & ((1 << 16) - 1);
}
-static inline u32 i5100_redmemb_ecc_locator(u32 a)
-{
- return a & ((1 << 18) - 1);
-}
-
static inline u32 i5100_recmema_merr(u32 a)
{
return i5100_nrecmema_merr(a);
@@ -486,7 +481,6 @@ static void i5100_read_log(struct mem_ctl_info *mci, int chan,
u32 dw;
u32 dw2;
unsigned syndrome = 0;
- unsigned ecc_loc = 0;
unsigned merr;
unsigned bank;
unsigned rank;
@@ -499,7 +493,6 @@ static void i5100_read_log(struct mem_ctl_info *mci, int chan,
pci_read_config_dword(pdev, I5100_REDMEMA, &dw2);
syndrome = dw2;
pci_read_config_dword(pdev, I5100_REDMEMB, &dw2);
- ecc_loc = i5100_redmemb_ecc_locator(dw2);
}
if (i5100_validlog_recmemvalid(dw)) {
--
2.17.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V2] EDAC: remove set but not used variable 'ecc_loc'
2019-12-16 11:01 [PATCH V2] EDAC: remove set but not used variable 'ecc_loc' yu kuai
@ 2019-12-16 12:01 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2019-12-16 12:01 UTC (permalink / raw)
To: yu kuai
Cc: bp, tony.luck, james.morse, rrichter, yi.zhang, zhengbin13,
linux-edac, linux-kernel
Em Mon, 16 Dec 2019 19:01:21 +0800
yu kuai <yukuai3@huawei.com> escreveu:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/edac/i5100_edac.c: In function ‘i5100_read_log’:
> drivers/edac/i5100_edac.c:489:11: warning: variable ‘ecc_loc’
> set but not used [-Wunused-but-set-variable]
>
> It is never used, and so can be removed.
> Signed-off-by: yu kuai <yukuai3@huawei.com>
> ---
> changes in V2
> -remove the definition of the function i5100_redmemb_ecc_locator()
Sounds ok on my eyes.
Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> drivers/edac/i5100_edac.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/edac/i5100_edac.c b/drivers/edac/i5100_edac.c
> index 0ddc41e47a96..191aa7c19ded 100644
> --- a/drivers/edac/i5100_edac.c
> +++ b/drivers/edac/i5100_edac.c
> @@ -259,11 +259,6 @@ static inline u32 i5100_nrecmemb_ras(u32 a)
> return a & ((1 << 16) - 1);
> }
>
> -static inline u32 i5100_redmemb_ecc_locator(u32 a)
> -{
> - return a & ((1 << 18) - 1);
> -}
> -
> static inline u32 i5100_recmema_merr(u32 a)
> {
> return i5100_nrecmema_merr(a);
> @@ -486,7 +481,6 @@ static void i5100_read_log(struct mem_ctl_info *mci, int chan,
> u32 dw;
> u32 dw2;
> unsigned syndrome = 0;
> - unsigned ecc_loc = 0;
> unsigned merr;
> unsigned bank;
> unsigned rank;
> @@ -499,7 +493,6 @@ static void i5100_read_log(struct mem_ctl_info *mci, int chan,
> pci_read_config_dword(pdev, I5100_REDMEMA, &dw2);
> syndrome = dw2;
> pci_read_config_dword(pdev, I5100_REDMEMB, &dw2);
> - ecc_loc = i5100_redmemb_ecc_locator(dw2);
> }
>
> if (i5100_validlog_recmemvalid(dw)) {
Cheers,
Mauro
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-16 12:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-16 11:01 [PATCH V2] EDAC: remove set but not used variable 'ecc_loc' yu kuai
2019-12-16 12:01 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).