From: Robert Richter <rrichter@marvell.com>
To: Hanna Hawa <hhhawa@amazon.com>
Cc: <bp@alien8.de>, <mchehab@kernel.org>, <tony.luck@intel.com>,
<james.morse@arm.com>, <robh+dt@kernel.org>,
<frowand.list@gmail.com>, <davem@davemloft.net>,
<gregkh@linuxfoundation.org>, <Jonathan.Cameron@huawei.com>,
<arnd@arndb.de>, <linux-kernel@vger.kernel.org>,
<linux-edac@vger.kernel.org>, <devicetree@vger.kernel.org>,
<dwmw@amazon.co.uk>, <benh@amazon.com>, <ronenk@amazon.com>,
<talel@amazon.com>, <jonnyc@amazon.com>, <hanochu@amazon.com>,
<barakw@amazon.com>
Subject: Re: [PATCH v9 3/3] edac: Add support for Amazon's Annapurna Labs L2 EDAC
Date: Tue, 10 Mar 2020 14:47:13 +0100 [thread overview]
Message-ID: <20200310134713.n4gtrgtjdjymmgm5@rric.localdomain> (raw)
In-Reply-To: <20200129195016.956-4-hhhawa@amazon.com>
On 29.01.20 21:50:16, Hanna Hawa wrote:
> Adds support for Amazon's Annapurna Labs L2 EDAC driver to detect and
> report L2 errors.
>
> Signed-off-by: Hanna Hawa <hhhawa@amazon.com>
> ---
> MAINTAINERS | 5 +
> drivers/edac/Kconfig | 8 ++
> drivers/edac/Makefile | 1 +
> drivers/edac/al_l2_edac.c | 270 ++++++++++++++++++++++++++++++++++++++
> 4 files changed, 284 insertions(+)
> create mode 100644 drivers/edac/al_l2_edac.c
Hanna, most of the review comments by Boris for patch #1 (al_l1_edac)
apply here too. Please address them.
Thanks,
-Robert
next prev parent reply other threads:[~2020-03-10 13:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 19:50 [PATCH v9 0/3] Add support for Amazon's Annapurna Labs EDAC for L1/L2 Hanna Hawa
2020-01-29 19:50 ` [PATCH v9 1/3] edac: Add support for Amazon's Annapurna Labs L1 EDAC Hanna Hawa
2020-02-25 18:52 ` Borislav Petkov
2020-03-04 9:02 ` Hawa, Hanna
2020-01-29 19:50 ` [PATCH v9 2/3] of: EXPORT_SYMBOL_GPL of_find_next_cache_node Hanna Hawa
2020-01-29 19:50 ` [PATCH v9 3/3] edac: Add support for Amazon's Annapurna Labs L2 EDAC Hanna Hawa
2020-03-10 13:47 ` Robert Richter [this message]
2020-05-05 8:30 ` Hawa, Hanna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310134713.n4gtrgtjdjymmgm5@rric.localdomain \
--to=rrichter@marvell.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=arnd@arndb.de \
--cc=barakw@amazon.com \
--cc=benh@amazon.com \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=james.morse@arm.com \
--cc=jonnyc@amazon.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).