linux-edac.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: "Hawa, Hanna" <hhhawa@amazon.com>
Cc: "james.morse@arm.com" <james.morse@arm.com>,
	Robert Richter <rrichter@marvell.com>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	"Woodhouse, David" <dwmw@amazon.co.uk>,
	"Krupnik, Ronen" <ronenk@amazon.com>,
	talel@amazon.com, jonnyc@amazon.com, "Hanoch,
	Uri" <hanochu@amazon.com>
Subject: Re: [RFC] Support different block names with same EDAC device
Date: Tue, 12 May 2020 12:35:00 +0200	[thread overview]
Message-ID: <20200512103500.GA6859@zn.tnic> (raw)
In-Reply-To: <50666803-ed9d-670a-e9a0-994547e4cdf8@amazon.com>

On Tue, May 12, 2020 at 11:47:06AM +0300, Hawa, Hanna wrote:
> pcie/pcie0/..
>           /axi_write_parity_error/ce_count
>                                  /ue_count
>           /axi_read_parity_error/ce_count
>                                 /ue_count
>           /completion_timeout/ce_count
>                              /ue_count
>           /write_overflow_error/ce_count
>                                /ue_count
>           /parity_error/ce_count
>                        /ue_count
> 
> same for pcie1/pcie2

The "...pci" layout on my box looks like this:

$ tree /sys/devices/system/edac/pci/
/sys/devices/system/edac/pci/
├── check_pci_errors
├── edac_pci_log_npe
├── edac_pci_log_pe
├── edac_pci_panic_on_pe
├── pci0
│   ├── device -> ../../../../pci0000:00/0000:00:18.0
│   ├── npe_count
│   └── pe_count
├── pci_nonparity_count
└── pci_parity_count

so what's wrong with having "pcie0, pcie1, pcie2, ..." for those
different functional units?

I guess you could add a "name" node so that you have:

pcie
|-> pcie0
    |-> name:	axi_write_parity_error
    |-> ce_count
    |-> ue_count

and so on so that tools can know what those FUs are.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

  reply	other threads:[~2020-05-12 10:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-11 12:59 [RFC] Support different block names with same EDAC device Hawa, Hanna
2020-05-11 13:55 ` Borislav Petkov
2020-05-11 14:21   ` Hawa, Hanna
2020-05-11 14:26     ` Borislav Petkov
2020-05-12  8:47       ` Hawa, Hanna
2020-05-12 10:35         ` Borislav Petkov [this message]
2020-05-12 19:27           ` Hawa, Hanna
2020-05-12 20:01             ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200512103500.GA6859@zn.tnic \
    --to=bp@alien8.de \
    --cc=dwmw@amazon.co.uk \
    --cc=hanochu@amazon.com \
    --cc=hhhawa@amazon.com \
    --cc=james.morse@arm.com \
    --cc=jonnyc@amazon.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=ronenk@amazon.com \
    --cc=rrichter@marvell.com \
    --cc=talel@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).